summaryrefslogtreecommitdiff
path: root/libavfilter/vf_deinterlace_vaapi.c
Commit message (Collapse)AuthorAgeFilesLines
* avfilter: Replace query_formats callback with union of list and callbackAndreas Rheinhardt2021-10-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If one looks at the many query_formats callbacks in existence, one will immediately recognize that there is one type of default callback for video and a slightly different default callback for audio: It is "return ff_set_common_formats_from_list(ctx, pix_fmts);" for video with a filter-specific pix_fmts list. For audio, it is the same with a filter-specific sample_fmts list together with ff_set_common_all_samplerates() and ff_set_common_all_channel_counts(). This commit allows to remove the boilerplate query_formats callbacks by replacing said callback with a union consisting the old callback and pointers for pixel and sample format arrays. For the not uncommon case in which these lists only contain a single entry (besides the sentinel) enum AVPixelFormat and enum AVSampleFormat fields are also added to the union to store them directly in the AVFilter, thereby avoiding a relocation. The state of said union will be contained in a new, dedicated AVFilter field (the nb_inputs and nb_outputs fields have been shrunk to uint8_t in order to create a hole for this new field; this is no problem, as the maximum of all the nb_inputs is four; for nb_outputs it is only two). The state's default value coincides with the earlier default of query_formats being unset, namely that the filter accepts all formats (and also sample rates and channel counts/layouts for audio) provided that these properties agree coincide for all inputs and outputs. By using different union members for audio and video filters the type-unsafety of using the same functions for audio and video lists will furthermore be more confined to formats.c than before. When the new fields are used, they will also avoid allocations: Currently something nearly equivalent to ff_default_query_formats() is called after every successful call to a query_formats callback; yet in the common case that the newly allocated AVFilterFormats are not used at all (namely if there are no free links) these newly allocated AVFilterFormats are freed again without ever being used. Filters no longer using the callback will not exhibit this any more. Reviewed-by: Paul B Mahol <onemda@gmail.com> Reviewed-by: Nicolas George <george@nsup.org> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* avfilter/avfilter: Add numbers of (in|out)pads directly to AVFilterAndreas Rheinhardt2021-08-201-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Up until now, an AVFilter's lists of input and output AVFilterPads were terminated by a sentinel and the only way to get the length of these lists was by using avfilter_pad_count(). This has two drawbacks: first, sizeof(AVFilterPad) is not negligible (i.e. 64B on 64bit systems); second, getting the size involves a function call instead of just reading the data. This commit therefore changes this. The sentinels are removed and new private fields nb_inputs and nb_outputs are added to AVFilter that contain the number of elements of the respective AVFilterPad array. Given that AVFilter.(in|out)puts are the only arrays of zero-terminated AVFilterPads an API user has access to (AVFilterContext.(in|out)put_pads are not zero-terminated and they already have a size field) the argument to avfilter_pad_count() is always one of these lists, so it just has to find the filter the list belongs to and read said number. This is slower than before, but a replacement function that just reads the internal numbers that users are expected to switch to will be added soon; and furthermore, avfilter_pad_count() is probably never called in hot loops anyway. This saves about 49KiB from the binary; notice that these sentinels are not in .bss despite being zeroed: they are in .data.rel.ro due to the non-sentinels. Reviewed-by: Nicolas George <george@nsup.org> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* Remove unnecessary avassert.h inclusionsAndreas Rheinhardt2021-07-221-1/+0
| | | | Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* Remove unnecessary mem.h inclusionsAndreas Rheinhardt2021-07-221-1/+0
| | | | Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* avfilter: Constify all AVFiltersAndreas Rheinhardt2021-04-271-1/+1
| | | | | | | This is possible now that the next-API is gone. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Signed-off-by: James Almer <jamrial@gmail.com>
* lavfi/vf_*_vaapi: Fix error caseMark Thompson2020-02-091-1/+1
| | | | Fixes CID 1452400, 1452416, 1452550, 1452590, 1452760.
* lavfi/vaapi: Improve support for colour propertiesMark Thompson2019-06-021-4/+4
| | | | | | Attempts to pick the set of supported colour properties best matching the input. Output is then set with the same values, except for the colour matrix which may change when converting between RGB and YUV.
* lavfi/vaapi: Factorise out common code for parameter buffer setupMark Thompson2019-06-021-27/+6
| | | | | Also enables cropping on all VAAPI filters, inherited from the existing support in scale_vaapi.
* lavf/vaapi_deinterlace: return error if mode unsupportedZhong Li2019-01-251-0/+1
| | | | | | Reviewed-by: Mark Thompson <sw@jkqxz.net> Signed-off-by: Fuwei Tang <fuweix.tang@intel.com> Signed-off-by: Zhong Li <zhong.li@intel.com>
* lavfi/vaapi: Add constant VAAPI_VPP_BACKGROUND_BLACKZachary Zhou2018-12-301-1/+1
| | | | | Signed-off-by: Zachary Zhou <zachary.zhou@intel.com> Signed-off-by: Mark Thompson <sw@jkqxz.net>
* lavfi/vf_xxx_vaapi: fix typo.Jun Zhao2018-01-241-1/+1
| | | | Signed-off-by: Jun Zhao <jun.zhao@intel.com>
* lavfi: use common VAAPI VPP infrastructure for vf_deinterlace_vaapi.Jun Zhao2018-01-211-306/+45
| | | | | Signed-off-by: Jun Zhao <jun.zhao@intel.com> Signed-off-by: Mark Thompson <sw@jkqxz.net>
* lavfi/deinterlace_vaapi: fix can't show full option information.Jun Zhao2018-01-171-7/+7
| | | | | | | | use ffmpeg -h filter=deinterlace_vaapi can't get full help information, the root cause is not setting the flags fileld in options. Signed-off-by: Jun Zhao <jun.zhao@intel.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
* vaapi: Always free parameter buffers after vaEndPicture() with libva2Mark Thompson2017-10-091-1/+1
| | | | | | This is an ABI change in libva2: previously the Intel driver had this behaviour and it was implemented as a driver quirk, but now it is part of the specification so all drivers must do it.
* vf_deinterlace_vaapi: Add support for field rate outputMark Thompson2017-06-141-123/+166
| | | | | | | | | In order to work correctly with the i965 driver, this also fixes the direction of forward/backward references - forward references are intended to be those from the past to the current frame, not from the current frame to the future. (cherry picked from commit 9aa251c98ce60e5ee83156e5292547a7671ced3a)
* avfilter: do not use AVFrame accessorMuhammad Faiz2017-04-231-1/+1
| | | | | Reviewed-by: wm4 <nfxjfg@googlemail.com> Signed-off-by: Muhammad Faiz <mfcc64@gmail.com>
* vf_deinterlace_vaapi: Mark as hwframe-awareMark Thompson2017-04-011-0/+1
| | | | | Commits ade370a4 and e3fb74f7 were reordered while merging, so this change got lost.
* lavfi: Add VAAPI deinterlacerMark Thompson2017-02-231-0/+634
(cherry picked from commit ade370a4d7eab1866b6023c91c135d27c77ca465) (cherry picked from commit 2d518aec4c781316092be65893b47922c8f71b67)
View Lorry Controller Status