diff options
| author | Erik de Castro Lopo <erikd@mega-nerd.com> | 2014-03-23 21:40:54 +1100 |
|---|---|---|
| committer | Erik de Castro Lopo <erikd@mega-nerd.com> | 2014-03-23 21:41:01 +1100 |
| commit | 49d9d742e2f84295a0dca8ad9a88c94c9a57b95d (patch) | |
| tree | ce5181f5b2643c9e93e516650d4c251078d58490 | |
| parent | 697dbdee8fbc5c21a9288f09242a00d8086e5211 (diff) | |
| download | flac-49d9d742e2f84295a0dca8ad9a88c94c9a57b95d.tar.gz | |
metadata_object.c : Fix handling of zero length vorbis comment string.
Previously if a zero length string was passed in, the pointer would be
stored regardless of the copy parameter. If the original source pointer
was reassigned to something else bad things could happen.
Closes: https://sourceforge.net/p/flac/bugs/377/
| -rw-r--r-- | src/libFLAC/metadata_object.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libFLAC/metadata_object.c b/src/libFLAC/metadata_object.c index 55032389..40b7b9b1 100644 --- a/src/libFLAC/metadata_object.c +++ b/src/libFLAC/metadata_object.c @@ -264,7 +264,7 @@ static FLAC__bool vorbiscomment_set_entry_(FLAC__StreamMetadata *object, FLAC__S save = dest->entry; - if(0 != src->entry && src->length > 0) { + if(0 != src->entry) { if(copy) { /* do the copy first so that if we fail we leave the dest object untouched */ if(!copy_vcentry_(dest, src)) |