| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
When fuzzing the encoder it is possible to cause the encoder to
to take 10s of seconds or more encoding relatively short chunks of
audio. Adding a sanity check for the number of bits and returning
false (indicating memory allocation failed) prevents this and seems
to have no effect in the encoding of non-fuzzing inputs.
Credit: Oss-Fuzz
Issue: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=17319
Testcase: fuzzer_encoder-5639344026550272
|
|
|
|
|
|
|
|
|
|
|
|
| |
When fuzzing the encoder it is possible to cause the encoder to
allocate huge amounts of memory. Sanity check for the number of
bits to grow the bitwrite capacity and returning false (indicating
memory allocation failed) prevents this and seems to have no effect
in the encoding of non-fuzzing inputs.
Credit: Oss-Fuzz
Issue: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=17273
Testcase: fuzzer_encoder-5640245298593792
|
|
|
|
|
|
|
|
|
|
| |
When building in the same directory as the source, it works, but not in
a separate directory. The trailing slash is important with nasm. Note
that include_directories("${CMAKE_CURRENT_SOURCE_DIR}/") does not work
because cmake seems to strip the trailing slash.
Also relax the cmake version requirement from 3.12 to 3.9 as everywhere
else in the tree: it works just fine.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The flac configury marked clang as 'not being gcc' and excluded
a lot of compiler switches, most importantly the visibility flags,
from being used with it. This was done possibly after a problem
reported at: https://github.com/erikd/libsndfile/issues/49 .
This patch does the following:
- m4/gcc_version.m4 (XIPH_GCC_VERSION): set GCC_MAJOR_VERSION and
GCC_MINOR_VERSION to 0 for non-gcc. Previously, they were left
unset.
- configure: the gcc version checks are, naturally, against non-
zero values, so, allow many compiler switches to be used with
clang without affecting real-gcc cases.
- configure: When setting CFLAGS="-O3 -funroll-loops", also set
CXXFLAGS="-O3". Prevents g++ warnings with _FORTIFY_SOURCE, i.e.:
'_FORTIFY_SOURCE requires compiling with optimization (-O)'
Tested compilation using gcc-7.3.1 and clang-5.0.2 on x86_64-linux,
and gcc-4.4.7 and clang-3.4.2 on an i686-linux. Also tested cross-
compiling for Mac OS X using clang-5.0.2.
|
| |
|
|
|
|
|
|
|
|
| |
the issue is, flac and metaflac exes rely on flac_internal_???_utf8()
procedures from windows_unicode_filenames.c and there is no easy way
to exclude them from exports without breaking things. So export them
explicitly (they are exported anyway w/o this patch), but add a FIXME
note about the kludge in windows_unicode_filenames.c.
|
| |
|
|
|
|
|
|
| |
Credit: Oss-Fuzz
Issue: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=17069
Testcase: fuzzer_decoder-5670265022840832
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Note: One of the buildroot autobuilder provided powerpc toolchains
seem to not provide the sys/auxv.h header file, resulting in a
compile failure (see [1] for details).
[1] http://lists.busybox.net/pipermail/buildroot/2019-September/259732.html
|
|
|
|
|
|
|
|
| |
Do the addition as 64 bits before truncating to 32 bits.
Credit: Oss-Fuzz
Issue: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=16459
Testcase: fuzzer_decoder-5728784602365952
|
|
|
|
|
|
| |
Credit: Oss-Fuzz
Issue: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=16464
Testcase: fuzzer_decoder-5663276452544512
|
|
|
|
|
|
| |
Credit: Oss-Fuzz
Issue: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=16458
Testcase: fuzzer_decoder-5649174900506624
|
|
|
|
|
|
| |
Credit: OSS-Fuzz
Issue: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=16457
Testcase: fuzzer_decoder-5076189185572864
|
| |
|
|
|
|
|
|
|
|
|
| |
Applied the following suggestions:
modernize-deprecated-headers
google-readability-casting
google-readability-namespace-comments
readability-else-after-return
|
| |
|
|
|
|
| |
The f functions are faster. It seems the arguments are all floats.
|
|
|
|
| |
wcswidth needs _XOPEN_SOURCE defined. Otherwise, no declaration.
|
|
|
|
|
|
|
|
| |
Some libcs like uClibc-ng can optionally disable deprecated functions.
utime is one of them. When done so, both the header and the function go
missing.
This fixes flac_utime to work in such a situation.
|
|
|
|
|
| |
Used the elf_aux_info function on FreeBSD and clarify that users of other
systems need to implement reading from AT_HWCAP2.
|
|
|
|
|
|
|
|
| |
The 1.3.3 release didn't update the version number in the cmake
build. It's too late to fix the release, but bringing the version
number into sync allows the metaflac test which verifies the
encoder's embedded version number to pass, giving us proper test
feedback on other changes to the development tree.
|
|
|
|
|
| |
This function was added after the 1.3.2 release, but the name was bad
(missing "FLAC__" at the start) and the pointer returned should be 'const'.
|
| |
|
|
|
|
| |
One such example is sys/param.h from MinGW.
|
|
|
|
| |
validator.w3.org wants a namespace declaration for xhtml.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix "privacy-breach-w3c-valid-html" lintian error.
Don't ping an external site when loading documentation
pages since this can be used to track user activity.
These links are also broken, since they depend on the
referer header, which browsers no longer send to insecure
pages for similar privacy reasons. That aspect could be
addressed by using https urls for the validator site.
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
|
|
|
|
|
| |
Improve the conformance of the xhtml generated by doxygen by
using the self-closing <hr/> tag in the custom footer.
Without this, xmllint complains about </body> and </html> end
tags inside the still-only <hr>. That syntax is allowed in
html but not xml.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Install Doxygen when running on the linux environment to test
generation of the API documentation.
Run the included static html documentation as well as the
generated API documentation through xmllint to verify
it conforms to the declared DTD. Since this this will be very
slow or fail relying on network resources, also install
the w3c-sgml library so the xhtml1 DTDs are available locally.
We're checking the source files, not build results in the
particular environment, so it's fine to run this check
on only a subset of builds.
Don't validate on CMake builds since they're not currently
generating API documentation even when Doxygen is available.
|
| |
|
|
|
|
| |
Patch-from: Janne Hyvärinen
|
| |
|
|
|
|
|
| |
The metadata test checked for specific lengths which change from 5 bytes for
something like "1.3.2" to 9 bytes for something like "1.3.3pre1".
|
|
|
|
|
| |
Policy CMP0054 is not set: Only interpret if() arguments as variables or keywords when
unquoted.
|
| |
|
| |
|
|
|
|
|
|
| |
Rename flac application target to flacapp to avoid name collision with FLAC library target.
Closes #101.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|