From 006dcfbe23d56dc822574f9999b16adb1d32ec64 Mon Sep 17 00:00:00 2001 From: Erik de Castro Lopo Date: Tue, 31 Jan 2017 06:39:22 +1100 Subject: FLAC__stream_encoder_finish: Sanity improvement Previously this function would abort or crash if passed `NULL` for the encoder. Now it just returns without crashing or aborting which is far more sane behaviour (ie much like FLAC__stream_encoder_delete). --- src/libFLAC/stream_encoder.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libFLAC/stream_encoder.c b/src/libFLAC/stream_encoder.c index dcdc70f0..1993ec5e 100644 --- a/src/libFLAC/stream_encoder.c +++ b/src/libFLAC/stream_encoder.c @@ -1439,7 +1439,9 @@ FLAC_API FLAC__bool FLAC__stream_encoder_finish(FLAC__StreamEncoder *encoder) { FLAC__bool error = false; - FLAC__ASSERT(0 != encoder); + if (encoder == NULL) + return false; + FLAC__ASSERT(0 != encoder->private_); FLAC__ASSERT(0 != encoder->protected_); -- cgit v1.2.1