From 1837f0df2798b2fc6f953853976c622c8e26637b Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Sat, 8 Oct 2022 12:14:42 +1100 Subject: rayer_spi.c: Drop lpt_outbyte intermediate var The intermediate variable in this case serves no extra assistance in readability or additional control flow branching. Just assign the result directly into the driver state tracker. Change-Id: Idedabb7b1c401d666b3b7e621e75704c7e765fd1 Signed-off-by: Edward O'Callaghan Reviewed-on: https://review.coreboot.org/c/flashrom/+/68232 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- rayer_spi.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/rayer_spi.c b/rayer_spi.c index 8eee7ab8..41c53642 100644 --- a/rayer_spi.c +++ b/rayer_spi.c @@ -283,7 +283,6 @@ static int rayer_spi_init(const struct programmer_cfg *cfg) const struct rayer_programmer *prog = rayer_spi_types; struct rayer_pinout *pinout = NULL; uint16_t lpt_iobase; - uint8_t lpt_outbyte; char *prog_type; if (get_params(cfg, &lpt_iobase, &prog_type) < 0) @@ -312,9 +311,6 @@ static int rayer_spi_init(const struct programmer_cfg *cfg) if (rget_io_perms()) return 1; - /* Get the initial value before writing to any line. */ - lpt_outbyte = INB(lpt_iobase); - struct rayer_spi_data *data = calloc(1, sizeof(*data)); if (!data) { msg_perr("Unable to allocate space for SPI master data\n"); @@ -322,7 +318,8 @@ static int rayer_spi_init(const struct programmer_cfg *cfg) } data->pinout = pinout; data->lpt_iobase = lpt_iobase; - data->lpt_outbyte = lpt_outbyte; + /* Get the initial value before writing to any line. */ + data->lpt_outbyte = INB(lpt_iobase); if (pinout->shutdown) register_shutdown(pinout->shutdown, data); -- cgit v1.2.1