From a75816168d7324124fc5c585623fca71dd8b3fba Mon Sep 17 00:00:00 2001 From: hailfinger Date: Fri, 5 Jun 2009 18:32:07 +0000 Subject: Sometimes we want to read/write more than 4 bytes of chip content at once. Add chip_{read,write}n to the external flasher infrastructure which read/write n bytes at once. Fix a few places where the code used memcpy/memcmp although that is strictly impossible with external flashers. Place a FIXME in the layout.c code because usage is not totally clear and needs to be fixed to support external flashers. As a nice side benefit, we get a noticeable speedup for builtin flash reading which is now a memcpy() of the full flash area instead of a series of single-byte reads. Signed-off-by: Carl-Daniel Hailfinger Acked-by: Urja Rannikko Acked-by: Uwe Hermann git-svn-id: https://code.coreboot.org/svn/flashrom/trunk@579 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- internal.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) (limited to 'internal.c') diff --git a/internal.c b/internal.c index d24bb34..302c7a9 100644 --- a/internal.c +++ b/internal.c @@ -165,6 +165,12 @@ uint32_t internal_chip_readl(const chipaddr addr) return mmio_readl((void *) addr); } +void internal_chip_readn(uint8_t *buf, const chipaddr addr, size_t len) +{ + memcpy(buf, (void *)addr, len); + return; +} + void mmio_writeb(uint8_t val, void *addr) { *(volatile uint8_t *) addr = val; @@ -249,3 +255,19 @@ uint32_t fallback_chip_readl(const chipaddr addr) val |= chip_readw(addr + 2) << 16; return val; } + +void fallback_chip_writen(uint8_t *buf, chipaddr addr, size_t len) +{ + size_t i; + for (i = 0; i < len; i++) + chip_writeb(buf[i], addr + i); + return; +} + +void fallback_chip_readn(uint8_t *buf, chipaddr addr, size_t len) +{ + size_t i; + for (i = 0; i < len; i++) + buf[i] = chip_readb(addr + i); + return; +} -- cgit v1.2.1