From 6610a35274f248e21e4142d9c3ec28f20877b14e Mon Sep 17 00:00:00 2001 From: hailfinger Date: Sat, 21 Jul 2012 17:27:08 +0000 Subject: Automatically release I/O permissions on shutdown. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit get_io_perms() is renamed to rget_io_perms() and automatically registers a function to release I/O permissions on shutdown. Actually release I/O permissions on Solaris and iopl()-supporting operating systems like Linux. This patch fixes quite a few programmers which forgot to release I/O permissions on shutdown, and it simplifies the shutdown and error handling code for all others. Do not call exit(1) if I/O permissions are denied and return an error instead. This part of the patch was written by Niklas Söderlund. Signed-off-by: Carl-Daniel Hailfinger Signed-off-by: Niklas Söderlund Acked-by: Michael Karcher git-svn-id: https://code.coreboot.org/svn/flashrom/trunk@1551 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- ogp_spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'ogp_spi.c') diff --git a/ogp_spi.c b/ogp_spi.c index 2966024..13091b4 100644 --- a/ogp_spi.c +++ b/ogp_spi.c @@ -99,7 +99,6 @@ static int ogp_spi_shutdown(void *data) { physunmap(ogp_spibar, 4096); pci_cleanup(pacc); - release_io_perms(); return 0; } @@ -129,7 +128,8 @@ int ogp_spi_init(void) return 1; } - get_io_perms(); + if (rget_io_perms()) + return 1; io_base_addr = pcidev_init(PCI_BASE_ADDRESS_0, ogp_spi); -- cgit v1.2.1