From 61fb3fd74923a53a71364148ae99b38ced2f9941 Mon Sep 17 00:00:00 2001 From: stefanct Date: Fri, 7 Sep 2012 07:07:07 +0000 Subject: Remove exit calls from sp_sync_read_timeout and sp_synchronize. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add return values to sp_synchronize so we can signal a failure to the only upstream caller (serprog_init), which is prepared to propagate a failure. sp_sync_read_timeout was harder to fix because it already used a return value, but we needed to distinguish two different failure modes. This solution distinguishes them by the sign of the return values, which maintains readability as much as possible. Thanks to Niklas Söderlund for the original patch and idea. Signed-off-by: Niklas Söderlund Signed-off-by: Stefan Tauner Acked-by: Stefan Tauner git-svn-id: https://code.coreboot.org/svn/flashrom/trunk@1595 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- serial.c | 1 + 1 file changed, 1 insertion(+) (limited to 'serial.c') diff --git a/serial.c b/serial.c index 05c7d04..7e47dcc 100644 --- a/serial.c +++ b/serial.c @@ -239,6 +239,7 @@ void sp_flush_incoming(void) #ifdef _WIN32 PurgeComm(sp_fd, PURGE_RXCLEAR); #else + /* FIXME: error handling */ tcflush(sp_fd, TCIFLUSH); #endif return; -- cgit v1.2.1