From 63e7aa8b6931529e1c7c0ef1fa1cf4198f394e7f Mon Sep 17 00:00:00 2001 From: stefanct Date: Sun, 18 Sep 2011 22:42:18 +0000 Subject: Revert "Unsignify lengths and addresses in chip functions and structs" - probe_timing was changed to unsigned although we use negative values for special cases - some code was not changed along hence did no longer compile: * dediprog's read and write functions * linux_spi's read and write functions - it introduced a number of new sign conversion warnings (http://paste.flashrom.org/view.php?id=832) To be safe this patch reverts all changes made in r1448, a corrected patch will follow later. Thanks to idwer for pointing out the problem first! Signed-off-by: Stefan Tauner Acked-by: Stefan Tauner git-svn-id: https://code.coreboot.org/svn/flashrom/trunk@1450 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- serprog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'serprog.c') diff --git a/serprog.c b/serprog.c index a4aef08..9d554c9 100644 --- a/serprog.c +++ b/serprog.c @@ -795,7 +795,7 @@ int serprog_spi_send_command(unsigned int writecnt, unsigned int readcnt, * the advantage that it is much faster for most chips, but breaks those with * non-contiguous address space (like AT45DB161D). When spi_read_chunked is * fixed this method can be removed. */ -int serprog_spi_read(struct flashchip *flash, uint8_t *buf, unsigned int start, unsigned int len) +int serprog_spi_read(struct flashchip *flash, uint8_t *buf, int start, int len) { int i; int cur_len; -- cgit v1.2.1