From 48e9d53a7fc7d655d4ba192c15a6f33ca336455a Mon Sep 17 00:00:00 2001 From: hailfinger Date: Tue, 22 Dec 2009 23:54:10 +0000 Subject: Add a few FIXME comments to the generic SPI code. Signed-off-by: Carl-Daniel Hailfinger Acked-by: Carl-Daniel Hailfinger git-svn-id: https://code.coreboot.org/svn/flashrom/trunk@814 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- spi.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'spi.c') diff --git a/spi.c b/spi.c index a2b26c5..43dc4bf 100644 --- a/spi.c +++ b/spi.c @@ -807,6 +807,7 @@ int spi_write_status_register(int status) int result; struct spi_command cmds[] = { { + /* FIXME: WRSR requires either EWSR or WREN depending on chip type. */ .writecnt = JEDEC_EWSR_OUTSIZE, .writearr = (const unsigned char[]){ JEDEC_EWSR }, .readcnt = 0, @@ -1059,6 +1060,7 @@ int spi_aai_write(struct flashchip *flash, uint8_t *buf) fprintf(stderr, "ERASE FAILED!\n"); return -1; } + /* FIXME: This will fail on ICH/VIA SPI. */ result = spi_write_enable(); if (result) return result; -- cgit v1.2.1