diff options
| author | Philip Withnall <pwithnall@endlessos.org> | 2021-06-14 17:13:36 +0100 |
|---|---|---|
| committer | Alexander Larsson <alexander.larsson@gmail.com> | 2021-06-16 17:59:45 +0200 |
| commit | a7af60f498f3a7641e1cb43aa37e058d5c17774a (patch) | |
| tree | 631dda1f3073d8837cedef4f951c3f08cbde5283 | |
| parent | f2b4edc558677422c21b7283f250b1e3dfeaffe0 (diff) | |
| download | flatpak-a7af60f498f3a7641e1cb43aa37e058d5c17774a.tar.gz | |
flatpak-transaction: Squash error propagation and fix return value
It doesn’t look like this error path is taken very often. Spotted while
reading through the code.
This function is opportunistically looking for dependencies, so a
failure in one remote shouldn’t make the whole operation fail.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
| -rw-r--r-- | common/flatpak-transaction.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/common/flatpak-transaction.c b/common/flatpak-transaction.c index afdf2c8b..a6bf4d60 100644 --- a/common/flatpak-transaction.c +++ b/common/flatpak-transaction.c @@ -2199,8 +2199,8 @@ search_for_dependency (FlatpakTransaction *self, state = flatpak_transaction_ensure_remote_state (self, FLATPAK_TRANSACTION_OPERATION_INSTALL, remote, NULL, &local_error); if (state == NULL) { - g_debug ("Can't get state for remote %s: %s", remote, local_error->message); - return FALSE; + g_debug ("Can't get state for remote %s, ignoring: %s", remote, local_error->message); + continue; } if (flatpak_remote_state_lookup_ref (state, flatpak_decomposed_get_ref (runtime_ref), NULL, NULL, NULL, NULL, NULL)) |