summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthew Leeds <matthew.leeds@endlessm.com>2018-07-10 16:52:40 +0200
committerAlexander Larsson <alexander.larsson@gmail.com>2018-07-10 19:25:51 +0200
commitb664a2981c3bd61944b2d71b7992860f470302fd (patch)
tree96cf2d36db63de00f1789a64fd98ea97de0e4f91
parentadffe7d15f80bf54ec48638c46fcf676adda5508 (diff)
downloadflatpak-b664a2981c3bd61944b2d71b7992860f470302fd.tar.gz
transaction: Fix NULL pointer dereference
This fixes coverity issue 1471684, and ensures we can correctly generate an error message in flatpak_transaction_add_install_flatpakref().
-rw-r--r--common/flatpak-transaction.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/common/flatpak-transaction.c b/common/flatpak-transaction.c
index 76f1a644..1fa13b02 100644
--- a/common/flatpak-transaction.c
+++ b/common/flatpak-transaction.c
@@ -1428,7 +1428,7 @@ flatpak_transaction_add_install_flatpakref (FlatpakTransaction *self,
if (!g_key_file_load_from_data (keyfile, g_bytes_get_data (flatpakref_data, NULL),
g_bytes_get_size (flatpakref_data),
- 0, error))
+ 0, &local_error))
return flatpak_fail (error, "Invalid .flatpakref: %s", local_error->message);
priv->flatpakrefs = g_list_append (priv->flatpakrefs, g_steal_pointer (&keyfile));