summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* install: Avoid a superfluous prompt to choose the only remote4364-install-from-only-remotePhaedrus Leeds2021-08-233-6/+8
| | | | | | | | | | | | The install command can search available remotes for a specified flatpak when a remote wasn't specified. In case only one remote is configured, or in case only one of the configured remotes matches the ref specified, we currently prompt the user to confirm use of the remote anyway (unless -y/--assumeyes was used). Skip this prompt even when -y/--assumeyes was not used, since the remote to use will still effectively be confirmed when the list of refs to be installed is presented for confirmation. Fixes https://github.com/flatpak/flatpak/issues/4364
* Update NEWS with pending changesSimon McVittie2021-08-231-0/+29
| | | | Signed-off-by: Simon McVittie <smcv@collabora.com>
* remove trailing whitespacea13460542021-08-232-4/+2
| | | | Signed-off-by: a1346054 <36859588+a1346054@users.noreply.github.com>
* bash: fix issues identified through shellchecka13460542021-08-232-8/+8
| | | | Signed-off-by: a1346054 <36859588+a1346054@users.noreply.github.com>
* fix spellinga13460542021-08-232-4/+4
| | | | Signed-off-by: a1346054 <36859588+a1346054@users.noreply.github.com>
* completion: bash completion files are not supposed to be executablea13460542021-08-231-0/+0
| | | | Signed-off-by: a1346054 <36859588+a1346054@users.noreply.github.com>
* Update es.poRodhos2021-08-231-226/+169
|
* Update bubblewrap to v0.5.0Simon McVittie2021-08-231-0/+0
| | | | Signed-off-by: Simon McVittie <smcv@collabora.com>
* run: Don't let XDG_RUNTIME_DIR from user override the value we setSimon McVittie2021-08-202-1/+11
| | | | | | | | | | | | | | | | | | We use `bwrap --setenv XDG_RUNTIME_DIR` to set it to `/run/user/UID`, regardless of what it is on the host system, but the changes made to resolve CVE-2021-21261 unintentionally broke this by overwriting it with the user's XDG_RUNTIME_DIR. In practice this worked for most people, who either have XDG_RUNTIME_DIR set to the same value we use (which is the conventional setup from systemd-logind and elogind), or entirely unset (if they do not have systemd-logind or elogind). However, it broke Wayland and other XDG_RUNTIME_DIR-based protocols for people who intentionally set up an XDG_RUNTIME_DIR that is different. Fixes: 6d1773d2 "run: Convert all environment variables into bwrap arguments" Resolves: https://github.com/flatpak/flatpak/issues/4372 Signed-off-by: Simon McVittie <smcv@collabora.com>
* tests: Exercise attempting to export a nonexistent directorySimon McVittie2021-08-021-0/+7
| | | | Signed-off-by: Simon McVittie <smcv@collabora.com>
* tests: Exercise refusal to export a self-recursive symlinkSimon McVittie2021-08-021-0/+4
| | | | Signed-off-by: Simon McVittie <smcv@collabora.com>
* tests: Exercise exporting a directory whose parent is a symlinkSimon McVittie2021-08-021-0/+8
| | | | Signed-off-by: Simon McVittie <smcv@collabora.com>
* tests: Test the special case for --filesystem=/tmp if /tmp is a symlinkSimon McVittie2021-08-021-0/+6
| | | | | | | If /tmp is a symlink, we mount the target directory on /tmp instead of replicating the symlink, so that it will not interfere with "--dir /tmp". Signed-off-by: Simon McVittie <smcv@collabora.com>
* tests: Exercise failure to export a non-absolute pathSimon McVittie2021-08-021-0/+3
| | | | Signed-off-by: Simon McVittie <smcv@collabora.com>
* tests: Exercise failure to export a broken autofsSimon McVittie2021-08-023-9/+67
| | | | | | | To achieve this, add a flag to FlatpakExports to make it fake a broken autofs. Signed-off-by: Simon McVittie <smcv@collabora.com>
* tests: Add a skeleton for testing unusual/corner-case situationsSimon McVittie2021-08-021-0/+41
| | | | Signed-off-by: Simon McVittie <smcv@collabora.com>
* exports: Make all filesystem accesses relative to the mock root fdSimon McVittie2021-08-021-17/+96
| | | | Signed-off-by: Simon McVittie <smcv@collabora.com>
* utils: Document that flatpak_canonicalize_filename() does not do I/OSimon McVittie2021-08-021-0/+6
| | | | Signed-off-by: Simon McVittie <smcv@collabora.com>
* exports: Close mock host fd when destroyedSimon McVittie2021-08-021-0/+1
| | | | | | Previously this was leaked. Signed-off-by: Simon McVittie <smcv@collabora.com>
* tests: Add test coverage for a mock Fedora-like systemSimon McVittie2021-08-021-0/+51
| | | | | | | | In particular this tests commit 3aaea7d2 "Expose /var/usrlocal if "--filesystem=host" is specified" and checks that /var/usrlocal is counted as part of --filesystem=host-usr. Signed-off-by: Simon McVittie <smcv@collabora.com>
* Update Russian translationgasinvein2021-08-021-19/+22
|
* .github: Add Sponsor buttonPhaedrus Leeds2021-08-021-0/+1
|
* Update Brazilian Portuguese translationBruno Lopes2021-08-021-47/+40
|
* Update Ukrainian translationYuri Chornoivan2021-07-051-4/+5
|
* Update translation files for v1.11.21.11.2Simon McVittie2021-06-1719-4310/+4380
| | | | Signed-off-by: Simon McVittie <smcv@collabora.com>
* Prepare release 1.11.2Simon McVittie2021-06-172-1/+29
| | | | Signed-off-by: Simon McVittie <smcv@collabora.com>
* build: Don't include gdbus-codegen-generated files in tarballSimon McVittie2021-06-171-1/+3
| | | | | | | | To be excluded from tarball releases, generated files need to be in nodist_ lists of sources every time they appear. Fixes: 412c1577 "portal: Add some test coverage" Signed-off-by: Simon McVittie <smcv@collabora.com>
* flatpak-transaction: Fix finding runtime with non-default remote+archPhilip Withnall2021-06-161-1/+2
| | | | | | | | | | | Fix an “The application foo requires the runtime bla which was not found” error when using libflatpak (not the CLI) to install an application whose runtime is provided by a different repo, and which is for a non-default architecture. This is a follow-up to commit f2ff664ff. Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
* flatpak-transaction: Squash error propagation and fix return valuePhilip Withnall2021-06-161-2/+2
| | | | | | | | | | It doesn’t look like this error path is taken very often. Spotted while reading through the code. This function is opportunistically looking for dependencies, so a failure in one remote shouldn’t make the whole operation fail. Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
* Improve release checklistSimon McVittie2021-06-151-1/+2
| | | | Signed-off-by: Simon McVittie <smcv@collabora.com>
* portal: Fix a typo in D-Bus API documentationSimon McVittie2021-06-151-2/+2
| | | | | | | | | | The client-side proposed for flatpak-spawn uses --app-path, but the actual implementation on D-Bus uses file descriptor passing and an option named app-fd, so the documentation of the D-Bus interface should be written in terms of app-fd. Fixes: 3ebf371f "run: Allow caller to replace /app and/or /usr" Signed-off-by: Simon McVittie <smcv@collabora.com>
* Reword to make it clearer how (not) to invoke flatpakDennis Schridde2021-06-151-1/+1
|
* Fix grammarDennis Schridde2021-06-151-1/+1
|
* Improve error message for sudo flatpak runDennis Schridde2021-06-151-1/+1
| | | | Closes: https://github.com/flatpak/flatpak/issues/3963
* flatpak-installation: Fix some typos in documentation commentsPhilip Withnall2021-06-141-3/+3
| | | | Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
* CI: Add mono apt repo to fix buildAlexander Larsson2021-06-011-0/+4
| | | | | | | | | | | | | | | | | For whatever reason parts of mono is installed, but the repo is not configured so there is a version conflict on update: libglib2.0-cil is already the newest version (2.12.45-0xamarin19+ubuntu1604b1). libglib2.0-cil set to manually installed. Some packages could not be installed. This may mean that you have requested an impossible situation or if you are using the unstable distribution that some required packages have not yet been created or been moved out of Incoming. The following information may help to resolve the situation: The following packages have unmet dependencies: libglib2.0-cil-dev : Depends: libglib2.0-cil (= 2.12.10-6) but 2.12.45-0xamarin19+ubuntu1604b1 is to be installed E: Unable to correct problems, you have held broken packages.
* transaction: Don’t abort on uninstall if deploy metadata is missingPhilip Withnall2021-06-011-0/+5
| | | | | | | | | | | | | If the deploy metadata is missing for the locale runtime of an app which is being uninstalled, flatpak will currently abort on an assertion failure. Prevent that abort, at the expense of not uninstalling the locale runtime. A better fix could be found for this in future. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Fixes: #3943
* Update Indonesian translationKukuh Syafaat2021-06-011-273/+275
|
* Update Russian translationgasinvein2021-06-011-382/+358
|
* README: Update chat room linkPhaedrus Leeds2021-05-281-1/+1
| | | | | | We've moved from Freenode to Matrix, see: https://discourse.flathub.org/t/should-flathub-flatpak-move-to-another-communication-channel-if-so-where-and-why/1443 https://lists.freedesktop.org/archives/flatpak/2021-May/002127.html
* portal: Add some test coverageSimon McVittie2021-05-255-2/+743
| | | | | | This exercises Spawn() and reproduces #4286. Signed-off-by: Simon McVittie <smcv@collabora.com>
* portal: Add some design-for-testSimon McVittie2021-05-251-4/+26
| | | | | | | | | | | During unit testing we don't have a complete Flatpak app or runtime available, and `flatpak run` is not necessarily in FLATPAK_BINDIR yet; but we can run the portal with this environment variable set, to specify a mock implementation of Flatpak. This helps to reproduce #4286. Signed-off-by: Simon McVittie <smcv@collabora.com>
* portal: Add NONE values for flags setsSimon McVittie2021-05-251-0/+3
| | | | Signed-off-by: Simon McVittie <smcv@collabora.com>
* tests: Test environment block parsingSimon McVittie2021-05-252-0/+133
| | | | Signed-off-by: Simon McVittie <smcv@collabora.com>
* context: Factor out functions to parse an environment blockSimon McVittie2021-05-252-24/+55
| | | | | | This makes them easier to test, and easier to use in related tests. Signed-off-by: Simon McVittie <smcv@collabora.com>
* portal: Remap --env-fd into child process's fd spaceSimon McVittie2021-05-251-2/+10
| | | | | | | | | | Just because we can allocate a new, unused fd in the portal's fd space, that doesn't mean that fd number is going to be unused in the child process's fd space: we might need to remap it. Resolves: flatpak/flatpak#4286 Fixes: aeb6a7ab "portal: Convert --env in extra-args into --env-fd" Signed-off-by: Simon McVittie <smcv@collabora.com>
* portal: Use a GArray to store fdsSimon McVittie2021-05-251-39/+42
| | | | | | | | | | | | This will allow us to add additional mapping entries for fds to be used internally by `flatpak run`, in particular --env-fd. Defer the second pass through the fd array until the last possible moment, so that any extra fds we want to add (like the --env-fd) have already been added by then. Helps: flatpak/flatpak#4286 Signed-off-by: Simon McVittie <smcv@collabora.com>
* portal: Don't leak fd used for serialized environmentSimon McVittie2021-05-251-3/+4
| | | | | | | | | Otherwise we'll run out of file descriptors eventually, when starting a sufficiently large number of subsandboxes. Resolves: flatpak/flatpak#4285 Fixes: aeb6a7ab "portal: Convert --env in extra-args into --env-fd" Signed-off-by: Simon McVittie <smcv@collabora.com>
* Don't disable -Wformat-nonliteral unnecessarilySimon McVittie2021-05-251-12/+0
| | | | | | | These functions were already annotated with G_GNUC_PRINTF, so gcc can assume that the format string and arguments match up. Signed-off-by: Simon McVittie <smcv@collabora.com>
* Add missing G_GNUC_PRINTF attributesSimon McVittie2021-05-255-13/+3
| | | | | | | | | | This allows callers to be checked for mismatches between format string and arguments, and also means gcc can assume that the format string and the arguments match up correctly when forwarding them to functions like g_strdup_vprintf, removing the need to suppress -Wformat-nonliteral warnings. Signed-off-by: Simon McVittie <smcv@collabora.com>
View Lorry Controller Status