| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
Now we can add [skip ci] to a commit message to skip CI when it's not
needed, to avoid wasting resources. Thanks
https://github.com/veggiemonk/skip-commit/issues/5
|
| | |
|
| |\
| |
| | |
dir: Don't mask the main ref of a noenumerate remote
|
| | |
| |
| |
| | |
Always good to expand the test coverage
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In a recent commit I changed flatpak_dir_list_remote_refs() to make main
refs (xa.main-ref) visible for noenumerate remotes (xa.noenumerate),
meaning that an origin remote created for a flatpakref file can be used
to get information about the ref from the file even before it is
installed. This commit extends that work to include extensions of the
main ref, and updates the unit test to check for this. The reasoning is
that if GNOME Software wants to show the user information about, say,
VLC from a flatpakref file before installing it, Software would want to
also show the available plugins so the user can decide if they want to
install those as well. I haven't checked if Software actually does that;
I'm only focusing on making libflatpak do the right thing.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently the xa.noenumerate option on a remote is documented as causing
the remote not to be used when presenting available apps/runtimes or
when searching for dependencies. The idea is that the remote is only
used for providing updates for things installed from it, and this
functionality is used when creating an origin remote for something
installed via a flatpakref file.
However, the implementation of this in flatpak_dir_list_remote_refs() is
buggy. It returns an empty set of refs even if something is both locally
installed and available from the remote. This is because it is using
hash table comparisons of FlatpkDecomposed objects (via
flatpak_decomposed_hash()) which take into account both the ref (or
refspec) and the collection ID, and the local refs' FlatpakDecomposed
objects are created from a refspec whereas the remote refs'
FlatpakDecomposed objects are created from a ref alone. We could fix
this by having them both use refspecs, but it is better to use a
collection-ref tuple for the following reasons:
(1) Changing flatpak_dir_list_all_remote_refs() to use a refspec to
create the FlatpakDecomposed objects would be a breaking change for the
other users of that function.
(2) Both the local and remote refs are from the same remote so we don't
need to use the remote name to disambiguate them, even if no collection
ID is configured.
(3) The whole point of collection IDs is to make refs uniquely
identifiable, so we're using them for the intended purpose.
In addition to fixing this bug, this commit adds a unit test in
testlibrary.c so it stays fixed.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When we create origin remotes for apps installed via .flatpakref files,
we set xa.noenumerate=true and
xa.main-ref=app/com.example.App/arch/branch so that the remote is only
used for the app it was intended for. This is implemented in
flatpak_dir_list_remote_refs() by only listing refs in the remote which
are already installed. This works fine after the ref is installed but in
the short timespan between when the origin remote is created and the app
is installed from it, it means that the remote appears as empty.
The use case where I ran into this is in attempting to use
flatpak_installation_fetch_remote_ref_sync() in the gnome-software
flatpak plugin, in the handling of flatpakref files, which is intended
to just display information to the user and let them decide whether to
install the app. But I was not able to create a FlatpakRemoteRef due to
the behavior described above; see #4453 for more details.
So, change the behavior so that the main ref for an origin remote is
visible even before it is installed. This technically could be a
breaking change for some consumer of libflatpak but that seems very
unlikely, and the new behavior makes more sense.
Also add a unit test for this behavior.
|
| |\ \
| | |
| | | |
session-helper: Move FlatpakHostCommandFlags to header file
|
| | | |
| | |
| | |
| | | |
Signed-off-by: Simon McVittie <smcv@collabora.com>
|
| |/ /
| |
| |
| | |
Signed-off-by: Simon McVittie <smcv@collabora.com>
|
| |\ \
| | |
| | | |
Update Swedish translation
|
| | | | |
|
| | | | |
|
| |\ \ \
| |/ /
|/| | |
flatpak-utils-http: Ensure to wake up the main context on error
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
All the other code paths which set `data->done` or `data->error` ensure
to wake up the main context so its loop exit conditions can be checked
again — this code path was missing a wakeup though.
Spotted by code inspection; I haven’t hit this in the wild.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
|
| |\ \
| | |
| | | |
Add test coverage for our seccomp filter
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
In particular, this checks that CVE-2017-5226, CVE-2019-10063 and
CVE-2021-41133 are still prevented.
Signed-off-by: Simon McVittie <smcv@collabora.com>
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| | |
This exercises various syscalls. It's heavily based on the one from
<https://github.com/containers/bubblewrap/pull/459>, but with the
addition of a mode to output the numeric values of various expected
errno codes, which are not otherwise available to shell scripts.
Signed-off-by: Simon McVittie <smcv@collabora.com>
|
| | | |
|
| | | |
|
| |\ \
| | |
| | | |
build-init: Use SDK arch for SDK extensions...
|
| | | |
| | |
| | |
| | | |
...instead of the app we're building arch.
|
| |\ \ \
| | | |
| | | | |
tests: Generate Makefile-test-matrix.am.inc in $(srcdir)
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
Files that are generated manually by a maintainer and committed to git
should be in the srcdir, not the builddir.
Signed-off-by: Simon McVittie <smcv@collabora.com>
|
| | |/
|/| |
|
| | |
| |
| |
| | |
This would have been helpful in my work on #4453
|
| | |
| |
| |
| |
| |
| |
| | |
Currently the output produced when assert_remote_in_installation() or
assert_remote_not_in_installation() fails is not helpful: it doesn't
mention the remote name or where the assertion was called from. Fix
those problems by rewriting it as a #define.
|
| | |
| |
| |
| | |
It's easier to reason about the tests if they don't leave state behind.
|
| | |
| |
| |
| |
| | |
This will make the next commit simpler, and in my opinion this makes the
code more readable.
|
| |/
|
|
| |
Per the documentation, g_assert_null() is meant for unit tests.
|
| |\
| |
| | |
tests: Allow FLATPAK_BINARY=flatpak for exports
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
https://github.com/flatpak/flatpak/commit/a99b748931e6444dadb0d0c8c1565da23f755800 introduced an environment variable for changing the flatpak path for exports.
On NixOS, we do not have a stable path we could use so we used to patch Flatpak to use `flatpak` program from `PATH`.
With the recent change, we drop our downstream patch in favour of setting the environment variable to `flatpak` but the tests do not expect that.
This is the test part of our former downstream patch so that tests can pass with exports using `flatpak` instead of an absolute path.
It still expects the binary path to end with `flatpak` so arbitrary `$FLATPAK_BINARY` will not work but we do not pass the environment variable to tests so we cannot do much better.
|
| | | |
|
| | | |
|
| |\ \
| |/
|/| |
Update Polish translation 211017 for the main branch
|
| |/ |
|
| |
|
|
|
|
|
|
|
|
| |
g_key_file_get_boolean() only accepts lower case "true" and "false", so
correct some instances of "False" in key files. This makes no functional
difference as long as the error pointer isn't checked since
g_key_file_get_boolean() also returns false when it can't parse the
value as a boolean. But it still seems good to be correct, and someone
could interpret the existence of "IsRuntime=False" as implying that
"IsRuntime=True" will work, which it doesn't.
|
| | |
|
| |\
| |
| | |
Fix some warn_unused_result warnings
|
| | |
| |
| |
| | |
While building on gcc 9.3.0
|
| |\ \
| | |
| | | |
Switch to GitHub forms
|
| | | |
| | |
| | |
| | |
| | | |
This MR switches to GitHub forms to improve user experience when opening an issue.
It includes a bug template and a feature request template.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
flatpak 1.12.2
Git-EVTag-v0-SHA512: 5e6e119c2d8f39bdbc55735a5819235de430712a049793b1a64a94bcd2a8a7a7ade5dedaf5098c51b25366cf0d3b3029302cc8f8b42821f76b6db493142ac7ea
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: Simon McVittie <smcv@collabora.com>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: Simon McVittie <smcv@collabora.com>
|
| | | | | |
|
| |\ \ \ \
| |/ / / |
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: Simon McVittie <smcv@collabora.com>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: Simon McVittie <smcv@collabora.com>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: Simon McVittie <smcv@collabora.com>
|
