diff options
| author | Sebastian Rasmussen <sebras@gmail.com> | 2020-06-18 15:12:03 +0800 |
|---|---|---|
| committer | Werner Lemberg <wl@gnu.org> | 2020-06-19 03:53:27 +0200 |
| commit | 575b78d9e3b9c701edb5087aa1c5f9c4031d3548 (patch) | |
| tree | 1ec17e38f73381249f3c7a7368b18b407058f00c | |
| parent | 74cebeae1249f8ebade559a7316fe84db7a36fd2 (diff) | |
| download | freetype2-575b78d9e3b9c701edb5087aa1c5f9c4031d3548.tar.gz | |
[cff] Fix memory leak (#58610).
* src/cff/cffobjs.c (cff_size_init): When the call to
`funcs->create' fails, make sure to free `internal'.
| -rw-r--r-- | ChangeLog | 7 | ||||
| -rw-r--r-- | src/cff/cffobjs.c | 12 |
2 files changed, 15 insertions, 4 deletions
@@ -1,3 +1,10 @@ +2020-06-19 Sebastian Rasmussen <sebras@gmail.com> + + [cff] Fix memory leak (#58610). + + * src/cff/cffobjs.c (cff_size_init): When the call to + `funcs->create' fails, make sure to free `internal'. + 2020-06-19 Werner Lemberg <wl@gnu.org> * src/cff/cffload.c (cff_index_get_pointers): Rename `t' to `tbl'. diff --git a/src/cff/cffobjs.c b/src/cff/cffobjs.c index 981bc7009..252f58a5b 100644 --- a/src/cff/cffobjs.c +++ b/src/cff/cffobjs.c @@ -166,15 +166,16 @@ FT_Error error = FT_Err_Ok; PSH_Globals_Funcs funcs = cff_size_get_globals_funcs( size ); + FT_Memory memory = cffsize->face->memory; + CFF_Internal internal = NULL; + if ( funcs ) { - CFF_Face face = (CFF_Face)cffsize->face; - CFF_Font font = (CFF_Font)face->extra.data; - CFF_Internal internal = NULL; + CFF_Face face = (CFF_Face)cffsize->face; + CFF_Font font = (CFF_Font)face->extra.data; PS_PrivateRec priv; - FT_Memory memory = cffsize->face->memory; FT_UInt i; @@ -206,6 +207,9 @@ size->strike_index = 0xFFFFFFFFUL; Exit: + if ( error ) + FT_FREE( internal ); + return error; } |