From 30d665adea53e84ee232e04450c91e59a0b3d90c Mon Sep 17 00:00:00 2001 From: "Arnold D. Robbins" Date: Wed, 20 Jan 2016 22:10:38 +0200 Subject: Minor regex code cleanup. --- ChangeLog | 7 +++++++ regcomp.c | 4 ++-- regex_internal.h | 1 - 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 09d5732d..b298db98 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2016-01-20 Arnold D. Robbins + + * regex_internal.h [attribute_hidden]: Remove definition. + * regcomp.c [attribute_hidden]: Remove uses. Not needed since + the variables are static. Thanks to Paul Eggert for pointing + this out. + 2016-01-18 Paul Eggert Diagnose ERE '()|\1' diff --git a/regcomp.c b/regcomp.c index 35a6c218..4ddbade0 100644 --- a/regcomp.c +++ b/regcomp.c @@ -137,7 +137,7 @@ static reg_errcode_t mark_opt_subexp (void *extra, bin_tree_t *node); POSIX doesn't require that we do anything for REG_NOERROR, but why not be nice? */ -static const char __re_error_msgid[] attribute_hidden = +static const char __re_error_msgid[] = { #define REG_NOERROR_IDX 0 gettext_noop ("Success") /* REG_NOERROR */ @@ -191,7 +191,7 @@ static const char __re_error_msgid[] attribute_hidden = gettext_noop ("Unmatched ) or \\)") /* REG_ERPAREN */ }; -static const size_t __re_error_msgid_idx[] attribute_hidden = +static const size_t __re_error_msgid_idx[] = { REG_NOERROR_IDX, REG_NOMATCH_IDX, diff --git a/regex_internal.h b/regex_internal.h index 6cc84a79..ff26be7b 100644 --- a/regex_internal.h +++ b/regex_internal.h @@ -143,7 +143,6 @@ is_blank (int c) # define __mempcpy mempcpy # define __wcrtomb wcrtomb # define __regfree regfree -# define attribute_hidden #endif /* not _LIBC */ #if __GNUC__ < 3 + (__GNUC_MINOR__ < 1) -- cgit v1.2.1