summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormpolacek <mpolacek@138bc75d-0d04-0410-961f-82ee72b054a4>2015-06-04 08:17:45 +0000
committermpolacek <mpolacek@138bc75d-0d04-0410-961f-82ee72b054a4>2015-06-04 08:17:45 +0000
commitb44134dc0fa10f4ba19a39ed2204b1c306c71479 (patch)
tree0ae98c0e9dd440292c437f415548e76661933de5
parent3549fcc169699e2eff54132ce56eede80d8c0130 (diff)
downloadgcc-b44134dc0fa10f4ba19a39ed2204b1c306c71479.tar.gz
PR c/66341
* c-typeck.c (build_c_cast): Wrap VALUE into NON_LVALUE_EXPR if it is a lvalue. * gcc.dg/lvalue-8.c: New test. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@224115 138bc75d-0d04-0410-961f-82ee72b054a4
-rw-r--r--gcc/c/ChangeLog6
-rw-r--r--gcc/c/c-typeck.c2
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/gcc.dg/lvalue-8.c19
4 files changed, 31 insertions, 1 deletions
diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog
index 69344bb7bb1..d6be87f0742 100644
--- a/gcc/c/ChangeLog
+++ b/gcc/c/ChangeLog
@@ -1,3 +1,9 @@
+2015-06-04 Marek Polacek <polacek@redhat.com>
+
+ PR c/66341
+ * c-typeck.c (build_c_cast): Wrap VALUE into NON_LVALUE_EXPR if
+ it is a lvalue.
+
2015-06-03 Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
* c-decl.c (warn_cxx_compat_finish_struct): New parameters code, record_loc.
diff --git a/gcc/c/c-typeck.c b/gcc/c/c-typeck.c
index f55d4c60bfc..6b313f30b08 100644
--- a/gcc/c/c-typeck.c
+++ b/gcc/c/c-typeck.c
@@ -5195,7 +5195,7 @@ build_c_cast (location_t loc, tree type, tree expr)
}
/* Don't let a cast be an lvalue. */
- if (value == expr)
+ if (lvalue_p (value))
value = non_lvalue_loc (loc, value);
/* Don't allow the results of casting to floating-point or complex
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index a74be77df88..3092acf1fa6 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2015-06-04 Marek Polacek <polacek@redhat.com>
+
+ PR c/66341
+ * gcc.dg/lvalue-8.c: New test.
+
2015-06-03 Manuel López-Ibáñez <manu@gcc.gnu.org>
Paolo Carlini <paolo.carlini@oracle.com>
diff --git a/gcc/testsuite/gcc.dg/lvalue-8.c b/gcc/testsuite/gcc.dg/lvalue-8.c
new file mode 100644
index 00000000000..04eeb71b6bc
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/lvalue-8.c
@@ -0,0 +1,19 @@
+/* PR c/66341 */
+/* { dg-do compile } */
+
+void
+foo (int *p)
+{
+ p = 0;
+ /* A cast does not yield an lvalue. */
+ (int *) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
+ /* A cast to a qualified type has the same effect as a cast
+ to the unqualified version of the type. */
+ (int *const) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
+ (int *) (char *) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
+ (int *) (char *) (int *) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
+ (int *) (char *) (int *) (char *) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
+ (int *) (double *) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
+ (int *) (int *) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
+ (int *) (int *const) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
+}