summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormpolacek <mpolacek@138bc75d-0d04-0410-961f-82ee72b054a4>2016-05-02 11:35:59 +0000
committermpolacek <mpolacek@138bc75d-0d04-0410-961f-82ee72b054a4>2016-05-02 11:35:59 +0000
commitdd185f6e02bf83831acabeee8e2f390244f28f26 (patch)
tree35a0e8abb5a8e8d2be7b121522b7e42d4882c44f
parent7581b509f945e176f5d255d2c8bd17c017024450 (diff)
downloadgcc-dd185f6e02bf83831acabeee8e2f390244f28f26.tar.gz
PR c/70851
* c-decl.c (grokdeclarator): Diagnose when array's size has an incomplete type. * gcc.dg/enum-incomplete-3.c: New test. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@235750 138bc75d-0d04-0410-961f-82ee72b054a4
-rw-r--r--gcc/c/ChangeLog6
-rw-r--r--gcc/c/c-decl.c15
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/gcc.dg/enum-incomplete-3.c20
4 files changed, 44 insertions, 2 deletions
diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog
index f02fbdb3399..793186bfb63 100644
--- a/gcc/c/ChangeLog
+++ b/gcc/c/ChangeLog
@@ -1,3 +1,9 @@
+2016-05-02 Marek Polacek <polacek@redhat.com>
+
+ PR c/70851
+ * c-decl.c (grokdeclarator): Diagnose when array's size has an
+ incomplete type.
+
2016-04-29 Cesar Philippidis <cesar@codesourcery.com>
PR middle-end/70626
diff --git a/gcc/c/c-decl.c b/gcc/c/c-decl.c
index 16e4250194a..7094efc5dfe 100644
--- a/gcc/c/c-decl.c
+++ b/gcc/c/c-decl.c
@@ -5799,10 +5799,21 @@ grokdeclarator (const struct c_declarator *declarator,
{
if (name)
error_at (loc, "size of array %qE has non-integer type",
- name);
+ name);
else
error_at (loc,
- "size of unnamed array has non-integer type");
+ "size of unnamed array has non-integer type");
+ size = integer_one_node;
+ }
+ /* This can happen with enum forward declaration. */
+ else if (!COMPLETE_TYPE_P (TREE_TYPE (size)))
+ {
+ if (name)
+ error_at (loc, "size of array %qE has incomplete type",
+ name);
+ else
+ error_at (loc, "size of unnamed array has incomplete "
+ "type");
size = integer_one_node;
}
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index c4f45fa8b6c..3d6051cf884 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,4 +1,9 @@
2016-05-02 Marek Polacek <polacek@redhat.com>
+
+ PR c/70851
+ * gcc.dg/enum-incomplete-3.c: New test.
+
+2016-05-02 Marek Polacek <polacek@redhat.com>
Tom de Vries <tom@codesourcery.com>
PR tree-optimization/70700
diff --git a/gcc/testsuite/gcc.dg/enum-incomplete-3.c b/gcc/testsuite/gcc.dg/enum-incomplete-3.c
new file mode 100644
index 00000000000..db1138b56c6
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/enum-incomplete-3.c
@@ -0,0 +1,20 @@
+/* PR c/70851 */
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+enum E e; /* { dg-error "storage size" } */
+
+void bar (int [e]); /* { dg-error "size of unnamed array has incomplete type" } */
+void bar2 (int [][e]); /* { dg-error "size of unnamed array has incomplete type" } */
+
+void
+foo (void)
+{
+ int a1[e]; /* { dg-error "size of array .a1. has incomplete type" } */
+ int a2[e][3]; /* { dg-error "size of array .a2. has incomplete type" } */
+
+ struct S
+ {
+ int a3[e]; /* { dg-error "size of array .a3. has incomplete type" } */
+ };
+}