summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrth <rth@138bc75d-0d04-0410-961f-82ee72b054a4>2001-12-31 04:19:35 +0000
committerrth <rth@138bc75d-0d04-0410-961f-82ee72b054a4>2001-12-31 04:19:35 +0000
commit78587df36f227e25a0b6f6b3fd6aa8577bf9493a (patch)
treeeda556eeb126b284e63a737eeba7cb809f6af60e
parent8fe3e36c21771828c7a7b30cae017e32794b291d (diff)
downloadgcc-78587df36f227e25a0b6f6b3fd6aa8577bf9493a.tar.gz
* cfglayout.c (scope_def, scope_forest_info, forest,
relate_bbs_with_scopes, make_new_scope, build_scope_forest, remove_scope_notes, insert_intra_before_1, insert_intra_1, insert_intra_bb_scope_notes, insert_inter_bb_scope_notes, rebuild_scope_notes, free_scope_forest_1, dump_scope_forest, dump_scope_forest_1, get_next_bb_note, get_prev_bb_note): Remove. (fixup_reorder_chain): Don't set scope for bb. (insn_scopes, scope_to_insns_initialize, set_block_levels, change_scope, scope_to_insns_finalize): New. (cfg_layout_initialize, cfg_layout_finalize): Update to match. * cfglayout.h (scope_def, scope): Remove. (reorder_block_def): Remove scope member. (scope_to_insns_initialize, scope_to_insns_finalize): Declare. * haifa-sched.c: Revert reemit_other_notes change. * sched-ebb.c (schedule_ebbs): Don't call remove_unnecessary_notes. Use scope_to_insns_initialize and scope_to_insns_finalize. * sched-rgn.c (schedule_insns): Likewise. * gcc.dg/debug-6.c: New. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@48412 138bc75d-0d04-0410-961f-82ee72b054a4
-rw-r--r--gcc/ChangeLog22
-rw-r--r--gcc/cfglayout.c720
-rw-r--r--gcc/cfglayout.h7
-rw-r--r--gcc/haifa-sched.c74
-rw-r--r--gcc/sched-ebb.c7
-rw-r--r--gcc/sched-rgn.c7
-rw-r--r--gcc/testsuite/ChangeLog4
-rw-r--r--gcc/testsuite/gcc.dg/debug-6.c38
8 files changed, 189 insertions, 690 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index f33e9c01a41..45d5f2dd090 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,25 @@
+2001-12-30 Richard Henderson <rth@redhat.com>
+
+ * cfglayout.c (scope_def, scope_forest_info, forest,
+ relate_bbs_with_scopes, make_new_scope, build_scope_forest,
+ remove_scope_notes, insert_intra_before_1, insert_intra_1,
+ insert_intra_bb_scope_notes, insert_inter_bb_scope_notes,
+ rebuild_scope_notes, free_scope_forest_1, dump_scope_forest,
+ dump_scope_forest_1, get_next_bb_note, get_prev_bb_note): Remove.
+ (fixup_reorder_chain): Don't set scope for bb.
+ (insn_scopes, scope_to_insns_initialize, set_block_levels,
+ change_scope, scope_to_insns_finalize): New.
+ (cfg_layout_initialize, cfg_layout_finalize): Update to match.
+ * cfglayout.h (scope_def, scope): Remove.
+ (reorder_block_def): Remove scope member.
+ (scope_to_insns_initialize, scope_to_insns_finalize): Declare.
+ * haifa-sched.c: Revert reemit_other_notes change.
+ * sched-ebb.c (schedule_ebbs): Don't call remove_unnecessary_notes.
+ Use scope_to_insns_initialize and scope_to_insns_finalize.
+ * sched-rgn.c (schedule_insns): Likewise.
+
+2001-12-31 Graham Stott <grahams@redhat.com>
+
2001-12-31 Graham Stott <grahams@redhat.com>
* c-lex.c: Include tree.h before expr.h
diff --git a/gcc/cfglayout.c b/gcc/cfglayout.c
index 8ddce1479a3..ef5206bb69a 100644
--- a/gcc/cfglayout.c
+++ b/gcc/cfglayout.c
@@ -20,6 +20,7 @@ Software Foundation, 59 Temple Place - Suite 330, Boston, MA
#include "config.h"
#include "system.h"
+#include "tree.h"
#include "rtl.h"
#include "hard-reg-set.h"
#include "basic-block.h"
@@ -31,85 +32,24 @@ Software Foundation, 59 Temple Place - Suite 330, Boston, MA
/* The contents of the current function definition are allocated
in this obstack, and all are freed at the end of the function. */
-
extern struct obstack flow_obstack;
-/* Structure to hold information about lexical scopes. */
-struct scope_def
-{
- int level;
-
- /* The NOTE_INSN_BLOCK_BEG that started this scope. */
- rtx note_beg;
-
- /* The NOTE_INSN_BLOCK_END that ended this scope. */
- rtx note_end;
-
- /* The bb containing note_beg (if any). */
- basic_block bb_beg;
-
- /* The bb containing note_end (if any). */
- basic_block bb_end;
-
- /* List of basic blocks contained within this scope. */
- basic_block *bbs;
-
- /* Number of blocks contained within this scope. */
- int num_bbs;
-
- /* The outer scope or NULL if outermost scope. */
- struct scope_def *outer;
-
- /* The first inner scope or NULL if innermost scope. */
- struct scope_def *inner;
-
- /* The last inner scope or NULL if innermost scope. */
- struct scope_def *inner_last;
-
- /* Link to the next (sibling) scope. */
- struct scope_def *next;
-};
-
-/* Structure to hold information about the scope forest. */
-typedef struct
-{
- /* Number of trees in forest. */
- int num_trees;
-
- /* List of tree roots. */
- scope *trees;
-} scope_forest_info;
-
/* Holds the interesting trailing notes for the function. */
static rtx function_tail_eff_head;
-/* The scope forest of current function. */
-static scope_forest_info forest;
-
static rtx skip_insns_after_block PARAMS ((basic_block));
static void record_effective_endpoints PARAMS ((void));
static rtx label_for_bb PARAMS ((basic_block));
static void fixup_reorder_chain PARAMS ((void));
-static void relate_bbs_with_scopes PARAMS ((scope));
-static scope make_new_scope PARAMS ((int, rtx));
-static void build_scope_forest PARAMS ((scope_forest_info *));
-static void remove_scope_notes PARAMS ((void));
-static void insert_intra_before_1 PARAMS ((scope, rtx *, basic_block));
-static void insert_intra_1 PARAMS ((scope, rtx *, basic_block));
-static void insert_intra_bb_scope_notes PARAMS ((basic_block));
-static void insert_inter_bb_scope_notes PARAMS ((basic_block, basic_block));
-static void rebuild_scope_notes PARAMS ((scope_forest_info *));
-static void free_scope_forest_1 PARAMS ((scope));
-static void free_scope_forest PARAMS ((scope_forest_info *));
-void dump_scope_forest PARAMS ((scope_forest_info *));
-static void dump_scope_forest_1 PARAMS ((scope, int));
-
-static rtx get_next_bb_note PARAMS ((rtx));
-static rtx get_prev_bb_note PARAMS ((rtx));
+static void set_block_levels PARAMS ((tree, int));
+static void change_scope PARAMS ((rtx, tree, tree));
void verify_insn_chain PARAMS ((void));
static void fixup_fallthru_exit_predecessor PARAMS ((void));
+
+/* Map insn uid to lexical block. */
+static varray_type insn_scopes;
/* Skip over inter-block insns occurring after BB which are typically
associated with BB (e.g., barriers). If there are any such insns,
@@ -245,608 +185,144 @@ record_effective_endpoints ()
function_tail_eff_head = next_insn;
}
-/* Return the next NOTE_INSN_BASIC_BLOCK after X. */
-
-static rtx
-get_next_bb_note (x)
- rtx x;
-{
- for (; x; x = NEXT_INSN (x))
- if (NOTE_INSN_BASIC_BLOCK_P (x))
- return x;
-
- return NULL;
-}
-
-/* Return the fist NOTE_INSN_BASIC_BLOCK before X. */
-
-static rtx
-get_prev_bb_note (x)
- rtx x;
-{
- for (; x; x = PREV_INSN (x))
- if (NOTE_INSN_BASIC_BLOCK_P (x))
- return x;
+/* Build a varray mapping INSN_UID to lexical block. Return it. */
- return NULL;
-}
-
-/* Determine and record the relationships between basic blocks and
- scopes in scope tree S. */
-
-static void
-relate_bbs_with_scopes (s)
- scope s;
-{
- scope p;
- int i, bbi1, bbi2, bbs_spanned;
- rtx bbnote;
-
- for (p = s->inner; p; p = p->next)
- relate_bbs_with_scopes (p);
-
- bbi1 = bbi2 = -1;
- bbs_spanned = 0;
-
- /* If the begin and end notes are both inside the same basic block,
- or if they are both outside of basic blocks, then we know immediately
- how they are related. Otherwise, we need to poke around to make the
- determination. */
- if (s->bb_beg != s->bb_end)
- {
- if (s->bb_beg && s->bb_end)
- {
- /* Both notes are in different bbs. This implies that all the
- basic blocks spanned by the pair of notes are contained in
- this scope. */
- bbi1 = s->bb_beg->index;
- bbi2 = s->bb_end->index;
- bbs_spanned = 1;
- }
- else if (! s->bb_beg)
- {
- /* First note is outside of a bb. If the scope spans more than
- one basic block, then they all are contained within this
- scope. Otherwise, this scope is contained within the basic
- block. */
- bbnote = get_next_bb_note (s->note_beg);
- if (! bbnote)
- abort ();
-
- if (NOTE_BASIC_BLOCK (bbnote) == s->bb_end)
- {
- bbs_spanned = 0;
- s->bb_beg = NOTE_BASIC_BLOCK (bbnote);
- }
- else
- {
- bbi1 = NOTE_BASIC_BLOCK (bbnote)->index;
- bbi2 = s->bb_end->index;
- s->bb_end = NULL;
- bbs_spanned = 1;
- }
- }
- else /* ! s->bb_end */
- {
- /* Second note is outside of a bb. If the scope spans more than
- one basic block, then they all are contained within this
- scope. Otherwise, this scope is contained within the basic
- block. */
- bbnote = get_prev_bb_note (s->note_end);
- if (! bbnote)
- abort ();
-
- if (NOTE_BASIC_BLOCK (bbnote) == s->bb_beg)
- {
- bbs_spanned = 0;
- s->bb_end = NOTE_BASIC_BLOCK (bbnote);
- }
- else
- {
- bbi1 = s->bb_beg->index;
- bbi2 = NOTE_BASIC_BLOCK (bbnote)->index;
- s->bb_beg = NULL;
- bbs_spanned = 1;
- }
- }
- }
- else
- {
- if (s->bb_beg)
- /* Both notes are in the same bb, which implies the block
- contains this scope. */
- bbs_spanned = 0;
- else
- {
- /* Both notes are outside of any bbs. This implies that all the
- basic blocks spanned by the pair of notes are contained in
- this scope.
- There is a degenerate case to consider. If the notes do not
- span any basic blocks, then it is an empty scope that can
- safely be deleted or ignored. Mark these with level = -1. */
- rtx x1 = get_next_bb_note (s->note_beg);
- rtx x2 = get_prev_bb_note (s->note_end);
-
- if (! (x1 && x2))
- {
- s->level = -1;
- bbs_spanned = 0;
- }
- else
- {
- bbi1 = NOTE_BASIC_BLOCK (x1)->index;
- bbi2 = NOTE_BASIC_BLOCK (x2)->index;
- bbs_spanned = 1;
- }
- }
- }
-
- /* If the scope spans one or more basic blocks, we record them. We
- only record the bbs that are immediately contained within this
- scope. Note that if a scope is contained within a bb, we can tell
- by checking that bb_beg = bb_end and that they are non-null. */
- if (bbs_spanned)
- {
- int j = 0;
-
- s->num_bbs = 0;
- for (i = bbi1; i <= bbi2; i++)
- if (! RBI (BASIC_BLOCK (i))->scope)
- s->num_bbs++;
-
- s->bbs = xmalloc (s->num_bbs * sizeof (basic_block));
- for (i = bbi1; i <= bbi2; i++)
- {
- basic_block curr_bb = BASIC_BLOCK (i);
- if (! RBI (curr_bb)->scope)
- {
- s->bbs[j++] = curr_bb;
- RBI (curr_bb)->scope = s;
- }
- }
- }
- else
- s->num_bbs = 0;
-}
-
-/* Allocate and initialize a new scope structure with scope level LEVEL,
- and record the NOTE beginning the scope. */
-
-static scope
-make_new_scope (level, note)
- int level;
- rtx note;
-{
- scope new_scope = xcalloc (1, sizeof (struct scope_def));
-
- new_scope->level = level;
- new_scope->note_beg = note;
- return new_scope;
-}
-
-
-/* Build a forest representing the scope structure of the function.
- Return a pointer to a structure describing the forest. */
-
-static void
-build_scope_forest (forest)
- scope_forest_info *forest;
+void
+scope_to_insns_initialize ()
{
- rtx x;
- int level, bbi, i;
- basic_block curr_bb;
- scope root, curr_scope = 0;
-
- forest->num_trees = 0;
- forest->trees = NULL;
- level = -1;
- root = NULL;
- curr_bb = NULL;
- bbi = 0;
-
- for (x = get_insns (); x; x = NEXT_INSN (x))
- {
- if (bbi < n_basic_blocks && x == BASIC_BLOCK (bbi)->head)
- curr_bb = BASIC_BLOCK (bbi);
-
- if (GET_CODE (x) == NOTE)
- {
- if (NOTE_LINE_NUMBER (x) == NOTE_INSN_BLOCK_BEG)
- {
- if (root)
- {
- scope new_scope;
-
- if (! curr_scope)
- abort();
-
- level++;
- new_scope = make_new_scope (level, x);
- new_scope->outer = curr_scope;
- new_scope->next = NULL;
- if (! curr_scope->inner)
- {
- curr_scope->inner = new_scope;
- curr_scope->inner_last = new_scope;
- }
- else
- {
- curr_scope->inner_last->next = new_scope;
- curr_scope->inner_last = new_scope;
- }
- curr_scope = curr_scope->inner_last;
-
- }
- else
- {
- int ntrees = forest->num_trees;
-
- level++;
- curr_scope = make_new_scope (level, x);
- root = curr_scope;
- forest->trees = xrealloc (forest->trees,
- sizeof (scope) * (ntrees + 1));
- forest->trees[forest->num_trees++] = root;
- }
-
- curr_scope->bb_beg = curr_bb;
- }
- else if (NOTE_LINE_NUMBER (x) == NOTE_INSN_BLOCK_END)
- {
- curr_scope->bb_end = curr_bb;
- curr_scope->note_end = x;
- level--;
- curr_scope = curr_scope->outer;
- if (level == -1)
- root = NULL;
- }
- }
-
- if (curr_bb && curr_bb->end == x)
- {
- curr_bb = NULL;
- bbi++;
- }
- }
-
- for (i = 0; i < forest->num_trees; i++)
- relate_bbs_with_scopes (forest->trees[i]);
-}
-
-/* Remove all NOTE_INSN_BLOCK_BEG and NOTE_INSN_BLOCK_END notes from the insn
- chain. */
+ tree block = NULL;
+ rtx insn, next;
-static void
-remove_scope_notes ()
-{
- rtx x, next;
- basic_block currbb = NULL;
+ VARRAY_TREE_INIT (insn_scopes, get_max_uid (), "insn scopes");
- for (x = get_insns (); x; x = next)
+ for (insn = get_insns (); insn; insn = next)
{
- next = NEXT_INSN (x);
- if (NOTE_INSN_BASIC_BLOCK_P (x))
- currbb = NOTE_BASIC_BLOCK (x);
+ next = NEXT_INSN (insn);
- if (GET_CODE (x) == NOTE
- && (NOTE_LINE_NUMBER (x) == NOTE_INSN_BLOCK_BEG
- || NOTE_LINE_NUMBER (x) == NOTE_INSN_BLOCK_END))
+ if (active_insn_p (insn)
+ && GET_CODE (PATTERN (insn)) != ADDR_VEC
+ && GET_CODE (PATTERN (insn)) != ADDR_DIFF_VEC)
+ VARRAY_TREE (insn_scopes, INSN_UID (insn)) = block;
+ else if (GET_CODE (insn) == NOTE)
{
- /* Check if the scope note happens to be the end of a bb. */
- if (currbb && x == currbb->end)
- currbb->end = PREV_INSN (x);
- if (currbb && x == currbb->head)
- abort ();
-
- if (PREV_INSN (x))
+ switch (NOTE_LINE_NUMBER (insn))
{
- NEXT_INSN (PREV_INSN (x)) = next;
- if (next)
- PREV_INSN (next) = PREV_INSN (x);
-
- NEXT_INSN (x) = NULL;
- PREV_INSN (x) = NULL;
+ case NOTE_INSN_BLOCK_BEG:
+ block = NOTE_BLOCK (insn);
+ delete_insn (insn);
+ break;
+ case NOTE_INSN_BLOCK_END:
+ block = BLOCK_SUPERCONTEXT (block);
+ delete_insn (insn);
+ break;
+ default:
+ break;
}
- else
- abort ();
}
}
}
-
-/* Insert scope note pairs for a contained scope tree S after insn IP. */
-static void
-insert_intra_1 (s, ip, bb)
- scope s;
- rtx *ip;
- basic_block bb;
-{
- scope p;
-
- if (NOTE_BLOCK (s->note_beg))
- {
- *ip = emit_note_after (NOTE_INSN_BLOCK_BEG, *ip);
- NOTE_BLOCK (*ip) = NOTE_BLOCK (s->note_beg);
- }
-
- for (p = s->inner; p; p = p->next)
- insert_intra_1 (p, ip, bb);
-
- if (NOTE_BLOCK (s->note_beg))
- {
- *ip = emit_note_after (NOTE_INSN_BLOCK_END, *ip);
- NOTE_BLOCK (*ip) = NOTE_BLOCK (s->note_end);
- }
-}
-
-/* Insert scope note pairs for a contained scope tree S before insn IP. */
+/* For each lexical block, set BLOCK_NUMBER to the depth at which it is
+ found in the block tree. */
static void
-insert_intra_before_1 (s, ip, bb)
- scope s;
- rtx *ip;
- basic_block bb;
-{
- scope p;
-
- if (NOTE_BLOCK (s->note_beg))
- {
- *ip = emit_note_before (NOTE_INSN_BLOCK_END, *ip);
- NOTE_BLOCK (*ip) = NOTE_BLOCK (s->note_end);
- }
-
- for (p = s->inner; p; p = p->next)
- insert_intra_before_1 (p, ip, bb);
-
- if (NOTE_BLOCK (s->note_beg))
- {
- *ip = emit_note_before (NOTE_INSN_BLOCK_BEG, *ip);
- NOTE_BLOCK (*ip) = NOTE_BLOCK (s->note_beg);
- }
-}
-
-/* Insert NOTE_INSN_BLOCK_END notes and NOTE_INSN_BLOCK_BEG notes for
- scopes that are contained within BB. */
-
-static void
-insert_intra_bb_scope_notes (bb)
- basic_block bb;
+set_block_levels (block, level)
+ tree block;
+ int level;
{
- scope s = RBI (bb)->scope;
- scope p;
- rtx ip;
-
- if (! s)
- return;
-
- ip = bb->head;
- if (GET_CODE (ip) == CODE_LABEL)
- ip = NEXT_INSN (ip);
-
- for (p = s->inner; p; p = p->next)
+ while (block)
{
- if (p->bb_beg != NULL && p->bb_beg == p->bb_end && p->bb_beg == bb)
- insert_intra_1 (p, &ip, bb);
+ BLOCK_NUMBER (block) = level;
+ set_block_levels (BLOCK_SUBBLOCKS (block), level + 1);
+ block = BLOCK_CHAIN (block);
}
}
-/* Given two consecutive basic blocks BB1 and BB2 with different scopes,
- insert NOTE_INSN_BLOCK_END notes after BB1 and NOTE_INSN_BLOCK_BEG
- notes before BB2 such that the notes are correctly balanced. If BB1 or
- BB2 is NULL, we are inserting scope notes for the first and last basic
- blocks, respectively. */
+/* Emit lexical block notes needed to change scope from S1 to S2. */
static void
-insert_inter_bb_scope_notes (bb1, bb2)
- basic_block bb1;
- basic_block bb2;
+change_scope (orig_insn, s1, s2)
+ rtx orig_insn;
+ tree s1, s2;
{
- rtx ip;
- scope com;
-
- /* It is possible that a basic block is not contained in any scope.
- In that case, we either open or close a scope but not both. */
- if (bb1 && bb2)
- {
- scope s1 = RBI (bb1)->scope;
- scope s2 = RBI (bb2)->scope;
+ rtx insn = orig_insn;
+ tree com = NULL_TREE;
+ tree ts1 = s1, ts2 = s2;
+ tree s;
- if (! s1 && ! s2)
- return;
-
- if (! s1)
- bb1 = NULL;
- else if (! s2)
- bb2 = NULL;
- }
-
- /* Find common ancestor scope. */
- if (bb1 && bb2)
+ while (ts1 != ts2)
{
- scope s1 = RBI (bb1)->scope;
- scope s2 = RBI (bb2)->scope;
-
- while (s1 != s2)
+ if (ts1 == NULL || ts2 == NULL)
+ abort ();
+ if (BLOCK_NUMBER (ts1) > BLOCK_NUMBER (ts2))
+ ts1 = BLOCK_SUPERCONTEXT (ts1);
+ else if (BLOCK_NUMBER (ts1) < BLOCK_NUMBER (ts2))
+ ts2 = BLOCK_SUPERCONTEXT (ts2);
+ else
{
- if (s1->level > s2->level)
- s1 = s1->outer;
- else if (s2->level > s1->level)
- s2 = s2->outer;
- else
- {
- s1 = s1->outer;
- s2 = s2->outer;
- }
+ ts1 = BLOCK_SUPERCONTEXT (ts1);
+ ts2 = BLOCK_SUPERCONTEXT (ts2);
}
-
- com = s1;
}
- else
- com = NULL;
+ com = ts1;
/* Close scopes. */
- if (bb1)
+ s = s1;
+ while (s != com)
{
- rtx end = bb1->end;
- scope s, p;
-
- ip = RBI (bb1)->eff_end;
- for (s = RBI (bb1)->scope; s != com; s = s->outer)
- {
- if (NOTE_BLOCK (s->note_beg))
- {
- ip = emit_note_after (NOTE_INSN_BLOCK_END, ip);
- NOTE_BLOCK (ip) = NOTE_BLOCK (s->note_end);
- }
-
- /* Now emit all sibling scopes which don't span any basic
- blocks. */
- if (s->outer)
- for (p = s->outer->inner; p; p = p->next)
- if (p != s && p->bb_beg == bb1 && p->bb_beg == p->bb_end)
- insert_intra_1 (p, &ip, bb1);
- }
-
- /* Emitting note may move the end of basic block to unwanted place. */
- bb1->end = end;
+ rtx note = emit_note_before (NOTE_INSN_BLOCK_END, insn);
+ NOTE_BLOCK (note) = s;
+ s = BLOCK_SUPERCONTEXT (s);
}
/* Open scopes. */
- if (bb2)
+ s = s2;
+ while (s != com)
{
- scope s, p;
-
- ip = bb2->head;
- for (s = RBI (bb2)->scope; s != com; s = s->outer)
- {
- if (NOTE_BLOCK (s->note_beg))
- {
- ip = emit_note_before (NOTE_INSN_BLOCK_BEG, ip);
- NOTE_BLOCK (ip) = NOTE_BLOCK (s->note_beg);
- }
-
- /* Now emit all sibling scopes which don't span any basic
- blocks. */
- if (s->outer)
- for (p = s->outer->inner; p; p = p->next)
- if (p != s && p->bb_beg == bb2 && p->bb_beg == p->bb_end)
- insert_intra_before_1 (p, &ip, bb2);
- }
+ insn = emit_note_before (NOTE_INSN_BLOCK_BEG, insn);
+ NOTE_BLOCK (insn) = s;
+ s = BLOCK_SUPERCONTEXT (s);
}
}
-
/* Rebuild all the NOTE_INSN_BLOCK_BEG and NOTE_INSN_BLOCK_END notes based
- on the scope forest and the newly reordered basic blocks. */
-
-static void
-rebuild_scope_notes (forest)
- scope_forest_info *forest;
-{
- int i;
-
- if (forest->num_trees == 0)
- return;
-
- /* Start by opening the scopes before the first basic block. */
- insert_inter_bb_scope_notes (NULL, BASIC_BLOCK (0));
-
- /* Then, open and close scopes as needed between blocks. */
- for (i = 0; i < n_basic_blocks - 1; i++)
- {
- basic_block bb1 = BASIC_BLOCK (i);
- basic_block bb2 = BASIC_BLOCK (i + 1);
-
- if (RBI (bb1)->scope != RBI (bb2)->scope)
- insert_inter_bb_scope_notes (bb1, bb2);
- insert_intra_bb_scope_notes (bb1);
- }
-
- /* Finally, close the scopes after the last basic block. */
- insert_inter_bb_scope_notes (BASIC_BLOCK (n_basic_blocks - 1), NULL);
- insert_intra_bb_scope_notes (BASIC_BLOCK (n_basic_blocks - 1));
-}
-
-/* Free the storage associated with the scope tree at S. */
-
-static void
-free_scope_forest_1 (s)
- scope s;
-{
- scope p, next;
-
- for (p = s->inner; p; p = next)
- {
- next = p->next;
- free_scope_forest_1 (p);
- }
-
- if (s->bbs)
- free (s->bbs);
- free (s);
-}
-
-/* Free the storage associated with the scope forest. */
-
-static void
-free_scope_forest (forest)
- scope_forest_info *forest;
-{
- int i;
-
- for (i = 0; i < forest->num_trees; i++)
- free_scope_forest_1 (forest->trees[i]);
-}
-
-/* Visualize the scope forest. */
+ on the scope tree and the newly reordered instructions. */
void
-dump_scope_forest (forest)
- scope_forest_info *forest;
+scope_to_insns_finalize ()
{
- int i;
-
- if (forest->num_trees == 0)
- fprintf (stderr, "\n< Empty scope forest >\n");
- else
- fprintf (stderr, "\n< Scope forest >\n");
+ tree cur_block = DECL_INITIAL (cfun->decl);
+ rtx insn, note;
- for (i = 0; i < forest->num_trees; i++)
- dump_scope_forest_1 (forest->trees[i], 0);
-}
+ /* Tag the blocks with a depth number so that change_scope can find
+ the common parent easily. */
+ set_block_levels (cur_block, 0);
-/* Recursive portion of dump_scope_forest. */
+ for (insn = get_insns (); insn; insn = NEXT_INSN (insn))
+ {
+ tree this_block;
-static void
-dump_scope_forest_1 (s, indent)
- scope s;
- int indent;
-{
- scope p;
- int i;
+ if ((size_t) INSN_UID (insn) >= insn_scopes->num_elements)
+ continue;
+ this_block = VARRAY_TREE (insn_scopes, INSN_UID (insn));
+ if (! this_block)
+ continue;
- if (s->bb_beg != NULL && s->bb_beg == s->bb_end
- && RBI (s->bb_beg)->scope
- && RBI (s->bb_beg)->scope->level + 1 == s->level)
- {
- fprintf (stderr, "%*s", indent, "");
- fprintf (stderr, "BB%d:\n", s->bb_beg->index);
+ if (this_block != cur_block)
+ {
+ change_scope (insn, cur_block, this_block);
+ cur_block = this_block;
+ }
}
- fprintf (stderr, "%*s", indent, "");
- fprintf (stderr, "{ level %d (block %p)\n", s->level,
- (PTR) NOTE_BLOCK (s->note_beg));
+ VARRAY_FREE (insn_scopes);
- fprintf (stderr, "%*s%s", indent, "", "bbs:");
- for (i = 0; i < s->num_bbs; i++)
- fprintf (stderr, " %d", s->bbs[i]->index);
- fprintf (stderr, "\n");
-
- for (p = s->inner; p; p = p->next)
- dump_scope_forest_1 (p, indent + 2);
+ /* change_scope emits before the insn, not after. */
+ note = emit_note (NULL, NOTE_INSN_DELETED);
+ change_scope (note, cur_block, DECL_INITIAL (cfun->decl));
+ delete_insn (note);
- fprintf (stderr, "%*s", indent, "");
- fprintf (stderr, "}\n");
+ reorder_blocks ();
}
/* Given a reorder chain, rearrange the code to match. */
@@ -994,7 +470,6 @@ fixup_reorder_chain ()
alloc_aux_for_block (nb, sizeof (struct reorder_block_def));
RBI (nb)->eff_head = nb->head;
RBI (nb)->eff_end = NEXT_INSN (nb->end);
- RBI (nb)->scope = RBI (bb)->scope;
RBI (nb)->visited = 1;
RBI (nb)->next = RBI (bb)->next;
RBI (bb)->next = nb;
@@ -1091,8 +566,7 @@ cfg_layout_initialize ()
{
alloc_aux_for_blocks (sizeof (struct reorder_block_def));
- build_scope_forest (&forest);
- remove_scope_notes ();
+ scope_to_insns_initialize ();
record_effective_endpoints ();
}
@@ -1110,9 +584,7 @@ cfg_layout_finalize ()
verify_insn_chain ();
#endif
- rebuild_scope_notes (&forest);
- free_scope_forest (&forest);
- reorder_blocks ();
+ scope_to_insns_finalize ();
free_aux_for_blocks ();
diff --git a/gcc/cfglayout.h b/gcc/cfglayout.h
index 3c59e42ffd6..3b12e505f65 100644
--- a/gcc/cfglayout.h
+++ b/gcc/cfglayout.h
@@ -18,15 +18,11 @@
Software Foundation, 59 Temple Place - Suite 330, Boston, MA
02111-1307, USA. */
-struct scope_def;
-typedef struct scope_def *scope;
-
/* Structure to hold information about the blocks during reordering. */
typedef struct reorder_block_def
{
rtx eff_head;
rtx eff_end;
- scope scope;
basic_block next;
int visited;
} *reorder_block_def;
@@ -35,3 +31,6 @@ typedef struct reorder_block_def
extern void cfg_layout_initialize PARAMS ((void));
extern void cfg_layout_finalize PARAMS ((void));
+
+extern void scope_to_insns_initialize PARAMS ((void));
+extern void scope_to_insns_finalize PARAMS ((void));
diff --git a/gcc/haifa-sched.c b/gcc/haifa-sched.c
index ca6cfbb1d4f..7b9a2e82126 100644
--- a/gcc/haifa-sched.c
+++ b/gcc/haifa-sched.c
@@ -319,7 +319,6 @@ static void adjust_priority PARAMS ((rtx));
static rtx unlink_other_notes PARAMS ((rtx, rtx));
static rtx unlink_line_notes PARAMS ((rtx, rtx));
static rtx reemit_notes PARAMS ((rtx, rtx));
-static rtx reemit_other_notes PARAMS ((rtx, rtx));
static rtx *ready_lastpos PARAMS ((struct ready_list *));
static void ready_sort PARAMS ((struct ready_list *));
@@ -1576,60 +1575,6 @@ reemit_notes (insn, last)
return retval;
}
-
-/* NOTE_LIST is the end of a chain of notes previously found among the
- insns. Insert them at the beginning of the insns. Actually, insert
- NOTE_INSN_BLOCK_END notes at the end of the insns. Doing otherwise
- tends to collapse lexical blocks into empty regions, which is somewhat
- less than useful. */
-/* ??? Ideally we'd mark each insn with the block it originated from,
- and preserve that information. This requires some moderately
- sophisticated block reconstruction code, since block nestings must
- be preserved. */
-
-static rtx
-reemit_other_notes (head, tail)
- rtx head, tail;
-{
- bool saw_block_beg = false;
-
- while (note_list)
- {
- rtx note_tail = note_list;
- note_list = PREV_INSN (note_tail);
-
- if (NOTE_LINE_NUMBER (note_tail) == NOTE_INSN_BLOCK_END
- /* We can only extend the lexical block while we havn't
- seen a BLOCK_BEG note. Otherwise we risk mis-nesting
- the notes. */
- && ! saw_block_beg)
- {
- rtx insert_after = tail;
- if (GET_CODE (NEXT_INSN (tail)) == BARRIER)
- insert_after = NEXT_INSN (tail);
-
- PREV_INSN (note_tail) = insert_after;
- NEXT_INSN (note_tail) = NEXT_INSN (insert_after);
- if (NEXT_INSN (insert_after))
- PREV_INSN (NEXT_INSN (insert_after)) = note_tail;
- NEXT_INSN (insert_after) = note_tail;
- }
- else
- {
- if (NOTE_LINE_NUMBER (note_tail) == NOTE_INSN_BLOCK_BEG)
- saw_block_beg = true;
-
- PREV_INSN (note_tail) = PREV_INSN (head);
- NEXT_INSN (PREV_INSN (head)) = note_tail;
- NEXT_INSN (note_tail) = head;
- PREV_INSN (head) = note_tail;
- head = note_tail;
- }
- }
-
- return head;
-}
-
/* Move INSN, and all insns which should be issued before it,
due to SCHED_GROUP_P flag. Reemit notes if needed.
@@ -1855,7 +1800,24 @@ schedule_block (b, rgn_n_insns)
head = NEXT_INSN (prev_head);
tail = last;
- head = reemit_other_notes (head, tail);
+ /* Restore-other-notes: NOTE_LIST is the end of a chain of notes
+ previously found among the insns. Insert them at the beginning
+ of the insns. */
+ if (note_list != 0)
+ {
+ rtx note_head = note_list;
+
+ while (PREV_INSN (note_head))
+ {
+ note_head = PREV_INSN (note_head);
+ }
+
+ PREV_INSN (note_head) = PREV_INSN (head);
+ NEXT_INSN (PREV_INSN (head)) = note_head;
+ PREV_INSN (head) = note_list;
+ NEXT_INSN (note_list) = head;
+ head = note_head;
+ }
/* Debugging. */
if (sched_verbose)
diff --git a/gcc/sched-ebb.c b/gcc/sched-ebb.c
index 13b9fe6602d..31b5f3c19a1 100644
--- a/gcc/sched-ebb.c
+++ b/gcc/sched-ebb.c
@@ -36,6 +36,7 @@ Software Foundation, 59 Temple Place - Suite 330, Boston, MA
#include "except.h"
#include "toplev.h"
#include "recog.h"
+#include "cfglayout.h"
#include "sched-int.h"
/* The number of insns to be scheduled in total. */
@@ -285,9 +286,7 @@ schedule_ebbs (dump_file)
if (n_basic_blocks == 0)
return;
- /* Remove lexical block notes for empty regions. These get shuffled
- about during scheduling and confuse the debugging issue. */
- remove_unnecessary_notes ();
+ scope_to_insns_initialize ();
sched_init (dump_file);
@@ -357,5 +356,7 @@ schedule_ebbs (dump_file)
if (write_symbols != NO_DEBUG)
rm_redundant_line_notes ();
+ scope_to_insns_finalize ();
+
sched_finish ();
}
diff --git a/gcc/sched-rgn.c b/gcc/sched-rgn.c
index 68242046221..892c03fb276 100644
--- a/gcc/sched-rgn.c
+++ b/gcc/sched-rgn.c
@@ -60,6 +60,7 @@ Software Foundation, 59 Temple Place - Suite 330, Boston, MA
#include "except.h"
#include "toplev.h"
#include "recog.h"
+#include "cfglayout.h"
#include "sched-int.h"
/* Define when we want to do count REG_DEAD notes before and after scheduling
@@ -2896,9 +2897,7 @@ schedule_insns (dump_file)
if (n_basic_blocks == 0)
return;
- /* Remove lexical block notes for empty regions. These get shuffled
- about during scheduling and confuse the debugging issue. */
- remove_unnecessary_notes ();
+ scope_to_insns_initialize ();
nr_inter = 0;
nr_spec = 0;
@@ -2986,6 +2985,8 @@ schedule_insns (dump_file)
if (write_symbols != NO_DEBUG)
rm_redundant_line_notes ();
+ scope_to_insns_finalize ();
+
if (sched_verbose)
{
if (reload_completed == 0 && flag_schedule_interblock)
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index a756c74ae77..f47c334b05e 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2001-12-30 Richard Henderson <rth@redhat.com>
+
+ * gcc.dg/debug-6.c: New.
+
2001-12-30 Jakub Jelinek <jakub@redhat.com>
* gcc.c-torture/compile/20011229-2.c: New test.
diff --git a/gcc/testsuite/gcc.dg/debug-6.c b/gcc/testsuite/gcc.dg/debug-6.c
new file mode 100644
index 00000000000..1ed8679c9d4
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/debug-6.c
@@ -0,0 +1,38 @@
+/* Verify that bb-reorder re-inserts nested scopes properly. */
+/* { dg-do compile } */
+/* { dg-options "-O2 -g -dA" } */
+/* { dg-final { scan-assembler "xyzzy" } } */
+
+extern void abort (void);
+
+struct A { char *a, *b, *c, *d; };
+
+static int
+bar2 (struct A *x)
+{
+ int a = x->c - x->b;
+ x->c += 26;
+ return a;
+}
+
+void fnptr (int *);
+
+void
+foo (void)
+{
+ struct A e;
+
+ if (bar2 (&e) < 0)
+ abort ();
+ {
+ int xyzzy;
+ fnptr (&xyzzy);
+ }
+ {
+ struct A *f;
+
+ f = &e;
+ if (f->c - f->a > f->d - f->a)
+ f->c = f->d;
+ }
+}