diff options
| author | Jakub Jelinek <jakub@gcc.gnu.org> | 2002-02-20 23:54:35 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@gcc.gnu.org> | 2002-02-20 23:54:35 +0100 |
| commit | 4636c87e232d7df60478859d9a15556d5bc3c0c8 (patch) | |
| tree | 92091a1ae9884506ec5a5bd1f121978289726ebf /gcc/c-format.c | |
| parent | c98b201bd9e49891ff049835c3ae79897a885071 (diff) | |
| download | gcc-4636c87e232d7df60478859d9a15556d5bc3c0c8.tar.gz | |
re PR c/4389 (Improper constant folding)
PR c/4389
* tree.c (host_integerp): Ensure that the constant integer is
representable in a HOST_WIDE_INT or an unsigned HOST_WIDE_INT
when pos is zero or non-zero respectively. Clarify comment.
* c-format.c (check_format_info_recurse): Fix host_integerp
usage; the pos argument should be zero when assigning to a
signed HOST_WIDE_INT.
* gcc.dg/20020219-1.c: New test.
From-SVN: r49914
Diffstat (limited to 'gcc/c-format.c')
| -rw-r--r-- | gcc/c-format.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/gcc/c-format.c b/gcc/c-format.c index b15b6300563..d52cfba7c70 100644 --- a/gcc/c-format.c +++ b/gcc/c-format.c @@ -1,6 +1,6 @@ /* Check calls to formatted I/O functions (-Wformat). - Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001 - Free Software Foundation, Inc. + Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, + 2001, 2002 Free Software Foundation, Inc. This file is part of GCC. @@ -1516,13 +1516,12 @@ check_format_info_recurse (status, res, info, format_tree, params, arg_num) res->number_non_literal++; return; } - if (!host_integerp (arg1, 1)) + if (!host_integerp (arg1, 0) + || (offset = tree_low_cst (arg1, 0)) < 0) { res->number_non_literal++; return; } - - offset = TREE_INT_CST_LOW (arg1); } if (TREE_CODE (format_tree) != ADDR_EXPR) { |