summaryrefslogtreecommitdiff
path: root/gcc/opts-common.c
diff options
context:
space:
mode:
authorDave Korn <dave.korn.cygwin@gmail.com>2010-06-09 16:46:59 +0000
committerDave Korn <davek@gcc.gnu.org>2010-06-09 16:46:59 +0000
commit807303cf1432a90d6b15fe8f73fc6094fe829ad5 (patch)
tree5e89c85c14285328b9131a92b1e30284dda64105 /gcc/opts-common.c
parent289e52fd12ea388be5e7d3de3dc797fd87004fee (diff)
downloadgcc-807303cf1432a90d6b15fe8f73fc6094fe829ad5.tar.gz
opts-common.c (prune_options): Ensure replacement argv array is correctly terminated by a NULL entry.
* opts-common.c (prune_options): Ensure replacement argv array is correctly terminated by a NULL entry. From-SVN: r160496
Diffstat (limited to 'gcc/opts-common.c')
-rw-r--r--gcc/opts-common.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/gcc/opts-common.c b/gcc/opts-common.c
index b70b823db16..d9368d50f14 100644
--- a/gcc/opts-common.c
+++ b/gcc/opts-common.c
@@ -132,6 +132,10 @@ prune_options (int *argcp, char ***argvp)
{
int argc = *argcp;
int *options = XNEWVEC (int, argc);
+ /* We will only return this replacement argv if we remove at least
+ one argument, so it does not need to be size (argc + 1) to
+ make room for the terminating NULL because we will always have
+ freed up at least one slot when we end up using it at all. */
char **argv = XNEWVEC (char *, argc);
int i, arg_count, need_prune = 0;
const struct cl_option *option;
@@ -225,6 +229,9 @@ keep:
{
*argcp = arg_count;
*argvp = argv;
+ /* Add NULL-termination. Guaranteed not to overflow because
+ arg_count here can only be less than argc. */
+ argv[arg_count] = 0;
}
else
{