summaryrefslogtreecommitdiff
path: root/gcc
diff options
context:
space:
mode:
authorrakdver <rakdver@138bc75d-0d04-0410-961f-82ee72b054a4>2008-03-31 14:19:52 +0000
committerrakdver <rakdver@138bc75d-0d04-0410-961f-82ee72b054a4>2008-03-31 14:19:52 +0000
commit13ecee2146355ef5c516378b712e459d5ebab934 (patch)
treeffad40ad79ed9653b2a213a4f8b639c6da089e67 /gcc
parent51a71296fde977ff0ca5fee6d43304f4606fdc58 (diff)
downloadgcc-13ecee2146355ef5c516378b712e459d5ebab934.tar.gz
PR rtl-optimization/35729
* loop-invariant.c (check_maybe_invariant): Disallow volatile memory references. * gcc.dg/pr35729.c: New test. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@133755 138bc75d-0d04-0410-961f-82ee72b054a4
Diffstat (limited to 'gcc')
-rw-r--r--gcc/ChangeLog6
-rw-r--r--gcc/loop-invariant.c2
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/gcc.dg/pr35729.c15
4 files changed, 27 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 0a426b1b849..a78eae84de0 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2008-03-31 Zdenek Dvorak <ook@ucw.cz>
+
+ PR rtl-optimization/35729
+ * loop-invariant.c (check_maybe_invariant): Disallow volatile memory
+ references.
+
2008-03-31 H.J. Lu <hongjiu.lu@intel.com>
PR target/32000
diff --git a/gcc/loop-invariant.c b/gcc/loop-invariant.c
index ba1f2888b00..64c16a98423 100644
--- a/gcc/loop-invariant.c
+++ b/gcc/loop-invariant.c
@@ -206,7 +206,7 @@ check_maybe_invariant (rtx x)
/* Just handle the most trivial case where we load from an unchanging
location (most importantly, pic tables). */
- if (MEM_READONLY_P (x))
+ if (MEM_READONLY_P (x) && !MEM_VOLATILE_P (x))
break;
return false;
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 3423800bb84..6c208d90ef9 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2008-03-31 Zdenek Dvorak <ook@ucw.cz>
+
+ PR rtl-optimization/35729
+ * gcc.dg/pr35729.c: New test.
+
2008-03-31 H.J. Lu <hongjiu.lu@intel.com>
PR target/32000
diff --git a/gcc/testsuite/gcc.dg/pr35729.c b/gcc/testsuite/gcc.dg/pr35729.c
new file mode 100644
index 00000000000..3ed40f413bc
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr35729.c
@@ -0,0 +1,15 @@
+/* { dg-do compile } */
+/* { dg-options "-Os -fdump-rtl-loop2_invariant" } */
+
+const volatile int g_361 = 3L;
+volatile int g_2 = 0L;
+void func_1 (void)
+{
+ for (g_2 = 0; g_2 > 10; g_2++)
+ {
+ int l_357 = g_361;
+ }
+}
+
+/* { dg-final { scan-rtl-dump-times "Decided to move invariant" 0 "loop2_invariant" } } */
+/* { dg-final { cleanup-rtl-dump "loop2_invariant" } } */