summaryrefslogtreecommitdiff
path: root/libstdc++-v3
diff options
context:
space:
mode:
authorredi <redi@138bc75d-0d04-0410-961f-82ee72b054a4>2016-04-05 13:35:32 +0000
committerredi <redi@138bc75d-0d04-0410-961f-82ee72b054a4>2016-04-05 13:35:32 +0000
commit9236fc885b2dc17de36ece0a73dc4d22965fe76e (patch)
treedceb5eb074a6bfe5ce3c46911d957499b22cffa2 /libstdc++-v3
parent600faa6895cfa7897499f67d6a3a37d0a542f5e2 (diff)
downloadgcc-9236fc885b2dc17de36ece0a73dc4d22965fe76e.tar.gz
Ensure std::thread helpers have internal linkage
PR libstdc++/70503 * src/c++11/thread.cc (execute_native_thread_routine, execute_native_thread_routine_compat): Give internal linkage. * testsuite/30_threads/thread/70503.cc: New test. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@234746 138bc75d-0d04-0410-961f-82ee72b054a4
Diffstat (limited to 'libstdc++-v3')
-rw-r--r--libstdc++-v3/ChangeLog7
-rw-r--r--libstdc++-v3/src/c++11/thread.cc8
-rw-r--r--libstdc++-v3/testsuite/30_threads/thread/70503.cc33
3 files changed, 44 insertions, 4 deletions
diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog
index 2977bd0938a..c4356c9e594 100644
--- a/libstdc++-v3/ChangeLog
+++ b/libstdc++-v3/ChangeLog
@@ -1,3 +1,10 @@
+2016-04-05 Jonathan Wakely <jwakely@redhat.com>
+
+ PR libstdc++/70503
+ * src/c++11/thread.cc (execute_native_thread_routine,
+ execute_native_thread_routine_compat): Give internal linkage.
+ * testsuite/30_threads/thread/70503.cc: New test.
+
2016-04-05 Ville Voutilainen <ville.voutilainen@gmail.com>
PR libstdc++/70437
diff --git a/libstdc++-v3/src/c++11/thread.cc b/libstdc++-v3/src/c++11/thread.cc
index d2a7dc3e1ee..a027fcf4bb2 100644
--- a/libstdc++-v3/src/c++11/thread.cc
+++ b/libstdc++-v3/src/c++11/thread.cc
@@ -71,9 +71,9 @@ static inline int get_nprocs()
namespace std _GLIBCXX_VISIBILITY(default)
{
- namespace
+ extern "C"
{
- extern "C" void*
+ static void*
execute_native_thread_routine(void* __p)
{
thread::_State_ptr __t{ static_cast<thread::_State*>(__p) };
@@ -95,7 +95,7 @@ namespace std _GLIBCXX_VISIBILITY(default)
}
#if _GLIBCXX_THREAD_ABI_COMPAT
- extern "C" void*
+ static void*
execute_native_thread_routine_compat(void* __p)
{
thread::_Impl_base* __t = static_cast<thread::_Impl_base*>(__p);
@@ -121,7 +121,7 @@ namespace std _GLIBCXX_VISIBILITY(default)
return nullptr;
}
#endif
- }
+ } // extern "C"
_GLIBCXX_BEGIN_NAMESPACE_VERSION
diff --git a/libstdc++-v3/testsuite/30_threads/thread/70503.cc b/libstdc++-v3/testsuite/30_threads/thread/70503.cc
new file mode 100644
index 00000000000..1763ac2dc0a
--- /dev/null
+++ b/libstdc++-v3/testsuite/30_threads/thread/70503.cc
@@ -0,0 +1,33 @@
+// Copyright (C) 2016 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-do link }
+// { dg-options " -std=gnu++11 -static" { target *-*-*gnu* } }
+// { dg-require-cstdint "" }
+// { dg-require-gthreads "" }
+
+extern "C" {
+ void execute_native_thread_routine(void);
+ void execute_native_thread_routine_compat(void);
+}
+
+int main()
+{
+ execute_native_thread_routine(); // { dg-error "undefined reference" }
+ execute_native_thread_routine_compat(); // { dg-error "undefined reference" }
+}
+// { dg-prune-output "collect2: error: ld returned" }