diff options
author | redi <redi@138bc75d-0d04-0410-961f-82ee72b054a4> | 2015-03-26 19:59:08 +0000 |
---|---|---|
committer | redi <redi@138bc75d-0d04-0410-961f-82ee72b054a4> | 2015-03-26 19:59:08 +0000 |
commit | 1b6a72f6958c4ee1b4aa31f8631766093994ec79 (patch) | |
tree | 4b13770b22c24a7b55883559fe1eea9898165a50 /libstdc++-v3 | |
parent | bfbaf6bbe78de3bee8db1b303de9c0109e9c3f58 (diff) | |
download | gcc-1b6a72f6958c4ee1b4aa31f8631766093994ec79.tar.gz |
PR libstdc++/58038
PR libstdc++/60421
* include/std/thread (this_thread::sleep_for): Check for negative
durations.
(this_thread::sleep_until): Check for times in the past.
* testsuite/30_threads/this_thread/58038.cc: New.
* testsuite/30_threads/this_thread/60421.cc: New.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@221708 138bc75d-0d04-0410-961f-82ee72b054a4
Diffstat (limited to 'libstdc++-v3')
-rw-r--r-- | libstdc++-v3/ChangeLog | 10 | ||||
-rw-r--r-- | libstdc++-v3/include/std/thread | 8 | ||||
-rw-r--r-- | libstdc++-v3/testsuite/30_threads/this_thread/58038.cc | 44 | ||||
-rw-r--r-- | libstdc++-v3/testsuite/30_threads/this_thread/60421.cc | 38 |
4 files changed, 99 insertions, 1 deletions
diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 3021c74e381..cac4af869c1 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,5 +1,15 @@ 2015-03-26 Jonathan Wakely <jwakely@redhat.com> + PR libstdc++/58038 + PR libstdc++/60421 + * include/std/thread (this_thread::sleep_for): Check for negative + durations. + (this_thread::sleep_until): Check for times in the past. + * testsuite/30_threads/this_thread/58038.cc: New. + * testsuite/30_threads/this_thread/60421.cc: New. + +2015-03-26 Jonathan Wakely <jwakely@redhat.com> + PR libstdc++/62259 PR libstdc++/65147 * include/std/atomic (atomic<T>): Increase alignment for types with diff --git a/libstdc++-v3/include/std/thread b/libstdc++-v3/include/std/thread index 2f9e69a88cd..ebbda62fa72 100644 --- a/libstdc++-v3/include/std/thread +++ b/libstdc++-v3/include/std/thread @@ -279,6 +279,8 @@ _GLIBCXX_END_NAMESPACE_VERSION inline void sleep_for(const chrono::duration<_Rep, _Period>& __rtime) { + if (__rtime <= __rtime.zero()) + return; auto __s = chrono::duration_cast<chrono::seconds>(__rtime); auto __ns = chrono::duration_cast<chrono::nanoseconds>(__rtime - __s); #ifdef _GLIBCXX_USE_NANOSLEEP @@ -297,7 +299,11 @@ _GLIBCXX_END_NAMESPACE_VERSION template<typename _Clock, typename _Duration> inline void sleep_until(const chrono::time_point<_Clock, _Duration>& __atime) - { sleep_for(__atime - _Clock::now()); } + { + auto __now = _Clock::now(); + if (__now < __atime) + sleep_for(__atime - __now); + } _GLIBCXX_END_NAMESPACE_VERSION } diff --git a/libstdc++-v3/testsuite/30_threads/this_thread/58038.cc b/libstdc++-v3/testsuite/30_threads/this_thread/58038.cc new file mode 100644 index 00000000000..afa861c60f2 --- /dev/null +++ b/libstdc++-v3/testsuite/30_threads/this_thread/58038.cc @@ -0,0 +1,44 @@ +// Copyright (C) 2015 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// <http://www.gnu.org/licenses/>. + +// { dg-options "-std=gnu++11" } +// { dg-require-cstdint "" } +// { dg-require-time "" } + +#include <thread> +#include <chrono> + +void +test01() +{ + auto now = std::chrono::system_clock::now(); + std::this_thread::sleep_until(now - 1ul * std::chrono::seconds(1)); +} + +void +test02() +{ + auto now = std::chrono::steady_clock::now(); + std::this_thread::sleep_until(now - 1ul * std::chrono::seconds(1)); +} + +int +main() +{ + test01(); + test02(); +} diff --git a/libstdc++-v3/testsuite/30_threads/this_thread/60421.cc b/libstdc++-v3/testsuite/30_threads/this_thread/60421.cc new file mode 100644 index 00000000000..ecc4deb4a0f --- /dev/null +++ b/libstdc++-v3/testsuite/30_threads/this_thread/60421.cc @@ -0,0 +1,38 @@ +// Copyright (C) 2015 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// <http://www.gnu.org/licenses/>. + +// { dg-options "-std=gnu++11" } +// { dg-require-cstdint "" } +// { dg-require-time "" } + +#include <thread> +#include <chrono> +#include <testsuite_hooks.h> + +void +test01() +{ + std::this_thread::sleep_for(std::chrono::seconds(0)); + std::this_thread::sleep_for(std::chrono::seconds(-1)); + std::this_thread::sleep_for(std::chrono::duration<uint64_t>::zero()); +} + +int +main() +{ + test01(); +} |