summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGeoffrey Keating <geoffk@geoffk.org>2000-10-16 18:08:29 +0000
committerGeoffrey Keating <geoffk@geoffk.org>2000-10-16 18:08:29 +0000
commit665f1b753809b82384f8ced84a9c045fcbf2ae47 (patch)
treec9baab0413cce5b2a97dd29a7a8aab9f3cb6b7cb
parentfa94a8071d4adfed6cd22772b2a2f38e188b70d9 (diff)
downloadgdb-665f1b753809b82384f8ced84a9c045fcbf2ae47.tar.gz
From 2000-10-14 Geoffrey Keating <geoffk@cygnus.com>
* elf32-ppc.c (ppc_elf_finish_dynamic_symbol): Don't make PLT entries that could serve as a definition for a weak symbol.
-rw-r--r--bfd/ChangeLog6
-rw-r--r--bfd/elf32-ppc.c7
2 files changed, 13 insertions, 0 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 7659ec68400..e510060f991 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2000-10-16 Geoffrey Keating <geoffk@cygnus.com>
+
+ From 2000-10-14 Geoffrey Keating <geoffk@cygnus.com>
+ * elf32-ppc.c (ppc_elf_finish_dynamic_symbol): Don't make PLT
+ entries that could serve as a definition for a weak symbol.
+
2000-10-15 Philip Blundell <philb@gnu.org>
From 2000-09-08 Nick Clifton <nickc@redhat.com>
diff --git a/bfd/elf32-ppc.c b/bfd/elf32-ppc.c
index 242cfb730ab..e648f0256c2 100644
--- a/bfd/elf32-ppc.c
+++ b/bfd/elf32-ppc.c
@@ -2687,6 +2687,13 @@ ppc_elf_finish_dynamic_symbol (output_bfd, info, h, sym)
/* Mark the symbol as undefined, rather than as defined in
the .plt section. Leave the value alone. */
sym->st_shndx = SHN_UNDEF;
+ /* If the symbol is weak, we do need to clear the value.
+ Otherwise, the PLT entry would provide a definition for
+ the symbol even if the symbol wasn't defined anywhere,
+ and so the symbol would never be NULL. */
+ if ((h->elf_link_hash_flags & ELF_LINK_HASH_REF_REGULAR_NONWEAK)
+ == 0)
+ sym->st_value = 0;
}
}