summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Modra <amodra@bigpond.net.au>2008-09-19 10:03:31 +0000
committerAlan Modra <amodra@bigpond.net.au>2008-09-19 10:03:31 +0000
commite1934b327fe9a3f350fba205422a415fd3d165fd (patch)
treeede6505ee0f02292c224bfc5f5c13cdfa4c249a7
parent4a8693d1c6f840e5178f23eae257da2db999609a (diff)
downloadgdb-e1934b327fe9a3f350fba205422a415fd3d165fd.tar.gz
* elf32-ppc.c (ppc_elf_finish_dynamic_sections): Handle vxworks
_GLOBAL_OFFSET_TABLE_ in .got.plt section. Add BFD_ASSERTs.
-rw-r--r--bfd/ChangeLog5
-rw-r--r--bfd/elf32-ppc.c29
2 files changed, 24 insertions, 10 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index c77afe338d8..374503c018c 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2008-09-19 Alan Modra <amodra@bigpond.net.au>
+
+ * elf32-ppc.c (ppc_elf_finish_dynamic_sections): Handle vxworks
+ _GLOBAL_OFFSET_TABLE_ in .got.plt section. Add BFD_ASSERTs.
+
2008-09-17 H.J. Lu <hongjiu.lu@intel.com>
Daniel Jacobowitz <dan@codesourcery.com>
diff --git a/bfd/elf32-ppc.c b/bfd/elf32-ppc.c
index 10828209b2e..1d9cabd2dc0 100644
--- a/bfd/elf32-ppc.c
+++ b/bfd/elf32-ppc.c
@@ -7727,29 +7727,38 @@ ppc_elf_finish_dynamic_sections (bfd *output_bfd,
}
}
- /* Add a blrl instruction at _GLOBAL_OFFSET_TABLE_-4 so that a function can
- easily find the address of the _GLOBAL_OFFSET_TABLE_. */
if (htab->got != NULL)
{
- if (htab->elf.hgot->root.u.def.section == htab->got)
+ if (htab->elf.hgot->root.u.def.section == htab->got
+ || htab->elf.hgot->root.u.def.section == htab->sgotplt)
{
- unsigned char *p = htab->got->contents;
- bfd_vma val;
+ unsigned char *p = htab->elf.hgot->root.u.def.section->contents;
p += htab->elf.hgot->root.u.def.value;
if (htab->plt_type == PLT_OLD)
- bfd_put_32 (output_bfd, 0x4e800021 /* blrl */, p - 4);
+ {
+ /* Add a blrl instruction at _GLOBAL_OFFSET_TABLE_-4
+ so that a function can easily find the address of
+ _GLOBAL_OFFSET_TABLE_. */
+ BFD_ASSERT (htab->elf.hgot->root.u.def.value - 4
+ < htab->elf.hgot->root.u.def.section->size);
+ bfd_put_32 (output_bfd, 0x4e800021, p - 4);
+ }
- val = 0;
if (sdyn != NULL)
- val = sdyn->output_section->vma + sdyn->output_offset;
- bfd_put_32 (output_bfd, val, p);
+ {
+ bfd_vma val = sdyn->output_section->vma + sdyn->output_offset;
+ BFD_ASSERT (htab->elf.hgot->root.u.def.value
+ < htab->elf.hgot->root.u.def.section->size);
+ bfd_put_32 (output_bfd, val, p);
+ }
}
else
{
(*_bfd_error_handler) (_("%s not defined in linker created %s"),
htab->elf.hgot->root.root.string,
- htab->got->name);
+ (htab->sgotplt != NULL
+ ? htab->sgotplt->name : htab->got->name));
bfd_set_error (bfd_error_bad_value);
ret = FALSE;
}