diff options
| author | Alan Modra <amodra@bigpond.net.au> | 2007-03-07 02:14:40 +0000 |
|---|---|---|
| committer | Alan Modra <amodra@bigpond.net.au> | 2007-03-07 02:14:40 +0000 |
| commit | 7ca2b4493774a09327290a6935092b7ec03dce3e (patch) | |
| tree | aecb51af7660c24e07cec89ae5bf7d45b903d4cf | |
| parent | c0e87a8609f660c74dc8fb4706a05c9735659f2f (diff) | |
| download | gdb-7ca2b4493774a09327290a6935092b7ec03dce3e.tar.gz | |
PR 4144
* elf.c (assign_file_positions_for_load_sections): Don't
adjust p_memsz for !SEC_LOAD section vma modulo page size.
Instead, use the same lma based adjustment for SEC_LOAD
sections.
| -rw-r--r-- | bfd/ChangeLog | 8 | ||||
| -rw-r--r-- | bfd/elf.c | 34 |
2 files changed, 20 insertions, 22 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 37b3c2df2ee..915b6898a45 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,11 @@ +2007-03-07 Alan Modra <amodra@bigpond.net.au> + + PR 4144 + * elf.c (assign_file_positions_for_load_sections): Don't + adjust p_memsz for !SEC_LOAD section vma modulo page size. + Instead, use the same lma based adjustment for SEC_LOAD + sections. + 2007-03-01 Bob Wilson <bob.wilson@acm.org> * elf32-xtensa.c (analyze_relocations): Zero src_count if not relaxing. diff --git a/bfd/elf.c b/bfd/elf.c index e2b0f052666..d8828828d86 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -1,7 +1,7 @@ /* ELF executable support for BFD. Copyright 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, - 2002, 2003, 2004, 2005, 2006 Free Software Foundation, Inc. + 2002, 2003, 2004, 2005, 2006, 2007 Free Software Foundation, Inc. This file is part of BFD, the Binary File Descriptor library. @@ -4495,11 +4495,13 @@ assign_file_positions_for_load_sections (bfd *abfd, if (p->p_type == PT_LOAD || p->p_type == PT_TLS) { - bfd_signed_vma adjust; + bfd_signed_vma adjust = sec->lma - (p->p_paddr + p->p_filesz); - if ((flags & SEC_LOAD) != 0) + if ((flags & SEC_LOAD) != 0 + || ((flags & SEC_ALLOC) != 0 + && ((flags & SEC_THREAD_LOCAL) == 0 + || p->p_type == PT_TLS))) { - adjust = sec->lma - (p->p_paddr + p->p_filesz); if (adjust < 0) { (*_bfd_error_handler) @@ -4507,25 +4509,13 @@ assign_file_positions_for_load_sections (bfd *abfd, abfd, sec, (unsigned long) sec->lma); adjust = 0; } - off += adjust; - p->p_filesz += adjust; - p->p_memsz += adjust; - } - /* .tbss is special. It doesn't contribute to p_memsz of - normal segments. */ - else if ((flags & SEC_ALLOC) != 0 - && ((flags & SEC_THREAD_LOCAL) == 0 - || p->p_type == PT_TLS)) - { - /* The section VMA must equal the file position - modulo the page size. */ - bfd_size_type page = align; - if (page < maxpagesize) - page = maxpagesize; - adjust = vma_page_aligned_bias (sec->vma, - p->p_vaddr + p->p_memsz, - page); p->p_memsz += adjust; + + if ((flags & SEC_LOAD) != 0) + { + off += adjust; + p->p_filesz += adjust; + } } } |