Zero out the dynamic allocated content space. Add a comment to remind us that

one day this ought to be fixed.

1 files changed, 6 insertions, 1 deletions

diff --git a/bfd/elf32-i386.c b/bfd/elf32-i386.c
index ace82876df9..bed03150921 100644
--- a/bfd/elf32-i386.c
+++ b/bfd/elf32-i386.c
@@ -1198,7 +1198,12 @@ elf_i386_size_dynamic_sections (output_bfd, info)
 	}
 
       /* Allocate memory for the section contents.  */
-      s->contents = (bfd_byte *) bfd_alloc (dynobj, s->_raw_size);
+      /* FIXME: This should be a call to bfd_alloc not bfd_zalloc.
+	 Unused entries should be reclaimed before the section's contents
+	 are written out, but at the moment this does not happen.  Thus in
+	 order to prevent writing out garbage, we initialise the section's
+	 contents to zero.  */
+      s->contents = (bfd_byte *) bfd_zalloc (dynobj, s->_raw_size);
       if (s->contents == NULL && s->_raw_size != 0)
 	return false;
     }