diff options
| author | Kevin Buettner <kevinb@redhat.com> | 2002-12-23 23:36:39 +0000 |
|---|---|---|
| committer | Kevin Buettner <kevinb@redhat.com> | 2002-12-23 23:36:39 +0000 |
| commit | 5077609966b94050c0e867869283b3068d2db3f4 (patch) | |
| tree | e2cdf108a96419b5b43d2cf9c03a9868dc867193 /gdb/exec.c | |
| parent | 3e73dce66a8d5e2450729ebbc0c120706989f490 (diff) | |
| download | gdb-5077609966b94050c0e867869283b3068d2db3f4.tar.gz | |
* exec.c (print_section_info): Add FIXME comments regarding format
string choices.
Diffstat (limited to 'gdb/exec.c')
| -rw-r--r-- | gdb/exec.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/gdb/exec.c b/gdb/exec.c index 16b7e5f4e8d..b495a009641 100644 --- a/gdb/exec.c +++ b/gdb/exec.c @@ -545,6 +545,7 @@ void print_section_info (struct target_ops *t, bfd *abfd) { struct section_table *p; + /* FIXME: "016l" is not wide enough when TARGET_ADDR_BIT > 64. */ char *fmt = TARGET_ADDR_BIT <= 32 ? "08l" : "016l"; printf_filtered ("\t`%s', ", bfd_get_filename (abfd)); @@ -560,6 +561,12 @@ print_section_info (struct target_ops *t, bfd *abfd) { printf_filtered ("\t%s", local_hex_string_custom (p->addr, fmt)); printf_filtered (" - %s", local_hex_string_custom (p->endaddr, fmt)); + + /* FIXME: A format of "08l" is not wide enough for file offsets + larger than 4GB. OTOH, making it "016l" isn't desirable either + since most output will then be much wider than necessary. It + may make sense to test the size of the file and choose the + format string accordingly. */ if (info_verbose) printf_filtered (" @ %s", local_hex_string_custom (p->the_bfd_section->filepos, "08l")); |