summaryrefslogtreecommitdiff
path: root/gdb/top.c
diff options
context:
space:
mode:
authorDaniel Jacobowitz <dan@debian.org>2008-03-21 21:44:30 +0000
committerDaniel Jacobowitz <dan@debian.org>2008-03-21 21:44:30 +0000
commit8750796b2fb33417f8a740a5a9b64a1a743d8b52 (patch)
treea92852960c3f903bdeb9767ee79b7dbbb7faba2d /gdb/top.c
parentbd79c70e6445a60b4d5bf5bef4557dc143146b0d (diff)
downloadgdb-8750796b2fb33417f8a740a5a9b64a1a743d8b52.tar.gz
PR gdb/544
Suggested by Jan Kratochvil: * top.c (gdb_rl_operate_and_get_next_completion): Call rl_redisplay_function. (gdb_rl_redisplay): New. (init_main): Set rl_redisplay_function. * gdb.cp/annota2.exp, gdb.cp/annota3.exp: Remove KFAIL for fixed PR gdb/544.
Diffstat (limited to 'gdb/top.c')
-rw-r--r--gdb/top.c26
1 files changed, 25 insertions, 1 deletions
diff --git a/gdb/top.c b/gdb/top.c
index 418ff8e95f0..505b5832506 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -921,7 +921,7 @@ gdb_rl_operate_and_get_next_completion (void)
operate_saved_history = -1;
/* readline doesn't automatically update the display for us. */
- rl_redisplay ();
+ rl_redisplay_function ();
after_char_processing_hook = NULL;
rl_pre_input_hook = NULL;
@@ -956,6 +956,29 @@ gdb_rl_operate_and_get_next (int count, int key)
return rl_newline (1, key);
}
+
+/* Readline 5.2 and earlier do not block SIGINT while redrawing the prompt.
+ This can lead to corrupted internal state. As long as we do not require
+ a newer readline version, compensate for it. */
+static void
+gdb_rl_redisplay (void)
+{
+#if HAVE_SIGPROCMASK
+ sigset_t sigint_set, sigint_oset;
+
+ sigemptyset (&sigint_set);
+ sigemptyset (&sigint_oset);
+ sigaddset (&sigint_set, SIGINT);
+ sigprocmask (SIG_BLOCK, &sigint_set, &sigint_oset);
+#endif
+
+ rl_redisplay ();
+
+#if HAVE_SIGPROCMASK
+ sigprocmask (SIG_SETMASK, &sigint_oset, (sigset_t *)NULL);
+#endif
+}
+
/* Read one line from the command input stream `instream'
into the local static buffer `linebuffer' (whose current length
@@ -1581,6 +1604,7 @@ init_main (void)
rl_completer_quote_characters = get_gdb_completer_quote_characters ();
rl_readline_name = "gdb";
rl_terminal_name = getenv ("TERM");
+ rl_redisplay_function = gdb_rl_redisplay;
/* The name for this defun comes from Bash, where it originated.
15 is Control-o, the same binding this function has in Bash. */