diff options
| author | Jim Ingham <jingham@apple.com> | 2000-02-29 22:47:37 +0000 |
|---|---|---|
| committer | Jim Ingham <jingham@apple.com> | 2000-02-29 22:47:37 +0000 |
| commit | 5d50fe7f7a334e5374dfbd04eea77ac18ba1e2ba (patch) | |
| tree | 39b6348a551dcf38402805a4a39344ff457d5535 /gdb | |
| parent | 450c49f5d07e44e5bf3ba1b3f3a694491afef3c7 (diff) | |
| download | gdb-5d50fe7f7a334e5374dfbd04eea77ac18ba1e2ba.tar.gz | |
2000-02-29 James Ingham <jingham@leda.cygnus.com>
* gdbtk-cmds.c (gdb_disassemble_driver): The to_shortname for
Linux is "linuxthreads", not "linux-threads", so we have to change
the heuristic to account for this. This fixes a crash when trying
to disassemble from shared libraries.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/gdbtk/generic/ChangeLog-gdbtk | 7 | ||||
| -rw-r--r-- | gdb/gdbtk/generic/gdbtk-cmds.c | 7 |
2 files changed, 13 insertions, 1 deletions
diff --git a/gdb/gdbtk/generic/ChangeLog-gdbtk b/gdb/gdbtk/generic/ChangeLog-gdbtk index e61d474f257..a1e79288e59 100644 --- a/gdb/gdbtk/generic/ChangeLog-gdbtk +++ b/gdb/gdbtk/generic/ChangeLog-gdbtk @@ -1,3 +1,10 @@ +2000-02-29 James Ingham <jingham@leda.cygnus.com> + + * gdbtk-cmds.c (gdb_disassemble_driver): The to_shortname for + Linux is "linuxthreads", not "linux-threads", so we have to change + the heuristic to account for this. This fixes a crash when trying + to disassemble from shared libraries. + 2000-02-23 Keith R Seitz <kseitz@nwlink.com> * gdbtk-wrapper.h: Add declarations for GDB_get_prev_frame, GDB_get_next_frame, diff --git a/gdb/gdbtk/generic/gdbtk-cmds.c b/gdb/gdbtk/generic/gdbtk-cmds.c index ddbbe9773ec..d49b086748b 100644 --- a/gdb/gdbtk/generic/gdbtk-cmds.c +++ b/gdb/gdbtk/generic/gdbtk-cmds.c @@ -2867,6 +2867,11 @@ gdb_disassemble_driver (low, high, mixed_source_and_assembly, Else, we're debugging a remote process, and should disassemble from the exec file for speed. However, this is no good if the target modifies its code (for relocation, or whatever). + + As an aside, it is fairly bogus that there is not a better way to + determine where to disassemble from. There should be a target vector + entry for this or something. + */ if (disassemble_from_exec == -1) @@ -2874,7 +2879,7 @@ gdb_disassemble_driver (low, high, mixed_source_and_assembly, if (strcmp (target_shortname, "child") == 0 || strcmp (target_shortname, "procfs") == 0 || strcmp (target_shortname, "vxprocess") == 0 - || strstr (target_shortname, "-threads") != NULL) + || strstr (target_shortname, "threads") != NULL) /* It's a child process, read inferior mem */ disassemble_from_exec = 0; else |