summaryrefslogtreecommitdiff
path: root/gdb
diff options
context:
space:
mode:
authorAndrew Cagney <cagney@redhat.com>2004-09-12 16:13:04 +0000
committerAndrew Cagney <cagney@redhat.com>2004-09-12 16:13:04 +0000
commit2da3d6892b2c11618a92650b46045caaa144d971 (patch)
tree45fd6cff50e9449f0b6d8f0dc8dcab7ea92868ac /gdb
parent4bd6e9ed748dc18a5a3178c585f2c064e48c8cf5 (diff)
downloadgdb-2da3d6892b2c11618a92650b46045caaa144d971.tar.gz
2004-09-12 Andrew Cagney <cagney@gnu.org>
* valprint.c (print_longest): Use fputs_filtered. Make "val" const. * Makefile.in (valprint.o): Delete explict rule.
Diffstat (limited to 'gdb')
-rw-r--r--gdb/ChangeLog4
-rw-r--r--gdb/Makefile.in6
-rw-r--r--gdb/valprint.c6
3 files changed, 7 insertions, 9 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 649d07b57f6..389dc0de2eb 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2004-09-12 Andrew Cagney <cagney@gnu.org>
+ * valprint.c (print_longest): Use fputs_filtered. Make "val"
+ const.
+ * Makefile.in (valprint.o): Delete explict rule.
+
* config/m68k/nbsdelf.mh: Add missing trailing newline. Problem
reported by Dave Anderson.
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index cf29fade1cd..a8fcd7321bc 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1465,12 +1465,6 @@ v850ice.o: $(srcdir)/v850ice.c
$(GDBTK_CFLAGS) \
$(srcdir)/v850ice.c
-# FIXME: cagney/2003-08-10: Do not try to build "valprint.c" with
-# -Wformat-nonliteral. It relies on local_hex_format et.al. and
-# that's a mess. It needs a serious overhaul.
-valprint.o: $(srcdir)/valprint.c
- $(CC) -c $(INTERNAL_WARN_CFLAGS) $(NO_WERROR_CFLAGS) $(srcdir)/valprint.c
-
# Message files. Based on code in gcc/Makefile.in.
diff --git a/gdb/valprint.c b/gdb/valprint.c
index 64216f85f0b..fd92750b8c6 100644
--- a/gdb/valprint.c
+++ b/gdb/valprint.c
@@ -230,7 +230,8 @@ void
print_longest (struct ui_file *stream, int format, int use_c_format,
LONGEST val_long)
{
- char *val;
+ const char *val;
+
switch (format)
{
case 'd':
@@ -253,8 +254,7 @@ print_longest (struct ui_file *stream, int format, int use_c_format,
default:
internal_error (__FILE__, __LINE__, "failed internal consistency check");
}
-
- fprintf_filtered (stream, val);
+ fputs_filtered (val, stream);
}
/* This used to be a macro, but I don't think it is called often enough