diff options
| author | Andrew Cagney <cagney@redhat.com> | 2003-10-16 18:24:13 +0000 |
|---|---|---|
| committer | Andrew Cagney <cagney@redhat.com> | 2003-10-16 18:24:13 +0000 |
| commit | d631a80438c01b3084c6afa05ad0ea6e3d0c196d (patch) | |
| tree | d40d729208c2a30947eb948f145063c5c8c4cbad /gdb | |
| parent | 1da02d627fcd030c14094473010f51e3d1fc3858 (diff) | |
| download | gdb-d631a80438c01b3084c6afa05ad0ea6e3d0c196d.tar.gz | |
2003-10-16 Andrew Cagney <cagney@redhat.com>
* infrun.c (handle_inferior_event): Add comment about
"frame_id_inner" being too weak.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/infrun.c | 16 |
2 files changed, 21 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 3834c5481ee..654f63f5d9b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2003-10-16 Andrew Cagney <cagney@redhat.com> + + * infrun.c (handle_inferior_event): Add comment about + "frame_id_inner" being too weak. + 2003-10-16 Elena Zannoni <ezannoni@redhat.com> * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove diff --git a/gdb/infrun.c b/gdb/infrun.c index e22a90a9267..7412080ba35 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -2636,6 +2636,22 @@ process_event_stop_test: /* In the case where we just stepped out of a function into the middle of a line of the caller, continue stepping, but step_frame_id must be modified to current frame */ +#if 0 + /* NOTE: cagney/2003-10-16: I think this frame ID inner test is too + generous. It will trigger on things like a step into a frameless + stackless leaf function. I think the logic should instead look + at the unwound frame ID has that should give a more robust + indication of what happened. */ + if (step-ID == current-ID) + still stepping in same function; + else if (step-ID == unwind (current-ID)) + stepped into a function; + else + stepped out of a function; + /* Of course this assumes that the frame ID unwind code is robust + and we're willing to introduce frame unwind logic into this + function. Fortunatly, those days are nearly upon us. */ +#endif { struct frame_id current_frame = get_frame_id (get_current_frame ()); if (!(frame_id_inner (current_frame, step_frame_id))) |