From e8ec7f8ff59cb2245ad128a731968d949c97f2db Mon Sep 17 00:00:00 2001 From: Daniel Jacobowitz Date: Fri, 14 Mar 2008 18:39:43 +0000 Subject: * cache.c (close_one): Remove mtime hack. * corefile.c (reopen_exec_file): Use exec_bfd_mtime. * exec.c (exec_bfd_mtime): Define. (exec_close): Clear it. (exec_file_attach): Set it. * gdbcore.h (exec_bfd_mtime): Declare. * source.c (find_source_lines): Do not use bfd_get_mtime. --- bfd/cache.c | 16 ---------------- 1 file changed, 16 deletions(-) (limited to 'bfd/cache.c') diff --git a/bfd/cache.c b/bfd/cache.c index 064cebeb3cb..eb6120dfbe2 100644 --- a/bfd/cache.c +++ b/bfd/cache.c @@ -166,22 +166,6 @@ close_one (void) kill->where = real_ftell ((FILE *) kill->iostream); - /* Save the file st_mtime. This is a hack so that gdb can detect when - an executable has been deleted and recreated. The only thing that - makes this reasonable is that st_mtime doesn't change when a file - is unlinked, so saving st_mtime makes BFD's file cache operation - a little more transparent for this particular usage pattern. If we - hadn't closed the file then we would not have lost the original - contents, st_mtime etc. Of course, if something is writing to an - existing file, then this is the wrong thing to do. - FIXME: gdb should save these times itself on first opening a file, - and this hack be removed. */ - if (kill->direction == no_direction || kill->direction == read_direction) - { - bfd_get_mtime (kill); - kill->mtime_set = TRUE; - } - return bfd_cache_delete (kill); } -- cgit v1.2.1