Optimization - when we've already found a widget, skip all checks for

Tue Dec 22 14:50:25 1998  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkdnd.c (gtk_drag_find_widget): Optimization -
	when we've already found a widget, skip all checks
	for subsequent children.

	* gtk/gtkdnd.c (gtk_drag_find_widget): Checked for
	!MAPPED, not !VISIBLE, since a widget (like a notebook
	page), can be VISIBLE, but !REALIZED or !MAPPED.

	* gtk/gtkdnd.c (gtk_drag_find_widget): Use forall(),
	not foreach().

8 files changed, 95 insertions, 4 deletions

diff --git a/ChangeLog b/ChangeLog
index bc0506d0f..4d1b69d7b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+Tue Dec 22 14:50:25 1998  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Optimization -
+	when we've already found a widget, skip all checks
+	for subsequent children.
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Checked for
+	!MAPPED, not !VISIBLE, since a widget (like a notebook
+	page), can be VISIBLE, but !REALIZED or !MAPPED.
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Use forall(),
+	not foreach().
+
 Mon Dec 21 22:01:49 1998  Lars Hamann  <lars@gtk.org>
 
 	* gtk/gtkclist.c (gtk_clist_motion): fixed column resize bug
diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0
index bc0506d0f..4d1b69d7b 100644
--- a/ChangeLog.pre-2-0
+++ b/ChangeLog.pre-2-0
@@ -1,3 +1,16 @@
+Tue Dec 22 14:50:25 1998  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Optimization -
+	when we've already found a widget, skip all checks
+	for subsequent children.
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Checked for
+	!MAPPED, not !VISIBLE, since a widget (like a notebook
+	page), can be VISIBLE, but !REALIZED or !MAPPED.
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Use forall(),
+	not foreach().
+
 Mon Dec 21 22:01:49 1998  Lars Hamann  <lars@gtk.org>
 
 	* gtk/gtkclist.c (gtk_clist_motion): fixed column resize bug
diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index bc0506d0f..4d1b69d7b 100644
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,16 @@
+Tue Dec 22 14:50:25 1998  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Optimization -
+	when we've already found a widget, skip all checks
+	for subsequent children.
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Checked for
+	!MAPPED, not !VISIBLE, since a widget (like a notebook
+	page), can be VISIBLE, but !REALIZED or !MAPPED.
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Use forall(),
+	not foreach().
+
 Mon Dec 21 22:01:49 1998  Lars Hamann  <lars@gtk.org>
 
 	* gtk/gtkclist.c (gtk_clist_motion): fixed column resize bug
diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2
index bc0506d0f..4d1b69d7b 100644
--- a/ChangeLog.pre-2-2
+++ b/ChangeLog.pre-2-2
@@ -1,3 +1,16 @@
+Tue Dec 22 14:50:25 1998  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Optimization -
+	when we've already found a widget, skip all checks
+	for subsequent children.
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Checked for
+	!MAPPED, not !VISIBLE, since a widget (like a notebook
+	page), can be VISIBLE, but !REALIZED or !MAPPED.
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Use forall(),
+	not foreach().
+
 Mon Dec 21 22:01:49 1998  Lars Hamann  <lars@gtk.org>
 
 	* gtk/gtkclist.c (gtk_clist_motion): fixed column resize bug
diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index bc0506d0f..4d1b69d7b 100644
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -1,3 +1,16 @@
+Tue Dec 22 14:50:25 1998  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Optimization -
+	when we've already found a widget, skip all checks
+	for subsequent children.
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Checked for
+	!MAPPED, not !VISIBLE, since a widget (like a notebook
+	page), can be VISIBLE, but !REALIZED or !MAPPED.
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Use forall(),
+	not foreach().
+
 Mon Dec 21 22:01:49 1998  Lars Hamann  <lars@gtk.org>
 
 	* gtk/gtkclist.c (gtk_clist_motion): fixed column resize bug
diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index bc0506d0f..4d1b69d7b 100644
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,16 @@
+Tue Dec 22 14:50:25 1998  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Optimization -
+	when we've already found a widget, skip all checks
+	for subsequent children.
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Checked for
+	!MAPPED, not !VISIBLE, since a widget (like a notebook
+	page), can be VISIBLE, but !REALIZED or !MAPPED.
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Use forall(),
+	not foreach().
+
 Mon Dec 21 22:01:49 1998  Lars Hamann  <lars@gtk.org>
 
 	* gtk/gtkclist.c (gtk_clist_motion): fixed column resize bug
diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index bc0506d0f..4d1b69d7b 100644
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,16 @@
+Tue Dec 22 14:50:25 1998  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Optimization -
+	when we've already found a widget, skip all checks
+	for subsequent children.
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Checked for
+	!MAPPED, not !VISIBLE, since a widget (like a notebook
+	page), can be VISIBLE, but !REALIZED or !MAPPED.
+
+	* gtk/gtkdnd.c (gtk_drag_find_widget): Use forall(),
+	not foreach().
+
 Mon Dec 21 22:01:49 1998  Lars Hamann  <lars@gtk.org>
 
 	* gtk/gtkclist.c (gtk_clist_motion): fixed column resize bug
diff --git a/gtk/gtkdnd.c b/gtk/gtkdnd.c
index 8c9a55c1d..68379c958 100644
--- a/gtk/gtkdnd.c
+++ b/gtk/gtkdnd.c
@@ -1054,7 +1054,7 @@ gtk_drag_find_widget (GtkWidget       *widget,
 
   new_allocation = widget->allocation;
 
-  if (!GTK_WIDGET_VISIBLE (widget))
+  if (data->found || !GTK_WIDGET_MAPPED (widget))
     return;
 
   if (!GTK_WIDGET_NO_WINDOW (widget))
@@ -1113,9 +1113,9 @@ gtk_drag_find_widget (GtkWidget       *widget,
 	  new_data.found = FALSE;
 	  new_data.toplevel = FALSE;
 	  
-	  gtk_container_foreach (GTK_CONTAINER (widget),
-				 (GtkCallback)gtk_drag_find_widget,
-				 &new_data);
+	  gtk_container_forall (GTK_CONTAINER (widget),
+				(GtkCallback)gtk_drag_find_widget,
+				&new_data);
 	  
 	  data->found = new_data.found;
 	}