Prevent the trivial leak of information of allowing word motion when the

Tue Aug 17 10:56:49 1999  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkentry.c (gtk_move_{forward,backward}_word):
	Prevent the trivial leak of information of allowing
	word motion when the entry is not visible.

8 files changed, 147 insertions, 0 deletions

diff --git a/ChangeLog b/ChangeLog
index f1bb6c093..bda988eaa 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,9 +1,28 @@
+Tue Aug 17 10:56:49 1999  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkentry.c (gtk_move_{forward,backward}_word): 
+	Prevent the trivial leak of information of allowing
+	word motion when the entry is not visible.
+
 Tue Aug 17 10:28:52 1999  Owen Taylor  <otaylor@redhat.com>
 
 	* gtk/gtkfilesel.c (gtk_file_selection_fileop_error): Propagate
 	modality to error dialog as well as confirmation dialogs.
 	(Bug #1803, reported by Rosanna Wing Sze Yuen)
 
+Thu Aug  5 17:05:39 1999  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkrc.c (gtk_rc_clear_styles): Don't call gtk_rc_init()
+	here since that will the default files to be parsed again.
+	Instead, recreate rc_style_ht upon demand.
+
+	* gtk/gtkrc.c: Fix problem where RC styles that were freed 
+	would be left in realized_style_ht, resulting in
+	lookups that returned stale data.
+
+	* gtk/gtkrc.c (gtk_rc_style_unref): Code style cleanups.
+	Create a GtkRcStylePrivate structure in the GDK style.
+
 Wed Aug 11 13:38:26 BST 1999 Tony Gale  <gale@gtk.org>
 
 	* docs/gtkfaq.sgml: FAQ Update
diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0
index f1bb6c093..bda988eaa 100644
--- a/ChangeLog.pre-2-0
+++ b/ChangeLog.pre-2-0
@@ -1,9 +1,28 @@
+Tue Aug 17 10:56:49 1999  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkentry.c (gtk_move_{forward,backward}_word): 
+	Prevent the trivial leak of information of allowing
+	word motion when the entry is not visible.
+
 Tue Aug 17 10:28:52 1999  Owen Taylor  <otaylor@redhat.com>
 
 	* gtk/gtkfilesel.c (gtk_file_selection_fileop_error): Propagate
 	modality to error dialog as well as confirmation dialogs.
 	(Bug #1803, reported by Rosanna Wing Sze Yuen)
 
+Thu Aug  5 17:05:39 1999  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkrc.c (gtk_rc_clear_styles): Don't call gtk_rc_init()
+	here since that will the default files to be parsed again.
+	Instead, recreate rc_style_ht upon demand.
+
+	* gtk/gtkrc.c: Fix problem where RC styles that were freed 
+	would be left in realized_style_ht, resulting in
+	lookups that returned stale data.
+
+	* gtk/gtkrc.c (gtk_rc_style_unref): Code style cleanups.
+	Create a GtkRcStylePrivate structure in the GDK style.
+
 Wed Aug 11 13:38:26 BST 1999 Tony Gale  <gale@gtk.org>
 
 	* docs/gtkfaq.sgml: FAQ Update
diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index f1bb6c093..bda988eaa 100644
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,9 +1,28 @@
+Tue Aug 17 10:56:49 1999  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkentry.c (gtk_move_{forward,backward}_word): 
+	Prevent the trivial leak of information of allowing
+	word motion when the entry is not visible.
+
 Tue Aug 17 10:28:52 1999  Owen Taylor  <otaylor@redhat.com>
 
 	* gtk/gtkfilesel.c (gtk_file_selection_fileop_error): Propagate
 	modality to error dialog as well as confirmation dialogs.
 	(Bug #1803, reported by Rosanna Wing Sze Yuen)
 
+Thu Aug  5 17:05:39 1999  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkrc.c (gtk_rc_clear_styles): Don't call gtk_rc_init()
+	here since that will the default files to be parsed again.
+	Instead, recreate rc_style_ht upon demand.
+
+	* gtk/gtkrc.c: Fix problem where RC styles that were freed 
+	would be left in realized_style_ht, resulting in
+	lookups that returned stale data.
+
+	* gtk/gtkrc.c (gtk_rc_style_unref): Code style cleanups.
+	Create a GtkRcStylePrivate structure in the GDK style.
+
 Wed Aug 11 13:38:26 BST 1999 Tony Gale  <gale@gtk.org>
 
 	* docs/gtkfaq.sgml: FAQ Update
diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2
index f1bb6c093..bda988eaa 100644
--- a/ChangeLog.pre-2-2
+++ b/ChangeLog.pre-2-2
@@ -1,9 +1,28 @@
+Tue Aug 17 10:56:49 1999  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkentry.c (gtk_move_{forward,backward}_word): 
+	Prevent the trivial leak of information of allowing
+	word motion when the entry is not visible.
+
 Tue Aug 17 10:28:52 1999  Owen Taylor  <otaylor@redhat.com>
 
 	* gtk/gtkfilesel.c (gtk_file_selection_fileop_error): Propagate
 	modality to error dialog as well as confirmation dialogs.
 	(Bug #1803, reported by Rosanna Wing Sze Yuen)
 
+Thu Aug  5 17:05:39 1999  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkrc.c (gtk_rc_clear_styles): Don't call gtk_rc_init()
+	here since that will the default files to be parsed again.
+	Instead, recreate rc_style_ht upon demand.
+
+	* gtk/gtkrc.c: Fix problem where RC styles that were freed 
+	would be left in realized_style_ht, resulting in
+	lookups that returned stale data.
+
+	* gtk/gtkrc.c (gtk_rc_style_unref): Code style cleanups.
+	Create a GtkRcStylePrivate structure in the GDK style.
+
 Wed Aug 11 13:38:26 BST 1999 Tony Gale  <gale@gtk.org>
 
 	* docs/gtkfaq.sgml: FAQ Update
diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index f1bb6c093..bda988eaa 100644
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -1,9 +1,28 @@
+Tue Aug 17 10:56:49 1999  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkentry.c (gtk_move_{forward,backward}_word): 
+	Prevent the trivial leak of information of allowing
+	word motion when the entry is not visible.
+
 Tue Aug 17 10:28:52 1999  Owen Taylor  <otaylor@redhat.com>
 
 	* gtk/gtkfilesel.c (gtk_file_selection_fileop_error): Propagate
 	modality to error dialog as well as confirmation dialogs.
 	(Bug #1803, reported by Rosanna Wing Sze Yuen)
 
+Thu Aug  5 17:05:39 1999  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkrc.c (gtk_rc_clear_styles): Don't call gtk_rc_init()
+	here since that will the default files to be parsed again.
+	Instead, recreate rc_style_ht upon demand.
+
+	* gtk/gtkrc.c: Fix problem where RC styles that were freed 
+	would be left in realized_style_ht, resulting in
+	lookups that returned stale data.
+
+	* gtk/gtkrc.c (gtk_rc_style_unref): Code style cleanups.
+	Create a GtkRcStylePrivate structure in the GDK style.
+
 Wed Aug 11 13:38:26 BST 1999 Tony Gale  <gale@gtk.org>
 
 	* docs/gtkfaq.sgml: FAQ Update
diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index f1bb6c093..bda988eaa 100644
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,9 +1,28 @@
+Tue Aug 17 10:56:49 1999  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkentry.c (gtk_move_{forward,backward}_word): 
+	Prevent the trivial leak of information of allowing
+	word motion when the entry is not visible.
+
 Tue Aug 17 10:28:52 1999  Owen Taylor  <otaylor@redhat.com>
 
 	* gtk/gtkfilesel.c (gtk_file_selection_fileop_error): Propagate
 	modality to error dialog as well as confirmation dialogs.
 	(Bug #1803, reported by Rosanna Wing Sze Yuen)
 
+Thu Aug  5 17:05:39 1999  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkrc.c (gtk_rc_clear_styles): Don't call gtk_rc_init()
+	here since that will the default files to be parsed again.
+	Instead, recreate rc_style_ht upon demand.
+
+	* gtk/gtkrc.c: Fix problem where RC styles that were freed 
+	would be left in realized_style_ht, resulting in
+	lookups that returned stale data.
+
+	* gtk/gtkrc.c (gtk_rc_style_unref): Code style cleanups.
+	Create a GtkRcStylePrivate structure in the GDK style.
+
 Wed Aug 11 13:38:26 BST 1999 Tony Gale  <gale@gtk.org>
 
 	* docs/gtkfaq.sgml: FAQ Update
diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index f1bb6c093..bda988eaa 100644
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,9 +1,28 @@
+Tue Aug 17 10:56:49 1999  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkentry.c (gtk_move_{forward,backward}_word): 
+	Prevent the trivial leak of information of allowing
+	word motion when the entry is not visible.
+
 Tue Aug 17 10:28:52 1999  Owen Taylor  <otaylor@redhat.com>
 
 	* gtk/gtkfilesel.c (gtk_file_selection_fileop_error): Propagate
 	modality to error dialog as well as confirmation dialogs.
 	(Bug #1803, reported by Rosanna Wing Sze Yuen)
 
+Thu Aug  5 17:05:39 1999  Owen Taylor  <otaylor@redhat.com>
+
+	* gtk/gtkrc.c (gtk_rc_clear_styles): Don't call gtk_rc_init()
+	here since that will the default files to be parsed again.
+	Instead, recreate rc_style_ht upon demand.
+
+	* gtk/gtkrc.c: Fix problem where RC styles that were freed 
+	would be left in realized_style_ht, resulting in
+	lookups that returned stale data.
+
+	* gtk/gtkrc.c (gtk_rc_style_unref): Code style cleanups.
+	Create a GtkRcStylePrivate structure in the GDK style.
+
 Wed Aug 11 13:38:26 BST 1999 Tony Gale  <gale@gtk.org>
 
 	* docs/gtkfaq.sgml: FAQ Update
diff --git a/gtk/gtkentry.c b/gtk/gtkentry.c
index 9e4cf7350..b6a93b1f8 100644
--- a/gtk/gtkentry.c
+++ b/gtk/gtkentry.c
@@ -1952,6 +1952,13 @@ gtk_move_forward_word (GtkEntry *entry)
 
   editable = GTK_EDITABLE (entry);
 
+  /* Prevent any leak of information */
+  if (!editable->visible)
+    {
+      editable->current_pos = entry->text_length;
+      return;
+    }
+
   if (entry->text && (editable->current_pos < entry->text_length))
     {
       text = entry->text;
@@ -1983,6 +1990,13 @@ gtk_move_backward_word (GtkEntry *entry)
 
   editable = GTK_EDITABLE (entry);
 
+  /* Prevent any leak of information */
+  if (!editable->visible)
+    {
+      editable->current_pos = 0;
+      return;
+    }
+
   if (entry->text && editable->current_pos > 0)
     {
       text = entry->text;