return FALSE, (gtk_tree_store_finalize): use g_node_traverse instead of

Fri Jul 26 21:39:21 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreestore.c (node_free): return FALSE,
        (gtk_tree_store_finalize): use g_node_traverse instead of
        g_node_children_foreach, so the whole tree will be freed (#88854,
        patch from Emmanuel Briot).

7 files changed, 46 insertions, 2 deletions

diff --git a/ChangeLog b/ChangeLog
index 8c80aa20a..de4d83589 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+Fri Jul 26 21:39:21 2002  Kristian Rietveld  <kris@gtk.org>
+
+	* gtk/gtktreestore.c (node_free): return FALSE,
+	(gtk_tree_store_finalize): use g_node_traverse instead of
+	g_node_children_foreach, so the whole tree will be freed (#88854,
+	patch from Emmanuel Briot).
+
 Fri Jul 26 21:24:03 2002  Kristian Rietveld  <kris@gtk.org>
 
 	* gtk/gtktreeview.c (gtk_tree_view_button_press): fix some memleaks,
diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 8c80aa20a..de4d83589 100644
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,10 @@
+Fri Jul 26 21:39:21 2002  Kristian Rietveld  <kris@gtk.org>
+
+	* gtk/gtktreestore.c (node_free): return FALSE,
+	(gtk_tree_store_finalize): use g_node_traverse instead of
+	g_node_children_foreach, so the whole tree will be freed (#88854,
+	patch from Emmanuel Briot).
+
 Fri Jul 26 21:24:03 2002  Kristian Rietveld  <kris@gtk.org>
 
 	* gtk/gtktreeview.c (gtk_tree_view_button_press): fix some memleaks,
diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2
index 8c80aa20a..de4d83589 100644
--- a/ChangeLog.pre-2-2
+++ b/ChangeLog.pre-2-2
@@ -1,3 +1,10 @@
+Fri Jul 26 21:39:21 2002  Kristian Rietveld  <kris@gtk.org>
+
+	* gtk/gtktreestore.c (node_free): return FALSE,
+	(gtk_tree_store_finalize): use g_node_traverse instead of
+	g_node_children_foreach, so the whole tree will be freed (#88854,
+	patch from Emmanuel Briot).
+
 Fri Jul 26 21:24:03 2002  Kristian Rietveld  <kris@gtk.org>
 
 	* gtk/gtktreeview.c (gtk_tree_view_button_press): fix some memleaks,
diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index 8c80aa20a..de4d83589 100644
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -1,3 +1,10 @@
+Fri Jul 26 21:39:21 2002  Kristian Rietveld  <kris@gtk.org>
+
+	* gtk/gtktreestore.c (node_free): return FALSE,
+	(gtk_tree_store_finalize): use g_node_traverse instead of
+	g_node_children_foreach, so the whole tree will be freed (#88854,
+	patch from Emmanuel Briot).
+
 Fri Jul 26 21:24:03 2002  Kristian Rietveld  <kris@gtk.org>
 
 	* gtk/gtktreeview.c (gtk_tree_view_button_press): fix some memleaks,
diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index 8c80aa20a..de4d83589 100644
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,10 @@
+Fri Jul 26 21:39:21 2002  Kristian Rietveld  <kris@gtk.org>
+
+	* gtk/gtktreestore.c (node_free): return FALSE,
+	(gtk_tree_store_finalize): use g_node_traverse instead of
+	g_node_children_foreach, so the whole tree will be freed (#88854,
+	patch from Emmanuel Briot).
+
 Fri Jul 26 21:24:03 2002  Kristian Rietveld  <kris@gtk.org>
 
 	* gtk/gtktreeview.c (gtk_tree_view_button_press): fix some memleaks,
diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index 8c80aa20a..de4d83589 100644
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,10 @@
+Fri Jul 26 21:39:21 2002  Kristian Rietveld  <kris@gtk.org>
+
+	* gtk/gtktreestore.c (node_free): return FALSE,
+	(gtk_tree_store_finalize): use g_node_traverse instead of
+	g_node_children_foreach, so the whole tree will be freed (#88854,
+	patch from Emmanuel Briot).
+
 Fri Jul 26 21:24:03 2002  Kristian Rietveld  <kris@gtk.org>
 
 	* gtk/gtktreeview.c (gtk_tree_view_button_press): fix some memleaks,
diff --git a/gtk/gtktreestore.c b/gtk/gtktreestore.c
index 90d139e67..9a95be74d 100644
--- a/gtk/gtktreestore.c
+++ b/gtk/gtktreestore.c
@@ -433,10 +433,11 @@ gtk_tree_store_set_column_type (GtkTreeStore *tree_store,
   tree_store->column_headers[column] = type;
 }
 
-static void
+static gboolean
 node_free (GNode *node, gpointer data)
 {
   _gtk_tree_data_list_free (node->data, (GType*)data);
+  return FALSE;
 }
 
 static void
@@ -444,7 +445,8 @@ gtk_tree_store_finalize (GObject *object)
 {
   GtkTreeStore *tree_store = GTK_TREE_STORE (object);
 
-  g_node_children_foreach (tree_store->root, G_TRAVERSE_ALL, node_free, tree_store->column_headers);
+  g_node_traverse (tree_store->root, G_POST_ORDER, G_TRAVERSE_ALL, -1,
+		   node_free, tree_store->column_headers);
   _gtk_tree_data_list_header_free (tree_store->sort_list);
   g_free (tree_store->column_headers);