Use the canonical form of signal names after "notify::". Otherwise, no

Sat Jul 31 01:13:01 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkwindow.c:
	* gtk/gtkentry.c:
	* gtk/gtkaction.c: Use the canonical form of signal names
	after "notify::". Otherwise, no notification arrives.
	GObject should have a warning for that, really.  (#148879,
	Lorenzo Gil Sánchez)

7 files changed, 47 insertions, 11 deletions

diff --git a/ChangeLog b/ChangeLog
index 3ee7b93fa..6659c13ff 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+Sat Jul 31 01:13:01 2004  Matthias Clasen  <maclas@gmx.de>
+
+	* gtk/gtkwindow.c: 
+	* gtk/gtkentry.c: 
+	* gtk/gtkaction.c: Use the canonical form of signal names 
+	after "notify::". Otherwise, no notification arrives. 
+	GObject should have a warning for that, really.  (#148879, 
+	Lorenzo Gil Sánchez)
+
 Sat Jul 31 00:42:08 2004  Matthias Clasen  <maclas@gmx.de>
 
 	* gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_below): 
diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 3ee7b93fa..6659c13ff 100644
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,12 @@
+Sat Jul 31 01:13:01 2004  Matthias Clasen  <maclas@gmx.de>
+
+	* gtk/gtkwindow.c: 
+	* gtk/gtkentry.c: 
+	* gtk/gtkaction.c: Use the canonical form of signal names 
+	after "notify::". Otherwise, no notification arrives. 
+	GObject should have a warning for that, really.  (#148879, 
+	Lorenzo Gil Sánchez)
+
 Sat Jul 31 00:42:08 2004  Matthias Clasen  <maclas@gmx.de>
 
 	* gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_below): 
diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index 3ee7b93fa..6659c13ff 100644
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,12 @@
+Sat Jul 31 01:13:01 2004  Matthias Clasen  <maclas@gmx.de>
+
+	* gtk/gtkwindow.c: 
+	* gtk/gtkentry.c: 
+	* gtk/gtkaction.c: Use the canonical form of signal names 
+	after "notify::". Otherwise, no notification arrives. 
+	GObject should have a warning for that, really.  (#148879, 
+	Lorenzo Gil Sánchez)
+
 Sat Jul 31 00:42:08 2004  Matthias Clasen  <maclas@gmx.de>
 
 	* gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_below): 
diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index 3ee7b93fa..6659c13ff 100644
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,12 @@
+Sat Jul 31 01:13:01 2004  Matthias Clasen  <maclas@gmx.de>
+
+	* gtk/gtkwindow.c: 
+	* gtk/gtkentry.c: 
+	* gtk/gtkaction.c: Use the canonical form of signal names 
+	after "notify::". Otherwise, no notification arrives. 
+	GObject should have a warning for that, really.  (#148879, 
+	Lorenzo Gil Sánchez)
+
 Sat Jul 31 00:42:08 2004  Matthias Clasen  <maclas@gmx.de>
 
 	* gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_below): 
diff --git a/gtk/gtkaction.c b/gtk/gtkaction.c
index 5ab6e5789..0bdc4b811 100644
--- a/gtk/gtkaction.c
+++ b/gtk/gtkaction.c
@@ -822,7 +822,7 @@ connect_proxy (GtkAction     *action,
 	    }
 	  gtk_image_set_from_stock (GTK_IMAGE (image),
 				    action->private_data->stock_id, GTK_ICON_SIZE_MENU);
-	  g_signal_connect_object (action, "notify::stock_id",
+	  g_signal_connect_object (action, "notify::stock-id",
 				   G_CALLBACK (gtk_action_sync_stock_id),
 				   proxy, 0);
 	}
@@ -845,13 +845,13 @@ connect_proxy (GtkAction     *action,
       /* FIXME: we should set the tooltip here, but the current api
        * doesn't allow it before the item is added to a toolbar. 
        */
-      g_signal_connect_object (action, "notify::visible_horizontal",
+      g_signal_connect_object (action, "notify::visible-horizontal",
 			       G_CALLBACK (gtk_action_sync_property), 
 			       proxy, 0);
-      g_signal_connect_object (action, "notify::visible_vertical",
+      g_signal_connect_object (action, "notify::visible-vertical",
 			       G_CALLBACK (gtk_action_sync_property), 
 			       proxy, 0);
-      g_signal_connect_object (action, "notify::is_important",
+      g_signal_connect_object (action, "notify::is-important",
 			       G_CALLBACK (gtk_action_sync_property), 
 			       proxy, 0);
       g_signal_connect_object (action, "notify::tooltip",
@@ -873,10 +873,10 @@ connect_proxy (GtkAction     *action,
 	  /* FIXME: we should set the tooltip here, but the current api
 	   * doesn't allow it before the item is added to a toolbar. 
 	   */
-	  g_signal_connect_object (action, "notify::short_label",
+	  g_signal_connect_object (action, "notify::short-label",
 				   G_CALLBACK (gtk_action_sync_short_label),
 				   proxy, 0);      
-	  g_signal_connect_object (action, "notify::stock_id",
+	  g_signal_connect_object (action, "notify::stock-id",
 				   G_CALLBACK (gtk_action_sync_property), 
 				   proxy, 0);
       g_signal_connect_object (proxy, "clicked",
@@ -893,7 +893,7 @@ connect_proxy (GtkAction     *action,
 		    "label", action->private_data->short_label,
 		    "use_underline", TRUE,
 		    NULL);
-      g_signal_connect_object (action, "notify::short_label",
+      g_signal_connect_object (action, "notify::short-label",
 			       G_CALLBACK (gtk_action_sync_short_label),
 			       proxy, 0);
       
diff --git a/gtk/gtkentry.c b/gtk/gtkentry.c
index fb99137f1..8351a74c8 100644
--- a/gtk/gtkentry.c
+++ b/gtk/gtkentry.c
@@ -4115,7 +4115,7 @@ gtk_entry_text_index_to_layout_index (GtkEntry *entry,
  * is clicked.
  * 
  * Note that as the user scrolls around in the entry the offsets will
- * change; you'll need to connect to the "notify::scroll_offset"
+ * change; you'll need to connect to the "notify::scroll-offset"
  * signal to track this. Remember when using the #PangoLayout
  * functions you need to convert to and from pixels using
  * PANGO_PIXELS() or #PANGO_SCALE.
@@ -5134,9 +5134,9 @@ connect_completion_signals (GtkEntry           *entry,
       g_signal_connect (entry, "focus_out_event",
 			G_CALLBACK (accept_completion_callback), completion);
     }
-  g_signal_connect (completion, "notify::popup_completion",
+  g_signal_connect (completion, "notify::popup-completion",
 		    G_CALLBACK (completion_changed), entry);
-  g_signal_connect (completion, "notify::inline_completion",
+  g_signal_connect (completion, "notify::inline-completion",
 		    G_CALLBACK (completion_changed), entry);
 }
 
diff --git a/gtk/gtkwindow.c b/gtk/gtkwindow.c
index a6b9c30bf..7e2d4ad74 100644
--- a/gtk/gtkwindow.c
+++ b/gtk/gtkwindow.c
@@ -2869,7 +2869,7 @@ gtk_window_set_icon_list (GtkWindow  *window,
 
   /* We could try to update our transient children, but I don't think
    * it's really worth it. If we did it, the best way would probably
-   * be to have children connect to notify::icon_list
+   * be to have children connect to notify::icon-list
    */
 }