diff options
author | Emmanuele Bassi <ebassi@gnome.org> | 2020-04-01 18:11:55 +0100 |
---|---|---|
committer | Emmanuele Bassi <ebassi@gmail.com> | 2020-04-02 14:57:03 +0000 |
commit | 086e8adf4cc352cd11572f96066b001b545f354e (patch) | |
tree | 6fe2bfaf397c9fbe432cc3a778f8945d7a2426b9 /gdk-pixbuf | |
parent | 1f390c595014cf3fb77113544a21acf0fdcf5c30 (diff) | |
download | gdk-pixbuf-086e8adf4cc352cd11572f96066b001b545f354e.tar.gz |
Check the memset length argument
Avoid overflows by using the checked multiplication macro for gsize.
Fixes: #132
Diffstat (limited to 'gdk-pixbuf')
-rw-r--r-- | gdk-pixbuf/io-gif-animation.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/gdk-pixbuf/io-gif-animation.c b/gdk-pixbuf/io-gif-animation.c index c9db3c66e..49674fd2e 100644 --- a/gdk-pixbuf/io-gif-animation.c +++ b/gdk-pixbuf/io-gif-animation.c @@ -412,11 +412,15 @@ gdk_pixbuf_gif_anim_iter_get_pixbuf (GdkPixbufAnimationIter *anim_iter) /* If no rendered frame, render the first frame */ if (anim->last_frame == NULL) { + gsize len = 0; if (anim->last_frame_data == NULL) anim->last_frame_data = gdk_pixbuf_new (GDK_COLORSPACE_RGB, TRUE, 8, anim->width, anim->height); if (anim->last_frame_data == NULL) return NULL; - memset (gdk_pixbuf_get_pixels (anim->last_frame_data), 0, gdk_pixbuf_get_rowstride (anim->last_frame_data) * anim->height); + if (g_size_checked_mul (&len, gdk_pixbuf_get_rowstride (anim->last_frame_data), anim->height)) + memset (gdk_pixbuf_get_pixels (anim->last_frame_data), 0, len); + else + return NULL; composite_frame (anim, g_list_nth_data (anim->frames, 0)); } |