summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorLudovico de Nittis <aasonykk@gmail.com>2017-03-19 16:11:13 +0100
committerBastien Nocera <hadess@hadess.net>2017-07-13 18:57:16 +0200
commit31a6cff3dfc6944aad4612a9668b8ad39122e48b (patch)
tree33f5b605fb750799a6c4fb32acba6f11c867c374 /tests
parenteb0754b706e80d40c87b7de79a5031a5f2083a65 (diff)
downloadgdk-pixbuf-31a6cff3dfc6944aad4612a9668b8ad39122e48b.tar.gz
tiff: Check for integer overflows in multiplication
The checks currently in use are not sufficient, because they depend on undefined behaviour: rowstride = width * 4; if (rowstride / 4 != width) { /* overflow */ If the multiplication has already overflowed, the compiler may decide to optimize the if out and thus we do not handle the erroneous case. Rearrange the checks to avoid the undefined behaviour. Note that gcc doesn't seem to be impacted, though a defined behaviour is obviously preferred. CVE-2017-2870 https://bugzilla.gnome.org/show_bug.cgi?id=780269
Diffstat (limited to 'tests')
0 files changed, 0 insertions, 0 deletions