| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
It doesn't work.
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Include pixbuf loader API in the gir file
Closes #167
See merge request GNOME/gdk-pixbuf!97
|
| | |
|
|/ |
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| | |
Run GIF tests again, and fix regression for short reads
See merge request GNOME/gdk-pixbuf!95
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is conceptually similar to commit 2fd7d21f "tests: Fix GIF tests
being permanently disabled". One way or another, gdk-pixbuf always
supports these two formats: on Windows with the native gdiplus loader
enabled, it covers these two formats; otherwise, format-specific loaders
are used.
This means we will run the GIF tests, as intended.
Fixes: 7f0b214a "tests: Conditionally build and run tests"
Signed-off-by: Simon McVittie <smcv@debian.org>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As documented in the introductory comment, the interface of the various
functions in the GIF loader is that they read all the bytes they need,
or return -1 if not enough are available. Since commit
5212d69f "gif: Replace old buffer management code with GByteArray",
the incremental loader strictly depends on that assumption.
Unfortunately, gif_init() didn't conform to that interface. If there
were enough bytes available for the GIF signature (GIF87a or GIF89a)
but not enough bytes for the screen descriptor, it would return -1
having already consumed the first 6 bytes of the stream. A subsequent
retry with more data available would start from the beginning of the
screen descriptor, and immediately raise an error because the screen
descriptor is extremely unlikely to start with another copy of the
"GIF8" magic number.
The regression test tests/pixbuf-short-gif-write.c would have detected
this, but was accidentally disabled by commit 7f0b214a "tests:
Conditionally build and run tests".
This seems most easily fixed by reading the whole of the 13-byte
fixed-length header in one go. Adjust the offsets into the buffer
used to parse the screen descriptor accordingly.
Signed-off-by: Simon McVittie <smcv@debian.org>
|
| |
| |
| |
| |
| |
| |
| |
| | |
The skipping prevented the executable from being installed but not the .test file that referenced it.
This caused installed tests to fail:
Running test: gdk-pixbuf/pixbuf-pixdata.test
Caught exception during testing: Failed to execute child process ?/nix/store/kqmj2776mw24qxyswfbqlmybpws4g4yn-gdk-pixbuf-2.42.0-installedTests/libexec/installed-tests/gdk-pixbuf/pixbuf-pixdata? (No such file or directory)
|
| | |
|
|\ \
| |/
|/|
| |
| | |
tests: Fix some memory leaks
See merge request GNOME/gdk-pixbuf!96
|
|/
|
|
|
|
|
|
|
| |
This is enough to make many of the tests pass under gcc's
AddressSanitizer. pixbuf-randomly-modified still fails when it cannot
allocate more memory, and pixbuf-fail fails with memory allocation
errors unless run with ASAN_OPTIONS=allocator_may_return_null=1.
Signed-off-by: Simon McVittie <smcv@debian.org>
|
|\
| |
| |
| |
| | |
Make enum GType registration thread safe
See merge request GNOME/gdk-pixbuf!93
|
| |
| |
| |
| |
| | |
Use g_once_init_enter/leave to ensure that enumeration types can be
registered across threads.
|
| | |
|
|/ |
|
|\
| |
| |
| |
| |
| |
| | |
gif: Fix LZW decoder accepting invalid LZW code.
Closes #164
See merge request GNOME/gdk-pixbuf!92
|
|/
|
|
|
|
|
|
|
| |
The code value after a reset wasn't being validated, which means we would
accept invalid codes. This could cause an infinite loop in the decoder.
Fixes CVE-2020-29385
Fixes https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/issues/164
|
|
|
|
| |
(cherry picked from commit 9091fb987760b01e613f6691b38aef7b4387b5de)
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
gif: Fix GIF images without a Graphic Control Extension rendering colour 0 as the background.
Closes #162
See merge request GNOME/gdk-pixbuf!91
|
| |
| |
| |
| | |
GIF support is always built in.
|
| |
| |
| |
| | |
The former can be disabled at build time.
|
| | |
|
| |
| |
| |
| | |
Regression introduced in e3adcf0c86dbd56b01d0d55f29a95065cbd95eb8.
|
| |
| |
| |
| |
| |
| |
| |
| | |
as the background.
This was a regression introduced in 5212d69f2362f9b68ccf9385277e5c4a744b2187.
Fixes https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/issues/162
|
| | |
|
|/ |
|
| |
|
| |
|
|\
| |
| |
| |
| | |
Rough pass at making the static analysis tool happy
See merge request GNOME/gdk-pixbuf!89
|
| |
| |
| |
| | |
We especially want the indentation width to be 8 spaces, not 2.
|
| |
| |
| |
| | |
We must handle the error path, where the out argument isn't set.
|
| | |
|
|/
|
|
|
| |
Iterate over the key/value arrays once, using GArray to store the text
chunks after validating the keys.
|
|\
| |
| |
| |
| | |
ci: Add analysis stage to the pipeline
See merge request GNOME/gdk-pixbuf!88
|
|/
|
|
| |
Run a static analysis and an ASan jobs on the gdk-pixbuf code base.
|
|\
| |
| |
| |
| | |
Ci update
See merge request GNOME/gdk-pixbuf!87
|
| |
| |
| |
| | |
Use it to generate the release artefacts.
|
| | |
|
| |
| |
| |
| | |
Make at least an attempt at a consistent coding style.
|
| | |
|
| |
| |
| |
| | |
Use common environment variables for the various jobs.
|
| | |
|
| |
| |
| |
| | |
Use the version from GTK, which is much more ergonomic.
|