| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
We need to go through an intermediate script in order to generate the
thumbnailer's desktop file.
|
|
|
|
|
|
|
|
| |
If the loader returns a NULL pixbuf without returning an
error, the skeleton would crash trying to print the error.
Print that the thumbnailer is broken instead.
https://bugzilla.gnome.org/show_bug.cgi?id=778204
|
|
|
|
|
|
|
|
| |
Because we weren't waiting for loaders.cache to be created to run our
helper, and we weren't applying the environment variables to the correct
helper, we would end up with a broken list of supported MimeTypes.
https://bugzilla.gnome.org/show_bug.cgi?id=778451
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://github.com/hadess/gnome-thumbnailer-skeleton/commits/master
Add some assertions to help Coverity
From looking at the code, these assertions should always hold already,
but it clarifies the code and helps static analysis if we add them
explicitly.
(n_pixels == 0) is only true if (s_x1 == s_x2 || s_y1 == s_y2), which is
only true if (dx == 0 || dy == 0). This cannot be true, because dx and
dy are the result of dividing source_[width|height] by
dest_[width|height], and there’s already an assertion that the former
are greater or equal to the latter.
Coverity CID: 1388528
https://bugzilla.gnome.org/show_bug.cgi?id=776990
|
|
|
|
|
|
|
|
|
|
|
| |
https://github.com/hadess/gnome-thumbnailer-skeleton/commits/master
Add version checks around g_type_init() call
g_type_init() was deprecated (made unnecessary) in GLib 2.36.0, so don’t
call it if we are compiled against a new enough version of GLib.
https://bugzilla.gnome.org/show_bug.cgi?id=777315
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 6afda9c removed the separate height and width arguments, as we
always want to keep the original image's aspect ratio. The cleanup
wasn't quite finished though, and ended up with slightly non-sensical
checks (like doing comparisons twice).
Coverity CID 1388524
https://bugzilla.gnome.org/show_bug.cgi?id=768062
|
|
|
|
|
|
|
| |
Fixes the build on Windows and elsewhere, where there's a filename
extension for executables
https://bugzilla.gnome.org/show_bug.cgi?id=776432
|
|
|
|
|
|
|
|
|
|
| |
In debug code on an error path: if the loader is not loaded due to
mime_type being NULL, no error is set; so dereferencing it is a bad
idea.
Coverity CID 1388530
https://bugzilla.gnome.org/show_bug.cgi?id=776026
|
|
|
|
| |
By updating the thumbnailer skeleton.
|
|
|
|
|
| |
When the image loading failed already, don't capture the error from
gdk_pixbuf_loader_close() to avoid a run-time warning.
|
| |
|
|
|
|
|
|
| |
As used in other parts of gdk-pixbuf.
https://bugzilla.gnome.org/show_bug.cgi?id=768062
|
|
|
|
|
|
|
|
| |
As we only get called for images, and that preview icons can also be
used for other data types handled natively by external devices, let the
caller handle those.
https://bugzilla.gnome.org/show_bug.cgi?id=768062
|
|
|
|
|
|
|
|
|
| |
Clean up _gdk_pixbuf_new_from_uri_at_scale() by:
- Always preserving the aspect ratio
- Using a single value for the target with/height
- Returning errors
https://bugzilla.gnome.org/show_bug.cgi?id=768062
|
|
So that broken images, or images that use too much RAM can get killed
without prejudice.
_gdk_pixbuf_new_from_uri_at_scale() and
gnome_desktop_thumbnail_scale_down_pixbuf () are directly from
gnome-desktop.
https://bugzilla.gnome.org/show_bug.cgi?id=768062
|