2005-11-15 Matthias Clasen * === Released 2.8.7 === * NEWS: Updates * gtk/gtktreestore.c (gtk_tree_store_move): Fix a memory leak. (#321032, Peter Zelezny) 2005-11-14 Matthias Clasen * gtk/gtkselection.c (gtk_selection_data_set_uris): Don't leak result. (#321441, Tommi Komulainen) 2005-11-14 Matthias Clasen * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): Don't crash if there is no builtin icon. 2005-11-13 Matthias Clasen * gdk/gdkcolor.c (gdk_color_parse): Documentation improvements. (#321338) * gtk/gtktextiter.c (gtk_text_iter_forward_search): Make limit an inclusive boundary. (#321299) * NEWS: Updates 2005-11-12 Matthias Clasen * gtk/gtkicontheme.c: Make it compile. 2005-11-12 Dom Lachowicz * modules/engines/ms-windows/msw_style.c: Bug #313627. Make win32 theme's handling of toolbars, handleboxes, and menubars more in-line with Microsoft's IE style. * modules/engines/ms-windows/*.c: Indentation cleanups 2005-11-12 Matthias Clasen Make builtin icons work in gtk_window_set_icon_name() (#321046, Maxim Udushlivy) * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): Also check builtin icons. 2005-11-12 Tor Lillqvist * gtk/gtkfilesystemwin32.c (filename_get_info): Don't hide dotfiles, no such convention on Win32. Just hide files with the hidden attribute. (#314627) 2005-11-11 Federico Mena Quintero Merged from HEAD: * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Only get the base path of the volume if it is mounted. 2005-11-10 Matthias Clasen * gtk/gtktreeview.c (gtk_tree_view_motion_resize_column): Remove another erroneous semicolon. * gdk/x11/gdkcolor-x11.c (gdkx_colormap_get): Remove an erroneous semicolon. Don't corrupt odd keymaps (#316638, Kean Johnston) * gdk/x11/gdkkeys-x11.c (set_symbol): Auxiliary function to handle frobbing keymaps with odd numbers of syms/code. * gdk/x11/gdkkeys-x11.c (update_keymaps): Use set_symbol() to frob the keymap. Improve navigation to parent folders. (#318444, Andrei Yurkevich) * gtk/gtkpathbar.[hc]: Add a child_path argument to the path_clicked signal. * gtk/gtkfilechooserdefault.c (path_bar_clicked): Select the child_path, if it is provided. * gtk/marshalers.list (path_bar_clicked): Add the necessary glue. * gtk/gtktreeview.c: Implement a getter for headers-clickable. (#163851, Richard Hult) 2005-11-09 Tor Lillqvist * gdk/win32/gdkwindow-win32.c (_gdk_win32_get_adjusted_client_rect): Remove this two-line function which was used only in one place. (get_outer_rect): Use _gdk_win32_adjust_client_rect(). (gdk_window_set_geometry_hints): If we have identical minimum and maximum size hints, remove the resize and maximize decorations/functions. (#104514) If we have a maximum size hint, remove the maximize decoration/function but ensure the resize decoration/function is available. Otherwise ensure both resize and maximize decorations/functions are there. (set_or_clear_style_bits): Factored out common code from gdk_window_set_decorations() and gdk_window_set_functions(). Hack the window style setting once more: Only touch the window style bits corresponding to the GdkWMDecoration or GdkWMFunction parameter bitmasks. Hopefully this finally is the correct thing to do. We used to clear all other bits than those that were being set, or set all other bits than those that were being cleared. Take into account that adding or removing decorations leaves the window's outer size unchanged, i.e., the client area's size and position change. This is apparently not what we want, so change also the window's (outer) position and size appropriately so that the client area's position and size stay constant. gtk-demo's color selector dialog is now non-resizable like on X11 (I tested with metacity in GNOME). Torn off menus are shrinkable vertically but have a maximum size, and are not maximizable or minimizable, like on X11. (gdk_window_set_decorations, gdk_window_set_functions): Let set_or_clear_decorations() do most of the job. * gdk/win32/gdkprivate-win32.h: Remove declaration of _gdk_win32_get_adjusted_client_rect(). 2005-11-09 Tor Lillqvist * gdk/win32/gdkwindow-win32.c: Remove unnecessary includes. (gdk_window_set_geometry_hints): Remove code that has been permanently ifdeffed out for two years. 2005-11-08 Matthias Clasen * gdk/gdkgc.c (gdk_gc_finalize): Unref tile and stipple when finalizing a gc. (#320789, Nickolay V. Shmyrev) * gdk/x11/gdkwindow-x11.c (gdk_window_set_icon_list): Ignore icons if they would make the request large enough to cause Xlib to loose the connection. (#320909, Claudio Saavedra) 2005-11-07 Matthias Clasen * gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't loose the bookmark label when reordering. (#320720, Jeremy Cook) * gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons. Don't grab focus when a slider button is pressed, instead, use a bit in the pathbar struct to determine whether to scroll up or down. (#314486, Carlos Garnacho) * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle Shift-G to go to the previous match, like firefox. (#320061, Christian Neumair) * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Don't popup the completions if the focus has already been moved somewhere else. (#319914, Christian Persch) * gtk/gtktoolitem.c (_gtk_tool_item_toolbar_reconfigured): Raise the drag_window after reconfiguring the toolbar. (#320803, Christian Persch) * gtk/gtkrbtree.c: Plug a small memory leak. (#320777, Antonio Sacchi) 2005-11-07 Tor Lillqvist * gdk/win32/gdkcursor-win32.c (pixbuf_to_hbitmaps_normal): Correct the calculation of maskstride. (#320152, Peter Zelezny) 2005-11-06 Tor Lillqvist * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in the Win32 backend, check that GdkDisplay* parameters are equal to _gdk_display instead of using the unnecessarily general GDK_IS_DISPLAY(). (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the color bitmap to have "color" in their name, for similarity with pixbuf_to_hbitmaps_normal(). Create an 1-bit mask bitmap (DIB section) using create_color_bitmap(), not CreateBitmap(). Initialize the mask bitmap with ones for those pixels in the color bitmap where the alpha is zero, zeros for other pixels. Although the docs claim otherwise, using an unitialized bitmap for the mask together with a color bitmap that has alpha did not work if the color bitmap had zero alpha everywhere, like the blank icon used in gtktrayicon.c. (_gdk_win32_pixbuf_to_hicon_supports_alpha): Check G_WIN32_IS_NT_BASED() first, so we can pretend being on Win9x by setting the G_WIN32_PRETEND_WIN9X environment variable. 2005-11-06 Tor Lillqvist Make icon masks work on Win98 (#320152, Peter Zelezny) * gdk/win32/gdkcursor-win32.c (create_color_bitmap): Take also a parameter for the depth of the bitmap, so that this function can be used to create 1-bit bitmaps, too. (pixbuf_to_hbitmaps_normal): Create an 1-bit bitmap for the mask, and initialize it properly. 2005-11-04 Michael Natterer Merged from HEAD: * gtk/gtkrc.c (gtk_rc_reparse_all_for_settings): applied patch from maemo-gtk that changes the mtime check for rc files from '>' to '!=', otherwise theme changes go unnoticed when turning back the clock (Tommi Komulainen). 2005-11-02 Tor Lillqvist * gdk/win32/gdkcolor-win32.c * gdk/win32/gdkscreen-win32.c * gdk/win32/gdkwindow-win32.c: Whitespace consistency fixes. Remove superfluous test for GdkWindow* parameters being non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one GdkScreen and one GdkDisplay in the Win32 backend, use those variables instead of the getter functions. For GdkDisplay* and GdkScreen* parameters, check that they are equal to the corresponding singleton variables instead of the more general GDK_IS_DISPLAY() or GDK_IS_SCREEN(). 2005-11-02 Matthias Clasen * gtk/gtktextview.c: Remove some g_return_if_fail() from static functions, replace some others by g_assert(). * gtk/gtktextview.c (selection_motion_event_handler) (gtk_text_view_start_selection_drag): Keep track of the original selection boundaries during a drag selection, in order to correctly decide when to extend or shrink the selection. (#320167, reported by Arvind S N, patch by Paolo Borelli) * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets): * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace manual offset calculations by g_utf8_offset_to_pointer(). (#320360, Paolo Borelli) 2005-11-01 Tor Lillqvist * gdk/win32/gdkprivate-win32.h * gdk/win32/gdkglobals-win32.c * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more pre-interned GdkAtoms and pre-registered clipboard formats. Sort their declarations, definitions and assignments into a more logical and consistent order. * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the CF_ prefix for the predefined clipboard format names. Put quotes around registered format names to distinguish them. * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return immediately with a warning if the property type is STRING, TEXT, COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we should never pretend to handle on Win32. Handle only UTF8_STRING here, other formats with delayed rendering. Use \uc1 instead of \uc0 when generating Rich Text Format for easier testability on XP, where WordPad misinterprets \uc0 encoded characters. Add more GDK_NOTE debugging output for Clipboard operations. * gdk/win32/gdkselection-win32.c: Debugging printout improvements. (gdk_selection_convert): Don't pretent to handle STRING, just UTF8_STRING. Streamline error handling, don't unnecessarily have a GError which then isn't used for anything anyway if it gets set. (gdk_win32_selection_add_targets): Skip also STRING, TEXT, COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING. * configure.in: Don't look for X_PACKAGES unless building for X11. (#313986, John Ehresman) 2005-10-28 Matthias Clasen * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup window to the toplevels window group. (#319912, Christian Persch) * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default drag cursors. (#319200, Federico Mena Quintero) * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle Shift-G to go to the previous match, like firefox. (#320061, Christian Neumair) * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little stars. (#319985, Bastien Nocera) * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson) 2005-10-27 Michael Natterer * gtk/gtkthemes.c (gtk_theme_engine_load): fix typo (G_MODUE_BIND_LAZY -> G_MODULE_BIND_LAZY). 2005-10-27 Michael Natterer Merged from HEAD: Fix bug #319974: * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property): make sure that setting any of pixbuf/stock-id/icon-name resets the others because they are mutually exclusive, and that unsetting any of them only resets the pixbuf and nothing else. Also added some missing g_object_notify(). (gtk_cell_renderer_pixbuf_get_property): simplified calls to g_value_set_object(). (gtk_cell_renderer_pixbuf_create_stock_pixbuf) (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added g_object_notify ("pixbuf"). 2005-10-27 Matthias Clasen * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more careful about initializing cell_area. (#319382, Tommi Komulainen) * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat Ctrl-PageUp/PageDown. (#318670, Christian Neumair) * demos/gtk-demo/clipboard.c (paste_received): Only set the text if it is not NULL. (#319930, Thomas Klausner) * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the loader before trying to get the pixbuf. (#319930, Thomas Klausner) 2005-10-26 Matthias Clasen * gtk/gtkfilesystem.c (gtk_file_system_module_load): * gtk/gtkthemes.c (gtk_theme_engine_load): * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY when dlopening modules. (#319557, Laszlo Peter) 2005-10-26 Matthias Clasen * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text segments when determining text direction. (#319065, Tommi Komulainen) * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash on duplicate destroy. (#318953, Gustavo Carneiro) * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog): Point out that destroy-with-parent is a bad idea for the dialog passed to this function. (#318943, Christian Persch) * gtk/gtkfilechooserbutton.c (open_dialog): Add the dialog to the window group, if necessary (#318943, Christian Persch) * */Makefile.am: use $(GLIB_MKENUMS) instead of glib-mkenums. (#318582, Damien Carbery) * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify docs. (#317682, Christian - Manny Calavera - Neumair) * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't seem to affect the placement of the data in the readonly section, and causes problems with some compilers. (#317844) 2005-10-25 Matthias Clasen * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action): Fix some issues with background drawing in RTL. (#318781, Eric Cazeaux) * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some more docs. (#319722, Paolo Borelli) * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the initialization of screen_x11->xft_rgba more explicit. (#319627, Bogdan Nicula) 2005-10-22 Michael Natterer Merged from HEAD: * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the widget being realized, in addition to being visible, to avoid running into precondition check in gtk_tree_view_get_cell_area(). (approved by Kris). 2005-10-22 Dom Lachowicz * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style): Experimentally, scrollbar steppers can shrink to 8 pixels on Win32. Reflect that in the theme. * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally, there is a 1-pixel border between a scrollbar and its child in ScrolledWindows on Win32. Reflect that in the theme. 2005-10-21 Matthias Clasen * gtk/gtkstock.c: Define GTK_STOCK_[DIS]CONNECT here, and not only in the header. String addition. (#318939, Richard Hult) 2005-10-20 Matthias Clasen * gtk/gtkiconview.c: Apply a patch from Ross Burton to fix compiler warnings. (#318762) 2005-10-19 Federico Mena Quintero Merged from HEAD: Fixes bug #317999: * tests/autotestfilechooser.c (test_button_folder_states_for_action): Test that we have either $cwd or the explicitly-set folder. (test_reload_sequence): Likewise. * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_get_current_folder): If our reload_state is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd. 2005-10-14 Tor Lillqvist * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code. It didn't really do anything useful, and was just confusing and incomplete. Comments claimed we don't do delayed rendering, but in fact we do, for images. (The delayed rendering code has other problems, though, see #168173.) The clipboard viewer code was probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate the message when necessary). It was just test code, it said so in a comment. Add something similar back later if necessary. (_win32_on_clipboard_change, _gdk_win32_register_clipboard_notification): Remove. (gdk_display_supports_selection_notification, gdk_display_request_selection_notification): Always just return FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere. 2005-10-13 Tor Lillqvist * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat Alt-Enter specially. It does not have any special meaning and should be passed on to the application. (#318378, Tim Evans) 2005-10-13 Tor Lillqvist Set visual depth to 24 for 32 bits-per-pixel devices on Win32. This allows gdk_drawable_real_draw_pixbuf() to use the optimized composite_0888() function rather than the slower image dithering functions to draw pixbufs (#313993, John Ehresman) * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use _gdk_windowing_get_bits_for_depth() to initialize GdkImage::bits_per_pixel. (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24. * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use _gdk_windowing_get_bits_for_depth() to initialize BITMAPINFOHEADER::biBitCount. * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns 32. 2005-10-12 Stefan Kost * demos/gtk-demo/appwindow.c: (about_cb): use PACKAGE_VERSION,bump year (#318654) 2005-10-11 Matthias Clasen * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off toggle here with the matching on toggle if it immediately follows. This is a common case, and handling it here prevents quadratic blowup in cleanup_line() below. (#317125) * gtk/gtktextsegment.h: * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass the character counts into this function instead of computing them again. 2005-10-07 Federico Mena Quintero Merged from HEAD: Fixes bug #317999: * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder): Clarify the documentation on when this can return NULL. (gtk_file_chooser_get_current_folder_uri): Likewise. * gtk/gtkfilechooserbutton.c (struct _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag; we use it to keep track of whether a folder has been set. (gtk_file_chooser_button_map): Implement. If no folder has been loaded before, we at least try to load $cwd here. (gtk_file_chooser_button_constructor): If the construct-time dialog already has a folder set, turn on our folder_has_been_set flag. (dialog_current_folder_changed_cb): Turn on our folder_has_been_set flag. 2005-10-07 Matthias Clasen * gtk/gtktexttag.c (gtk_text_attributes_ref): Use g_return_val_if_fail(), not g_return_if_fail(). (#318412, Kazuki Iwamoto) 2005-10-04 Federico Mena Quintero Merged from HEAD: * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and Desktop; just use their real names on the file system for the user-visible names. * gtk/gtkfilechooserdefault.c (shortcuts_append_home): Don't special-case the name of "Home"; just use the folder name. 2005-10-04 Tor Lillqvist * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann) 2005-10-04 Matthias Clasen * configure.in: Bump version * === Released 2.8.6 === * NEWS: Updates * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change from yesterday, since it leads to assertion failures. (#317879, Sebastian Bacher) 2005-10-03 Matthias Clasen * gtk/gtkcalendar.c (gtk_calendar_init): Call calendar_compute_days() after setting priv->week_start. 2005-10-03 Federico Mena Quintero Merged from HEAD: Don't reload the current folder unnecessarily on ::map(). * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent the reloading state. (struct _GtkFileChooserDefault): Added a "reload_state" field. * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Initialize impl->reload_state. (gtk_file_chooser_default_map): Check the impl->reload_state; load a default folder if no folder has been set, or reload the current one only if we had been unmapped first. (gtk_file_chooser_default_update_current_folder): Set the reload_state to RELOAD_HAS_FOLDER. (gtk_file_chooser_default_unmap): Implement, and set the reload_state to RELOAD_WAS_UNMAPPED. (shortcuts_model_create): Don't call shortcuts_add_bookmarks() here; they'll get (re)loaded on ::map() anyway. * gtk/gtkfilechooserwidget.c (gtk_file_chooser_widget_constructor): Don't set a default folder here. * tests/autotestfilechooser.c (test_action_widgets): Don't take in a dialog; build it ourselves. (test_reload): New test to ensure that we don't load the default folder more than once, and that we reload it when unmapping/remapping. (get_impl_from_dialog): New utility function. (test_widgets_for_current_action): Use get_impl_from_dialog(). 2005-10-03 Matthias Clasen * configure.in: Bump version * === Released 2.8.5 === * NEWS: Updates * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when removing it from the hash table. (#314696, Benjamin Berg) 2005-10-01 Tor Lillqvist * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause is that the the desktop isn't visible because the session has been switched, the screen is locked, or a terminal server session disconnected, so no error message necessary. (#137796) It is of course remotely possible that BitBlt() failing with ERROR_INVALID_HANDLE might also be caused by some other problem. We could strive for perfection and track whether the desktop is visible by using WTSRegisterSessionNotification() and handling WM_WTSESSION_CHANGE. I think that's overdoing it just for this issue, though. If we would track desktop visibility, we should then avoid even trying to update the display at all while the desktop isn't visible. 2005-09-30 Matthias Clasen * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt to correct the calculations for the first week day. We may just have to remove this code if too many locales turn out to have broken data. * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in some cases. (#317611, Tommi Komulainen) * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request): Prevent overflow when storing size hints in an unsigned short variable. Tracked down by Ray Strode and Søren Sandmann. 2005-09-29 Matthias Clasen * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491, Paolo Borelli) * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being grab shadowed. (#317332) 2005-09-29 Tor Lillqvist * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test. * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is passed to bindtextdomain() which isn't UTF-8-aware, so convert to system codepage using g_win32_locale_filename_from_utf8(). (#317457, Kazuki Iwamoto) 2005-09-28 Matthias Clasen * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms here. (#317039, Paolo Borelli) * gtk/gtktexttag.h: * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes to make this function work as boxed copy function. (#317455, Gustavo Carneiro) * gtk/gtkclipboard.c (request_image_received_func): Don't unref NULL. (#316828, Tor Lillqvist) 2005-09-28 Tor Lillqvist * modules/input/imime.c: Include . (#317444, Kazuki Iwamoto) 2005-09-27 Federico Mena Quintero Merged from HEAD: Do not create the save mode-specific widgets in the open modes, so that we don't carry their baggage around. * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_constructor): Don't create the save_widgets here. (save_widgets_create): Set the impl->save_widgets directly here, instead of passing the widgets back to the caller. Also, pack them into the impl's box. (update_appearance): Create or destroy the save widgets as appropriate. Set the action of the save_file_name_entry here. (shortcuts_add_current_folder): Set the active item in the save_folder_combo only if it exists. (gtk_file_chooser_default_set_property): Don't set the action of the save_file_name_entry here. (gtk_file_chooser_default_update_current_folder): Set the base folder of the save_file_name_entry only if the entry exists. (shortcuts_drag_data_received_cb): Cast the selection_data->data to (const char *) since that's what shortcuts_drop_uris() expects. (file_list_drag_data_received_cb): Likewise, for g_uri_list_extract_uris(). 2005-09-27 Federico Mena Quintero Merged from HEAD: * gtk/gtkfilechooserdefault.c (update_chooser_entry): If the selection is empty, clear the file name entry only if we are in CREATE_FOLDER mode. In SAVE mode, nothing will be selected when the user starts typeahead in the treeview, and we don't want to clear the file name entry in that case --- the user could be typing-ahead to look for a folder name. Fixes bug #308332, patch by Jürg Billeter. 2005-09-27 Matthias Clasen * configure.in: Bump version * === Released 2.8.4 === * NEWS: Updates * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup): Pop below the entry if there's more free space below the entry than above. (#316948, Tommi Komulainen) 2005-09-26 Tor Lillqvist * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set the shaped flag here, too. (#316871) (gdk_window_shape_combine_region): Currently unimplemented, so don't do anything to the shaped flag here. 2005-09-26 Matthias Clasen Fix #316871, reported by Dan Winship: * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag. * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask) (gdk_window_shape_combine_region): Set it here. * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't remove the child area for shaped windows. 2005-09-23 Matthias Clasen * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize): Don't leak expander pixbufs. (#316946, Tommi Komulainen) 2005-09-22 Matthias Clasen * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation for the grab-broken-event signal, noticed by Damon Chaplin. 2005-09-21 Tor Lillqvist * gdk/win32/gdkselection-win32.c (gdk_selection_convert, gdk_text_property_to_text_list_for_display, gdk_text_property_to_utf8_list_for_display, gdk_win32_selection_add_targets, _gdk_win32_selection_convert_to_dib): Free return value from gdk_atom_name(). (gdk_text_property_to_text_list_for_display): Drop GError variable that isn't actually used after being set. 2005-09-20 Tor Lillqvist * gdk/win32/gdkselection-win32.c (gdk_selection_owner_get_for_display): Do return the correct owner for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is a window GDK knows about). The reason to return NULL seems to have gone when in the fix for bug #163702 the artificial GDK_SELECTION_CLEAR event generation was removed from gdk_selection_send_notify_for_display(). Fixes bug #316552. 2005-09-19 Matthias Clasen * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data in multiple places to avoid segfaults if the index is out of range. (#316422, Guillaume Cottenceau) (gtk_icon_view_set_drag_dest_item): (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419, #316424, Guillaume Cottenceau) Fri Sep 16 14:00:20 2005 Tim Janik * gtk/gtkwindow.c: fix bug #316180. gtk_window_map_event(): new function to work around lost unmap requests. 2005-09-16 Tor Lillqvist * modules/engines/ms-windows/msw_style.c (draw_extension, draw_box_gap): Check whether the widget actually is a GtkNotebook before treating it as such. Drop some unneeded local variables, use parameter with same information instead. (#316412) 2005-09-14 Matthias Clasen * gtk/updateiconcache.c (foreach_remove_func): Fix a use-after-free bug. (#316256, Alexander Nedotsukov) 2005-09-13 Federico Mena Quintero * gtk/gtkfilechooserdefault.c: Turn off profiling for the stable branch (#undef PROFILE_FILE_CHOOSER). 2005-09-13 Matthias Clasen * gtk/gtkiconview.c (gtk_icon_view_class_init): (gtk_icon_view_get_dest_item_at_pos): Fix typos in the docs. (#316008, #316027, #316121, Guillaume Cottenceau) * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste mistake in the docs. (#315993, Guillaume Cottenceau) * tests/testentrycompletion.c (create_simple_completion_model): Add some strings containing multibyte characters. * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix): Fix prefix insertion for multibyte characters. (#316095, Tommi Komulainen) * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon): * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently return NULL if the widget is not realized. (#316023, Guillaume Cottenceau) 2005-09-09 Matthias Clasen * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event): Make drag reordering work properly for columns other than the first. (#315054, Dan Winship) * gtk/gtkfontbutton.c (gtk_font_button_update_font_info): Handle invalid fontnames better. (#315187, Ed Catmur) * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle invalid fontnames better. (#136926, Michael R. Walton) * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing): Use connect_after to connect to the focus_out event. This ensures that the entry has already stopped blinking by the time we emit the edited signal. (#315229, Thomas Leonard) * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set unsigned ints to -1. (#315481, Kjartan Maraas) * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative to week_1stday, not to Sunday. Gotta love the ISO 14652 guys... (#314473, Stanislav Brabec) * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document memory handling. (#314975, Torsten Schoenfeld) 2005-09-09 Tor Lillqvist * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the display name. There is only one GdkDisplay on Win32, and constructing the display name isn't entirely trivial, so cacheing is probably worth it. For instance GIMP calls this function a lot. (gdk_display_open): Call gdk_display_get_name() to prime the cached name. (gdk_display_get_n_screens, gdk_display_get_screen, gdk_display_get_default_screen): Verify parameter correctness like the X11 backend does. * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name): Return a freshly allocated string, as the API specifies. Fixes a heap corruption problem that caused random errors and crashes in GIMP, for instance. 2005-09-05 Matthias Clasen * gtk/gtkaction.c (connect_proxy): Set the label of a button if it has no child. (#315253, John Finlay) 2005-09-02 Matthias Clasen * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers on destroy to avoid problems when they are called on a destroyed widget. (#315135, John Cupitt) * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed, we still need to deliver the destroy event. (#314980, Chris Lahey) 2005-09-02 Alexander Larsson * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes), (shortcuts_activate_volume): Handle base_path being null in the rest of the cases (#310270) 2005-09-02 Tor Lillqvist * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of cursor position also in root window coordinates. Prune out superfluous WM_MOUSEMOVE events even earlier, based on root window coordinates. Windows sends WM_MOUSEMOVE messages after a new window has ben mapped below the cursor even if the mouse doesn't move. We used to generate GDK_MOTION_NOTIFY in these cases. This confused at least gtk_menu_motion_notify(). (#314995) * gtk/gtkintl.h: No need to include config.h here. It caused warnings about GTK_LOCALEDIR being redefined on Win32 when compiling files where gtkintl.h is included after gtkprivate.h (which #undefines and re-#defines GTK_LOCALEDIR on Win32). 2005-09-01 Matthias Clasen * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc typo. (#314921, Guillaume Cottenceau) 2005-08-31 Baris Cicek * configure.in: Added ku to ALL_LINGUAS 2005-08-29 Matthias Clasen * configure.in: Bump version * === Released 2.8.3 === * configure.in: Bump version * NEWS: Updates * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu was active. (#314298, Christian Persch, analysis by Mark McLoughlin) 2005-08-29 Matthias Clasen * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an accidentally leftover duplicate pixbuf creation. (#314700, Kjartan Maraas) * gtk/gtksettings.c (settings_update_cursor_theme): Don't leak the cursor theme name. (#314693, Kjartan Maraas) * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free state.children in all cases. (#313862, Kjartan Maraas) 2005-08-27 Matthias Clasen * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default value of the ui property. (#314532, Yong Wang) * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn when G_MAXLONG is passed as length. 2005-08-26 Matthias Clasen * gtk/updateiconcache.c: Add a separate --ignore-theme-index option to avoid overloading --force. (JP Rosevaar) * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized variable warning, pointed out by Colin Walters. (#314585) 2005-08-26 Tor Lillqvist * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging printouts. (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519) 2005-08-26 Matthias Clasen * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation of week_start. (#314473, JP Rosevaar) 2005-08-25 Thomas Fitzsimmons * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK lock. (#314533, Thomas Fitzsimmons) 2005-08-25 Matthias Clasen * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle NULL gracefully. (#314523, Ed Catmur) 2005-08-25 Owen Taylor * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme): Handle theme == NULL. 2005-08-25 Matthias Clasen * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget y offset into account when positioning the popup. (#314470, Christian Persch) 2005-08-25 Owen Taylor * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init as instance_init, not base_init! (#314452, Fix from Frederic Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1. rather than 1 for a negative flag value. 2005-08-24 Matthias Clasen * === Released 2.8.2 === * gtk/gtkclipboard.c (request_image_received_func): Use the correct callback for image/gif, and also try image/bmp. (#314086, Mark Wielaard) * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon): Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382, Sebastien Bacher) * NEWS: Updates * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font and cursor settings get propagated down to the screen initially. Pointed out by Frederic Crozat. * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client message if the screen is NULL. Noticed by Kjartan Maraas. 2005-08-24 Matthias Clasen * Bump version * === Released 2.8.1 === * NEWS: Updates 2005-08-24 Matthias Clasen * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect against lazy filterers which return values other than TRUE or FALSE from their visible func. (#314335) 2005-08-23 Owen Taylor Fix for #314004, reported by Michael Reinsch: * gdk/gdk.symbols: * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only() Add gdk_screen_get/set_resolution_libgtk_only() * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set the options for the screen on the newly created context. * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c: Move font options and dpi code from gtkwidget.c to gtksettings.c, set the font options on the screen. * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get the font options from the screen and set them on the context. 2005-08-23 Kristian Rietveld * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't bother inserting new rows in a level with a zero refcount and immediately free the level. (Fixes #312350, reported by Markku Vire). 2005-08-23 Matthias Clasen * gtk/updateiconcache.c: Complain when there is no index.theme file in the specified directory, unless --force is used. Also add an --index-only option to create caches without image data. * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a C99ism. (#314262, Robert Jeff Mitchell) 2005-08-22 Manish Singh * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload. * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles. 2005-08-22 Matthias Clasen * gtk/gtkwindow.c (gtk_window_client_event): * gtk/gtkicontheme.c (ensure_valid_themes) (_gtk_icon_theme_check_reload): Implement a clientmessage based scheme for makeing sure that all GTK+ applications notice if an icon theme has been updated. This should prevent multiple versions of an icon theme cache to be mapped in memory at the same time, which can cause excessive memory consumption. (#313156, Chris Lahey) 2005-08-22 Matthias Clasen * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note regarding icon theme changes. * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning pixbufs which are backed by the mmapped memory of an icon cache, increase the refcount of the icon cache, so that the memory is not munmapped away underneath the pixbuf upon icon theme changes. (#314170, Kjartan Maraas) * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order to link against Xext. (#314062) * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer overruns. (#314081, Hans Breuer) 2005-08-20 Matthias Clasen * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the returned layout must not be modified. Sat Aug 20 16:12:14 2005 Jonathan Blandford * gtk/gtktreeview.c (gtk_tree_view_set_model): clear scroll_to_path if the model changes. * gtk/gtkiconview.c: (gtk_icon_view_destroy), (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor), (gtk_icon_view_scroll_to_path): Handle scrolling to a path before we're realized, #312798 (gtk_icon_view_set_model): clear scroll_to_path if the model changes. 2005-08-20 Matthias Clasen * gtk/gtkrange.c (gtk_range_adjustment_changed) (gtk_range_adjustment_value_changed): Don't queue a draw if the layout has not changed. (#313991, Benjamin Berg) 2005-08-19 Matthias Clasen * gtk/gtktreeitem.c: Remove duplicate lines. (#313344, Benoit Carpentier) * modules/engines/ms-windows/msw_style.c (setup_system_styles): Fix a typo. * gtk/gtkfilechooserbutton.c (change_icon_theme) (model_add_special, model_add_special, model_add_volumes): Handle pixbuf being NULL without warnings. Also, don't leak pixbuf references when the icon theme is changed. * gtk/gtkmain.c (gtk_get_event_widget): Don't access the user data on destroyed windows, since at best it can be a stale pointer. (#313953, Robin Green) 2005-08-19 Matthias Clasen * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun. (#313900, Sebastien Bacher) * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return FALSE if the tree is empty. (#313891, Guillaume Cottenceau) * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display) (xdnd_read_actions, get_client_window_at_coords_recurse): Free data returned from XGetWindowProperty. * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window) Free data returned from XGetWindowProperty. (313867, Kjartan Maraas) * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free children in all cases. (#313862, Kjartan Maraas) * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs in the per-directory hash, even if they come from the icon cache. We tried to avoid that before, but as a result leaked icon data structs. (#313852, Kjartan Maraas) 2005-08-18 Matthias Clasen * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect signal handlers on destroy, not on finalize. (#313759, Brett Atoms) 2005-08-15 Owen Taylor * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config files for x11/xext. (Jonas Bonn) 2005-08-15 Tor Lillqvist * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout inside GTK_NOTE. 2005-08-15 Owen Taylor * configure.in: Fix have_base_pc / have_base_x_pc typo. * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes. (#313417, James Andrewartha) * configure.in: Add fontconfig to X_PACKAGES, since we use it for FcNameConstant(). (More of #313417) 2005-08-15 Matthias Clasen * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for modal dialogs, make sure to inherit the window group from the parent, since we don't inherit window groups across transient parents currently. (#312918, Christian Persch) * gtk/gtkmessagedialog.c (gtk_message_dialog_new): * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs. * gtk/gtkiconview.c (gtk_icon_view_select_path) (gtk_icon_view_scroll_to_path): Handle paths of depth 0 gracefully. (#312796, Jonathan Blandford) * tests/testtoolbar.c: Add some more tests for menu placement. * gtk/gtkmenutoolbutton.c (menu_position_func): * gtk/gtktoolbar.c (menu_position_func): Improve positioning of toolbutton menus and of the overflow menu. (#312937, #153870, Christian Persch, Paolo Borelli) 2005-08-15 Tor Lillqvist * gtk/updateiconcache.c: Use g_path_get_dirname() instead of the nonportable and dirname(). 2005-08-15 Matthias Clasen * gtk/gtksizegroup.c: Use object data to mark widgets and groups as visited, so that we avoid constant extra list traversals. Also allocate quarks in class_init. (#311618, Michael Natterer) * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the download location for the hicolor icon theme. (#313475, Olexiy Avramchenko) * gtk/gtkicontheme.c: Remove debug spew. 2005-08-15 Owen Taylor * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap): * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap): * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap): Handle pixmap == NULL when checking for a colormap. (Allin Cottrell). 2005-08-14 Matthias Clasen * gtk/updateiconcache.c: Store only one copy of the pixel data for symlinked icons. To achieve this, maintain a hashtable mapping pathnames to pixel data, and share the pixel data for all symlinks resolving to the same pathname. When writing out the image data, write out the pixel data only the first time it is met, and store the offset pointing to the first copy for use in all later cases. This reduces the size of the Bluecurve icon cache from 40 to 13MB. (#312972)