diff options
| author | Brian Cameron <brian.cameron@sun.com> | 2005-06-20 15:23:58 +0000 |
|---|---|---|
| committer | Brian Cameron <bcameron@src.gnome.org> | 2005-06-20 15:23:58 +0000 |
| commit | 0b32cd6fa605bf4fe47da18f88cba0c907e3a64e (patch) | |
| tree | ba4e529c47e730847c825b085e831c8f17dc761c | |
| parent | 927f1d4488e3e50d90b9741b7b7039217662f63d (diff) | |
| download | gdm-0b32cd6fa605bf4fe47da18f88cba0c907e3a64e.tar.gz | |
On 04/25, a change was made to move seteuid/setegid to before checking the
2005-06-20 Brian Cameron <brian.cameron@sun.com>
* daemon/slave.c: On 04/25, a change was made
to move seteuid/setegid to before checking
the existance of the user's $HOME id to fix
bug #301821. That patch added new seteuid/setegid
calls before the check, but didn't remove the
calls after the check. Calling these functions
twice is needless and was causing problems on
NetBSD (refer to bug #301821), so now removing
the needless second call. This fixes bug
#301821.
| -rw-r--r-- | ChangeLog | 13 | ||||
| -rw-r--r-- | daemon/slave.c | 8 |
2 files changed, 13 insertions, 8 deletions
@@ -1,3 +1,16 @@ +2005-06-20 Brian Cameron <brian.cameron@sun.com> + + * daemon/slave.c: On 04/25, a change was made + to move seteuid/setegid to before checking + the existance of the user's $HOME id to fix + bug #301821. That patch added new seteuid/setegid + calls before the check, but didn't remove the + calls after the check. Calling these functions + twice is needless and was causing problems on + NetBSD (refer to bug #301821), so now removing + the needless second call. This fixes bug + #301821. + 2005-06-17 Brian Cameron <brian.cameron@sun.com> * gui/gdmsetup.c: Fix Delete button sensitivity. diff --git a/daemon/slave.c b/daemon/slave.c index 64bcf61d..e3199546 100644 --- a/daemon/slave.c +++ b/daemon/slave.c @@ -4058,14 +4058,6 @@ gdm_slave_session_start (void) home_dir = pwent->pw_dir; } - if G_UNLIKELY (setegid (pwent->pw_gid) != 0 || - seteuid (pwent->pw_uid) != 0) { - gdm_error ("Cannot set effective user/group id"); - gdm_verify_cleanup (d); - session_started = FALSE; - return; - } - if G_LIKELY (home_dir_ok) { /* Sanity check on ~user/.dmrc */ usrcfgok = gdm_file_check ("gdm_slave_session_start", pwent->pw_uid, |