diff options
| author | Ray Strode <rstrode@redhat.com> | 2018-05-15 17:02:36 -0400 |
|---|---|---|
| committer | Ray Strode <rstrode@redhat.com> | 2018-05-17 10:10:28 -0400 |
| commit | 4085d689d138c42195fd299c4fc9f567e7961641 (patch) | |
| tree | 04ef21ecd7817fe1da5a522ad9a2691621b3b8b6 | |
| parent | b3cfe3025feb272040ab701cfdb800c07f7f4c50 (diff) | |
| download | gdm-4085d689d138c42195fd299c4fc9f567e7961641.tar.gz | |
libgdm: use g_object_unref instead of g_clear_object for weakrefs
At the moment we add a weakref on each proxy to the connection
object. For the _sync variant functions, When the weakref fires,
they call g_clear_object, clearing the connection, even if other
proxies still have a reference.
This commit changes that weak ref code to use g_object_unref instead.
https://bugzilla.gnome.org/show_bug.cgi?id=795940
| -rw-r--r-- | libgdm/gdm-client.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/libgdm/gdm-client.c b/libgdm/gdm-client.c index b5f35306..294f4f4d 100644 --- a/libgdm/gdm-client.c +++ b/libgdm/gdm-client.c @@ -824,8 +824,8 @@ gdm_client_get_user_verifier_sync (GdmClient *client, &client->priv->manager); g_object_weak_ref (G_OBJECT (client->priv->user_verifier), (GWeakNotify) - g_clear_object, - &client->priv->connection); + g_object_unref, + client->priv->connection); if (client->priv->enabled_extensions != NULL) { gboolean res; @@ -1194,8 +1194,8 @@ gdm_client_get_greeter_sync (GdmClient *client, &client->priv->manager); g_object_weak_ref (G_OBJECT (client->priv->greeter), (GWeakNotify) - g_clear_object, - &client->priv->connection); + g_object_unref, + client->priv->connection); query_for_timed_login_requested_signal (client->priv->greeter); } @@ -1378,8 +1378,8 @@ gdm_client_get_remote_greeter_sync (GdmClient *client, &client->priv->manager); g_object_weak_ref (G_OBJECT (client->priv->remote_greeter), (GWeakNotify) - g_clear_object, - &client->priv->connection); + g_object_unref, + client->priv->connection); } return client->priv->remote_greeter; @@ -1561,8 +1561,8 @@ gdm_client_get_chooser_sync (GdmClient *client, &client->priv->manager); g_object_weak_ref (G_OBJECT (client->priv->chooser), (GWeakNotify) - g_clear_object, - &client->priv->connection); + g_object_unref, + client->priv->connection); } return client->priv->chooser; |