whack some debug messages

Wed Jul 23 14:29:53 2003  George Lebl <jirka@5z.com>

	* gui/greeter/greeter.c: whack some debug messages

	* daemon/display.c, daemon/gdm.[ch], daemon/slave.c: open a pipe
	  for the internal message connection rather then using the fifo.
	  Use the fifo only as backup.  This way we 1) reduce damage gdm
	  user can cause 2) make things faster, no need to open
	  and close the fifo on disk 20 times for each login.

	* daemon/gdm.c: add close notifies for the main connections and
	  NULL the connection pointer when that happens

	* daemon/display.c, daemon/slave.c, daemon/server.c,
	  daemon/misc.[ch], daemon/errorgui.c: The close_all_descriptors
	  now takes 2 exception arguments, since we need to keep 2 fd's
	  open for slaves now.

	* daemon/gdm-net.c: fix gdm_connection_open_fd (some copy/paste
	  typos were present)

	* daemon/slave.c: don't run session_stop unless we already ran
	  session_start, and cleanup send_chosen_host to use gdm_slave_send,
	  also wrap the xioerror in gdm_in_signal as it could be

1 files changed, 18 insertions, 21 deletions

diff --git a/TODO b/TODO
index 4b709823..0329afb4 100644
--- a/TODO
+++ b/TODO
@@ -1,30 +1,27 @@
-DOCUMENTATION!
-DOCUMENTATION!
-DOCUMENTATION!
-
 Big TODO: Rewrite the slave to be based around a mainloop.  So that
-we don't have to do things directly from signal handlers.
-
-TODO things:
+we don't have to do things directly from signal handlers.  Some work has already
+been started by making the slave use select calls instead of waitpid.  This needs
+to be extended a bit.  The big issue is things that hang.  We need two things,
+some better general framework for things that hang and handling signals there 
+(see daemon/misc.c for solution when using gethostbyaddr in the main daemon).
+We also need some way to do something like "sleep(5)" with the mainloop nicely.
+We want the slave to still be very synchroneous, but just have some small handlers
+run from within the mainloop.  The one thing that will always cause trouble here
+is the XDMCP server pinging, I think in this case it would be sane to do the setjmp
+thing and just ignore the ping if a signal comes, not sure how this will play with
+the X stuff and if this would completely whack us out.  The other option is to have
+a separate "pinger process" but that seems to heavyweight.
+
+Small TODO things:
   - If we can't setup pam display user visible errors and not just syslog stuff
-  - handle kills of server not working correctly to be more robust
-    we must leave killing to the main daemon since that can more likely kill
-    the server.
-  - in the slave child handler check that restart greeter is done with euid
-    and all that set correctly
-  - in slave child handler check that the server dead stuff can actually wipe
-    cookies (it needs to have the uid of the user) (probably so)
 
 Languages should be read from available locales.  Look at source  for
 locale_config.  Currently the way we do things is utter shit.
 
-Old stuff probably irrelevant:
-  Finish gdmface.
-  Keyboard layout menu.
-
-native utmp/wtmp handling without sessreg
-
-xsri like logo functionality
+Perhaps stuff:
+ - Keyboard layout menu.
+ - native utmp/wtmp handling without sessreg
+ - xsri like logo functionality
 
 the photosetup proggie should be put into some sort of crapplet and there
 should be other settings in the crapplet as well.