diff options
| author | William Jon McCann <mccann@jhu.edu> | 2007-10-15 14:20:43 +0000 |
|---|---|---|
| committer | William Jon McCann <mccann@src.gnome.org> | 2007-10-15 14:20:43 +0000 |
| commit | f0491fe99ec8e012713d302ff4e3239a5af61fc5 (patch) | |
| tree | be048bfdec3135b0777ed5ffa242485cca9a8380 /common/gdm-address.h | |
| parent | 225d1bf9d3704e48a7e1d8ba2b6e109424bc5fca (diff) | |
| download | gdm-f0491fe99ec8e012713d302ff4e3239a5af61fc5.tar.gz | |
The function gdm_address_new_from_sockaddr_storage gets called in a fewPOST_SWITCH_TO_GOBJECT_BRANCH
2007-10-15 William Jon McCann <mccann@jhu.edu>
* common/gdm-address.c: (gdm_address_new_from_sockaddr),
(gdm_address_peek_local_list):
* common/gdm-address.h:
* daemon/gdm-xdmcp-display-factory.c: (do_bind),
(create_address_from_request), (decode_packet):
* gui/simple-chooser/gdm-host-chooser-widget.c: (decode_packet),
(find_broadcast_addresses), (add_hosts):
The function gdm_address_new_from_sockaddr_storage gets called in a
few places with socket addresses that aren't necessary
sockaddr_storage bytes big (all the places that call getaddrinfo).
This results in the memdup call in that function potentially copying
out of bounds bytes.
Patch from: Ray Strode <halfline@gmail.com>
svn path=/branches/mccann-gobject/; revision=5360
Diffstat (limited to 'common/gdm-address.h')
| -rw-r--r-- | common/gdm-address.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/common/gdm-address.h b/common/gdm-address.h index 2bebedbb..5a01f8fa 100644 --- a/common/gdm-address.h +++ b/common/gdm-address.h @@ -40,7 +40,8 @@ typedef struct _GdmAddress GdmAddress; GType gdm_address_get_type (void); -GdmAddress * gdm_address_new_from_sockaddr_storage (struct sockaddr_storage *ss); +GdmAddress * gdm_address_new_from_sockaddr (struct sockaddr *sa, + size_t size); int gdm_address_get_family_type (GdmAddress *address); struct sockaddr_storage *gdm_address_get_sockaddr_storage (GdmAddress *address); |