diff options
| author | Stef Walter <stefw@gnome.org> | 2012-08-16 10:21:47 +0200 |
|---|---|---|
| committer | Stef Walter <stefw@gnome.org> | 2012-08-16 21:39:30 +0200 |
| commit | 9dd54ca944dd6c37b1465b53bae75b32fef2bb39 (patch) | |
| tree | ce7d3130ea1f537bd3046843784125e0bdf93d3a /gui/libgdm | |
| parent | 4fc30b7b8275d34b4dff37fef9e01115f8978440 (diff) | |
| download | gdm-9dd54ca944dd6c37b1465b53bae75b32fef2bb39.tar.gz | |
Fix uses of uninitialized memory
* Most setters of a **error (such as g_set_error()
and g_propagate_error() require and check that the
GError pointer is NULL before setting).
* Fix cases where a GError pointer was not initialized
to NULL, and instead relied on the stack value that
happened to be present.
https://bugzilla.gnome.org/show_bug.cgi?id=681972
Diffstat (limited to 'gui/libgdm')
| -rw-r--r-- | gui/libgdm/gdm-client.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/gui/libgdm/gdm-client.c b/gui/libgdm/gdm-client.c index c1757c2c..4f173dab 100644 --- a/gui/libgdm/gdm-client.c +++ b/gui/libgdm/gdm-client.c @@ -145,7 +145,7 @@ on_user_verifier_proxy_created (GdmUserVerifier *user_verifier, GSimpleAsyncResult *operation_result) { - GError *error; + GError *error = NULL; if (!gdm_user_verifier_proxy_new_finish (result, &error)) { g_simple_async_result_take_error (operation_result, error); @@ -798,7 +798,7 @@ on_greeter_proxy_created (GdmGreeter *greeter, GSimpleAsyncResult *operation_result) { - GError *error; + GError *error = NULL; if (!gdm_greeter_proxy_new_finish (result, &error)) { g_simple_async_result_take_error (operation_result, error); @@ -989,7 +989,7 @@ on_remote_greeter_proxy_created (GdmRemoteGreeter *remote_greeter, GSimpleAsyncResult *operation_result) { - GError *error; + GError *error = NULL; if (!gdm_remote_greeter_proxy_new_finish (result, &error)) { g_simple_async_result_take_error (operation_result, error); @@ -1179,7 +1179,7 @@ on_chooser_proxy_created (GdmChooser *chooser, GSimpleAsyncResult *operation_result) { - GError *error; + GError *error = NULL; if (!gdm_chooser_proxy_new_finish (result, &error)) { g_simple_async_result_take_error (operation_result, error); |