diff options
Diffstat (limited to 'daemon')
-rw-r--r-- | daemon/gdm-wayland-session.c | 19 | ||||
-rw-r--r-- | daemon/gdm-x-session.c | 19 |
2 files changed, 29 insertions, 9 deletions
diff --git a/daemon/gdm-wayland-session.c b/daemon/gdm-wayland-session.c index efdb34e8..af796089 100644 --- a/daemon/gdm-wayland-session.c +++ b/daemon/gdm-wayland-session.c @@ -280,6 +280,11 @@ spawn_session (State *state, gboolean is_running = FALSE; int ret; char **argv = NULL; + static const char *session_variables[] = { "DISPLAY", + "XAUTHORITY", + "WAYLAND_DISPLAY", + "WAYLAND_SOCKET", + NULL }; g_debug ("Running wayland session"); @@ -313,18 +318,20 @@ spawn_session (State *state, g_subprocess_launcher_setenv (launcher, environment_entry[0], environment_entry[1], FALSE); } + + /* Don't allow session specific environment variables from earlier sessions to + * leak through */ + for (i = 0; session_variables[i] != NULL; i++) { + if (g_getenv (session_variables[i]) == NULL) { + g_subprocess_launcher_unsetenv (launcher, session_variables[i]); + } + } } if (state->bus_address != NULL) { g_subprocess_launcher_setenv (launcher, "DBUS_SESSION_BUS_ADDRESS", state->bus_address, TRUE); } - /* Don't allow session specific environment variables from earlier sessions to leak through */ - g_subprocess_launcher_unsetenv (launcher, "DISPLAY"); - g_subprocess_launcher_unsetenv (launcher, "XAUTHORITY"); - g_subprocess_launcher_unsetenv (launcher, "WAYLAND_DISPLAY"); - g_subprocess_launcher_unsetenv (launcher, "WAYLAND_SOCKET"); - subprocess = g_subprocess_launcher_spawnv (launcher, (const char * const *) argv, &error); diff --git a/daemon/gdm-x-session.c b/daemon/gdm-x-session.c index b919e6e9..b5c0d20c 100644 --- a/daemon/gdm-x-session.c +++ b/daemon/gdm-x-session.c @@ -605,14 +605,16 @@ spawn_session (State *state, GError *error = NULL; gboolean is_running = FALSE; const char *vt; + static const char *session_variables[] = { "DISPLAY", + "XAUTHORITY", + "WAYLAND_DISPLAY", + "WAYLAND_SOCKET", + NULL }; g_debug ("Running X session"); launcher = g_subprocess_launcher_new (G_SUBPROCESS_FLAGS_NONE); - g_subprocess_launcher_setenv (launcher, "DISPLAY", state->display_name, TRUE); - g_subprocess_launcher_setenv (launcher, "XAUTHORITY", state->auth_file, TRUE); - if (state->environment != NULL) { size_t i; @@ -631,8 +633,19 @@ spawn_session (State *state, g_subprocess_launcher_setenv (launcher, environment_entry[0], environment_entry[1], FALSE); } + + /* Don't allow session specific environment variables from earlier sessions to + * leak through */ + for (i = 0; session_variables[i] != NULL; i++) { + if (g_getenv (session_variables[i]) == NULL) { + g_subprocess_launcher_unsetenv (launcher, session_variables[i]); + } + } } + g_subprocess_launcher_setenv (launcher, "DISPLAY", state->display_name, TRUE); + g_subprocess_launcher_setenv (launcher, "XAUTHORITY", state->auth_file, TRUE); + if (state->bus_address != NULL) { g_subprocess_launcher_setenv (launcher, "DBUS_SESSION_BUS_ADDRESS", state->bus_address, TRUE); } |