| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| |
| |
| | |
libgdm: use g_autoptr to manage objects lifecycle
See merge request GNOME/gdm!3
|
| |/
|
|
|
| |
Using auto pointers allows to manage things in a cleaner way without having
to manually unref things before returning.
|
| |\
| |
| |
| |
| |
| |
| | |
daemon/gdm-session-record.c: open/close the utmp database
Closes #381
See merge request GNOME/gdm!1
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
| |
pututxline() was used without first opening the utxmp database and
without closing it, preventing the logout entry from being fully
committed.
This caused the number of logged-in users to increment after each login,
as logging out did not correctly remove the user login record from utmp.
This commit wraps pututxline() between setutxent() and endutxent(),
making sure that the login/logout operation are fully flushed.
Fixes #381
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Gdm client single connection getter
Closes #386
See merge request GNOME/gdm!2
|
| | | |
|
| | |
| |
| |
| |
| | |
There's no need to keep the manager connection address around, and
use autofree to clean it up
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Instead of using the hard-to-maintain shared pointer to the dbus connection
to the manager and reset it when the proxies that use it are deleted, just
look which proxy is currently available and try to reuse the connection
from it.
Fixes #386
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Both if we re-use the shared connection in `gdm_client_get_connection` and if
we create a new one in `on_connected`, we steal the pointer here by using
`g_task_propagate_pointer` and thus we don't have to add an additional
reference to this connection when returning, or it won't ever be consumed by
function customers.
|
| |/
|
|
|
|
|
|
|
| |
This instance has already been reffed when passed to the task, and since
we're stealing it with `g_task_propagate_pointer` it won't be unreffed.
We could also do this in the `on_reauthentication_channel_opened` callback
but since the new task will ref it anyway, we can just be clean and do it
here.
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Now that we have a gdm-disable-wayland binary for disabling
wayland at boot, we should use it.
This commit changes the cirrus udev rule to use gdm-disable-wayland,
rather than running sh and printf.
https://bugzilla.gnome.org/show_bug.cgi?id=796315
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
We currently disable wayland for cirrus by calling printf
from a udev rule. This works, but it's a little too open
coded to easily write SELinux policy for.
This commit introduces a new program, gdm-disable-wayland,
that does the same thing, but in a dedicated binary.
A future commit will change the udev rule to use the binary.
https://bugzilla.gnome.org/show_bug.cgi?id=796315
|
| |
|
|
|
|
|
|
|
|
|
| |
gdm.conf-custom.in has a comment explaining how to disable wayland and
force Xorg.
That comment misspells the word "Uncomment".
This commit corrects the spelling.
https://bugzilla.gnome.org/show_bug.cgi?id=795825
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
gdm_display_access_file_remove_display is unused.
This commit drops it.
https://bugzilla.gnome.org/show_bug.cgi?id=796176
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The unused function gdm_display_access_file_remove_display frees
some variables and then tries to use them.
For completeness, this commit moves the free() calls to the
appropriate place in the code.
A subsequent commit will drop the function.
https://bugzilla.gnome.org/show_bug.cgi?id=796176
|
| |
|
|
|
|
|
|
|
| |
The GDBusProxies hold a strong reference to the connection themselves,
so maintaining separate weak references is unnecessary.
This commit drops those extraneous weak references.
https://bugzilla.gnome.org/show_bug.cgi?id=795940
|
| |
|
|
|
|
|
|
|
|
|
| |
At the moment we call gdm_client_open_connection and when it finishes,
assume client->priv->connection is implicitly initialized.
This commit makes the operation more explicit by changing
gdm_client_open_connection to gdm_client_get_connection and returning
the GDBusConnection object directly, instead of returning a boolean.
https://bugzilla.gnome.org/show_bug.cgi?id=795940
|
| |
|
|
|
|
|
|
|
|
|
| |
At the moment we add a weakref on each proxy to the connection
object. For the _sync variant functions, When the weakref fires,
they call g_clear_object, clearing the connection, even if other
proxies still have a reference.
This commit changes that weak ref code to use g_object_unref instead.
https://bugzilla.gnome.org/show_bug.cgi?id=795940
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Right now we keep the manager proxy alive long after we need it.
It doesn't get cleared until one of the other proxies go away.
That is not only unnecessary but illogical and confusing.
This commit changes the manager proxy to be transient—only alive
long enough to get what we need from it.
https://bugzilla.gnome.org/show_bug.cgi?id=795940
|
| |
|
|
|
|
|
|
|
| |
The manager fetching code in GdmClient treats its task
return value as boolean, but it's actually a pointer (the manager)
This commit corrects the confusion.
https://bugzilla.gnome.org/show_bug.cgi?id=795940
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now libgdm tries to handle multiple simultaneous
open calls at the same time by serializing the requests
and giving them all the same connection. It's broken,
though.
- The pending_opens list is never populated, so we
end up just doing multiple simultaneous open
operations at a time anyway.
- The finish code ends up calling
g_task_return_error (task, NULL) instead of
g_task_return_pointer in the non-error case.
Since the feature doesn't work, drop it for now.
https://bugzilla.gnome.org/show_bug.cgi?id=795940
|
| |
|
|
|
|
|
|
|
| |
At the moment we fail to nullify GdmClient's
connection to GDM when the connection is disposed.
This commit adds a weak pointer to correct that mistake.
https://bugzilla.gnome.org/show_bug.cgi?id=795940
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
If an async task tries to reuse an open connection,
it erroneously explicitly unrefs it. That is incorrect,
because there are weak references in use to handle
disposing the connection when its no longer in use.
This commit makes sure the local connection object
in open_connection is nullified so the connection
doesn't get autofree'd.
https://bugzilla.gnome.org/show_bug.cgi?id=795940
|
| |
|
|
|
|
|
| |
If launching gdm from special environments (as jhbuild) these should
be forwarded to the children greeter and launched apps too.
https://bugzilla.gnome.org/show_bug.cgi?id=795886
|
| |
|
|
|
|
| |
There's no need to add a different code path for this global env.
https://bugzilla.gnome.org/show_bug.cgi?id=795886
|
| |
|
|
|
|
| |
As per better readability.
https://bugzilla.gnome.org/show_bug.cgi?id=795886
|
| |
|
|
|
|
|
|
|
|
|
| |
When using unknown command line options with the GDM daemon, the
program hangs until explicitly getting killed.
This commit addresses that bug by dropping an unnecessary call to
g_option_context_set_ignore_unknown_options, so GOptionContext will
now give an error when encountering unknown options.
https://bugzilla.gnome.org/show_bug.cgi?id=795494
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gdm is responsible to kill plymouth by spawning the "plymouth quit"
subprocesses in gdm-manager.c. The current code pathes of quiting
plymouth can never be reached when xdmcp is the only connection
allowed. Consequently in the case of
!show_local_greeter && xdmcp_enabled
the plymouth-quit-wait.service will never quit and the login prompt
will not popup without manual interference. This issue could be
more obviously observed when a downstream like openSUSE which
allows a customized sysconfig to switch the corresponding two
options on a headless server (s390), where the setup is usually:
DISPLAYMANAGER_REMOTE_ACCESS="yes"
DISPLAYMANAGER_STARTS_XSERVER="no"
The proposed patch handles this edge case by quit plymouth immediately
when the condition is detected.
https://bugzilla.gnome.org/show_bug.cgi?id=795120
|
| |
|
|
| |
(cherry picked from commit 6b5c3691e4b881ee430b1749971facc92b141855)
|
| |
|
|
| |
(cherry picked from commit f2645e8922d6efd8af6e44906d7d91e91b6f6730)
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Signed-off-by: Trần Ngọc Quân <vnwildman@gmail.com>
|
| |
|
|
|
|
|
|
|
|
| |
The gdm_available_sessions_map hash table is set up with a value-free
function that frees the struct itself, but not its contents.
Of course elements are never removed from the map, so this fix doesn't
matter in practice.
https://bugzilla.gnome.org/show_bug.cgi?id=793855
|
